ci: document test env cleanup in hook

Author: lox

.buildkite/hooks/pre-command

@@ -12,3 +12,11 @@ mkdir -p \
 export GOCACHE="${cache_root}/go/build"
 export GOMODCACHE="${cache_root}/go/pkg/mod"
 export GOLANGCI_LINT_CACHE="${cache_root}/golangci-lint"
+
+if [[ "${BUILDKITE_STEP_KEY:-}" == "test" ]]; then
+  # Hosted agents inject the pipeline org and API token into the step
+  # environment. A subset of CLI tests exercise config precedence and must not
+  # inherit those ambient overrides, or they resolve the live Buildkite org
+  # instead of the fixture-backed test config.
+  unset BUILDKITE_API_TOKEN BUILDKITE_ORGANIZATION_SLUG
+fi

.buildkite/pipeline.yml

@@ -13,11 +13,9 @@ steps:
       - *mise_plugin
 
   - name: ":go: test"
+    key: test
     artifact_paths:
       - cover-tree.svg
-    env:
-      BUILDKITE_API_TOKEN: ""
-      BUILDKITE_ORGANIZATION_SLUG: ""
     commands:
       - go test -coverprofile cover.out ./...
       - go run github.com/nikolaydubina/go-cover-treemap@v1.5.1 -coverprofile cover.out > cover-tree.svg