Skip to content

Commit 5802af0

Browse files
leogdionclaude
andcommitted
Fix PR #147 review comments
- Comment out .unsafeFlags in Package.swift to restore SPM dependency compatibility - Update README SPM version reference from 0.0.3 to 0.0.4 - Fix devcontainer.json extension indentation (3-space → 4-space) - Add trailing newlines to .periphery.yml and .vscode/launch.json - Remove .vscode from .gitignore - Fix multiline_arguments_brackets violations in SyntaxDocTests/Settings.swift Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent c801a0d commit 5802af0

7 files changed

Lines changed: 22 additions & 23 deletions

File tree

.devcontainer/swift-6.1/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
},
2929
// Add the IDs of extensions you want installed when the container is created.
3030
"extensions": [
31-
"swiftlang.swift-vscode"
31+
"swiftlang.swift-vscode"
3232
]
3333
}
3434
},

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@ node_modules/
152152
.env
153153
# Editor directories and files
154154
.idea
155-
.vscode
156155
*.suo
157156
*.ntvs*
158157
*.njsproj

.periphery.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
retain_public: true
2-
retain_codable_properties: true
2+
retain_codable_properties: true

.vscode/launch.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@
2121
"configuration": "release"
2222
}
2323
]
24-
}
24+
}

Package.swift

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -60,20 +60,20 @@ let swiftSettings: [SwiftSetting] = [
6060
.enableExperimentalFeature("WarnUnsafeReflection"),
6161

6262
// Enhanced compiler checking
63-
.unsafeFlags([
64-
// Enable concurrency warnings
65-
"-warn-concurrency",
66-
// Enable actor data race checks
67-
"-enable-actor-data-race-checks",
68-
// Complete strict concurrency checking
69-
"-strict-concurrency=complete",
70-
// Enable testing support
71-
"-enable-testing",
72-
// Warn about functions with >100 lines
73-
"-Xfrontend", "-warn-long-function-bodies=100",
74-
// Warn about slow type checking expressions
75-
"-Xfrontend", "-warn-long-expression-type-checking=100"
76-
])
63+
// .unsafeFlags([
64+
// // Enable concurrency warnings
65+
// "-warn-concurrency",
66+
// // Enable actor data race checks
67+
// "-enable-actor-data-race-checks",
68+
// // Complete strict concurrency checking
69+
// "-strict-concurrency=complete",
70+
// // Enable testing support
71+
// "-enable-testing",
72+
// // Warn about functions with >100 lines
73+
// "-Xfrontend", "-warn-long-function-bodies=100",
74+
// // Warn about slow type checking expressions
75+
// "-Xfrontend", "-warn-long-expression-type-checking=100"
76+
// ])
7777
]
7878

7979
// swiftlint:disable:next explicit_top_level_acl explicit_acl

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ Add SyntaxKit to your project using Swift Package Manager:
7373
```swift
7474
// Package.swift
7575
dependencies: [
76-
.package(url: "https://github.com/brightdigit/SyntaxKit.git", from: "0.0.3")
76+
.package(url: "https://github.com/brightdigit/SyntaxKit.git", from: "0.0.4")
7777
]
7878
```
7979

Tests/SyntaxDocTests/Settings.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ internal enum Settings {
2222
// a flat sibling of the test binary. Strategy 1a always runs first, so a macOS project
2323
// root containing Sources/ will never reach this check.
2424
if FileManager.default.fileExists(
25-
atPath: workingDir.appendingPathComponent("Documentation.docc").path)
26-
{
25+
atPath: workingDir.appendingPathComponent("Documentation.docc").path
26+
) {
2727
return workingDir
2828
}
2929

@@ -33,8 +33,8 @@ internal enum Settings {
3333
.deletingLastPathComponent() // Tests
3434
.deletingLastPathComponent() // Project root
3535
if FileManager.default.fileExists(
36-
atPath: sourceRelative.appendingPathComponent("Sources").path)
37-
{
36+
atPath: sourceRelative.appendingPathComponent("Sources").path
37+
) {
3838
return sourceRelative
3939
}
4040

0 commit comments

Comments
 (0)