fix(types): allow job static dispatch methods on DI-backed subclasses

Author: RomainLanz

src/job.ts

@@ -171,7 +171,7 @@ export abstract class Job<Payload = any> {
    * ```
    */
   static dispatch<T extends Job>(
-    this: new (...args: unknown[]) => T,
+    this: abstract new (...args: any[]) => T,
     payload: T extends Job<infer P> ? P : never
   ): JobDispatcher<T extends Job<infer P> ? P : never> {
     const jobClass = this as unknown as { options?: JobOptions; name: string }
@@ -223,7 +223,7 @@ export abstract class Job<Payload = any> {
    * ```
    */
   static dispatchMany<T extends Job>(
-    this: new (...args: unknown[]) => T,
+    this: abstract new (...args: any[]) => T,
     payloads: (T extends Job<infer P> ? P : never)[]
   ): JobBatchDispatcher<T extends Job<infer P> ? P : never> {
     const jobClass = this as unknown as { options?: JobOptions; name: string }
@@ -273,7 +273,7 @@ export abstract class Job<Payload = any> {
    * ```
    */
   static schedule<T extends Job>(
-    this: new (...args: unknown[]) => T,
+    this: abstract new (...args: any[]) => T,
     payload: T extends Job<infer P> ? P : never
   ): ScheduleBuilder<T extends Job<infer P> ? P : never> {
     const jobClass = this as unknown as { options?: JobOptions; name: string }

tests/job.spec.ts

@@ -0,0 +1,33 @@
+import { test } from '@japa/runner'
+import { Job } from '../src/job.js'
+import { JobDispatcher } from '../src/job_dispatcher.js'
+import { JobBatchDispatcher } from '../src/job_batch_dispatcher.js'
+import { ScheduleBuilder } from '../src/schedule_builder.js'
+
+class PaymentService {}
+
+class ProcessPaymentJob extends Job<{ paymentId: string }> {
+  constructor(protected paymentService: PaymentService) {
+    super()
+  }
+
+  async execute() {
+    void this.paymentService
+  }
+}
+
+test.group('Job static methods', () => {
+  test('should support subclasses with typed constructor injection', ({ assert, expectTypeOf }) => {
+    const dispatcher = ProcessPaymentJob.dispatch({ paymentId: 'pay_123' })
+    const batchDispatcher = ProcessPaymentJob.dispatchMany([{ paymentId: 'pay_123' }])
+    const schedule = ProcessPaymentJob.schedule({ paymentId: 'pay_123' })
+
+    assert.instanceOf(dispatcher, JobDispatcher)
+    assert.instanceOf(batchDispatcher, JobBatchDispatcher)
+    assert.instanceOf(schedule, ScheduleBuilder)
+
+    expectTypeOf(dispatcher).toEqualTypeOf<JobDispatcher<{ paymentId: string }>>()
+    expectTypeOf(batchDispatcher).toEqualTypeOf<JobBatchDispatcher<{ paymentId: string }>>()
+    expectTypeOf(schedule).toEqualTypeOf<ScheduleBuilder<{ paymentId: string }>>()
+  })
+})