Fix build warnings, update changelog

Author: boltgolt

howdy/debian/changelog

@@ -1,3 +1,14 @@
+howdy (3.0.0) focal; urgency=medium
+
+  * Way too many changes to all list individually, thanks to everyone who contributed!
+  * Rewrote PAM handling logic in C++ (thanks @saidsay-so!)
+  * Added simultaneous face recognition and password authentication
+  * Added native dialog dismissal after successful authentication
+  * Added configurable image rotation (thanks @matan-arnon!)
+  * Fixed four config options whose names were opposite of their function
+
+ -- boltgolt <boltgolt@gmail.com>  Sun, 22 Jun 2025 11:52:44 +0200
+
 howdy (2.6.1) xenial; urgency=medium
 
   * Fixed accidentally using emergency priority for log messages (thanks @kageurufu and many others!)

howdy/debian/postinst

@@ -128,15 +128,15 @@ handleStatus(sc(cmd))
 DLIB_DIR = None
 # A regex of all files to ignore while unpacking the archive
 excludes = re.compile(
-	"davisking-dlib-\w+/(dlib/(http_client|java|matlab|test/)|"
-	"(docs|examples|python_examples)|"
-	"tools/(archive|convert_dlib_nets_to_caffe|htmlify|imglab|python/test|visual_studio_natvis))"
+	r"davisking-dlib-\w+/(dlib/(http_client|java|matlab|test/)|"
+	r"(docs|examples|python_examples)|"
+	r"tools/(archive|convert_dlib_nets_to_caffe|htmlify|imglab|python/test|visual_studio_natvis))"
 )
 
 # Open the archive
 with tarfile.open(dlib_archive) as tf:
 	for item in tf:
-		# Set the destenation dir if unset
+		# Set the destination dir if unset
 		if not DLIB_DIR:
 			DLIB_DIR = "/tmp/" + item.name
 
@@ -159,7 +159,7 @@ except subprocess.CalledProcessError:
 	print("Error while building dlib")
 	raise
 
-# Go through each line from stdout
+# Go through each line from stdout to check for CUDA usage
 while sp.poll() is None:
 	line = sp.stdout.readline().decode("utf-8")
 
@@ -178,12 +178,12 @@ print("Temporary dlib files removed")
 
 log("Configuring howdy")
 
-# Manually change the camera id to the one picked
+# Make sure to use CNN if dlib was compiled with CUDA support
 for line in fileinput.input(["/etc/howdy/config.ini"], inplace=1):
 	line = line.replace("use_cnn = false", "use_cnn = " + str(cuda_used).lower())
 	print(line, end="")
 
-print("Camera ID saved")
+print("CNN saved to config, CUDA " + ("enabled" if cuda_used else "disabled"))
 
 # Secure the howdy folder
 handleStatus(sc(["chmod 755 -R /lib/security/howdy/"], shell=True))

howdy/src/pam/enter_device.cc

@@ -15,10 +15,10 @@ EnterDevice::EnterDevice()
 
   int err;
   struct libevdev_uinput *uinput_dev_ptr;
-  if ((err = libevdev_uinput_create_from_device(
-           dev_ptr, LIBEVDEV_UINPUT_OPEN_MANAGED, &uinput_dev_ptr)) != 0) {
-    throw std::runtime_error(std::string("Failed to create device: ") +
-                             strerror(-err));
+
+  err = libevdev_uinput_create_from_device(dev_ptr, LIBEVDEV_UINPUT_OPEN_MANAGED, &uinput_dev_ptr);
+  if (err != 0) {
+    throw std::runtime_error(std::string("Failed to create device: ") + strerror(-err));
   }
 
   raw_uinput_device.reset(uinput_dev_ptr);
@@ -28,21 +28,18 @@ void EnterDevice::send_enter_press() const {
   auto *uinput_dev_ptr = raw_uinput_device.get();
 
   int err;
-  if ((err = libevdev_uinput_write_event(uinput_dev_ptr, EV_KEY, KEY_ENTER,
-                                         1)) != 0) {
-    throw std::runtime_error(std::string("Failed to write event: ") +
-                             strerror(-err));
+  err = libevdev_uinput_write_event(uinput_dev_ptr, EV_KEY, KEY_ENTER, 1);
+  if (err != 0) {
+    throw std::runtime_error(std::string("Failed to write event: ") + strerror(-err));
   }
 
-  if ((err = libevdev_uinput_write_event(uinput_dev_ptr, EV_KEY, KEY_ENTER,
-                                         0)) != 0) {
-    throw std::runtime_error(std::string("Failed to write event: ") +
-                             strerror(-err));
+  err = libevdev_uinput_write_event(uinput_dev_ptr, EV_KEY, KEY_ENTER, 0);
+  if (err != 0) {
+    throw std::runtime_error(std::string("Failed to write event: ") + strerror(-err));
   }
 
-  if ((err = libevdev_uinput_write_event(uinput_dev_ptr, EV_SYN, SYN_REPORT,
-                                         0)) != 0) {
-    throw std::runtime_error(std::string("Failed to write event: ") +
-                             strerror(-err));
-  };
+  err = libevdev_uinput_write_event(uinput_dev_ptr, EV_SYN, SYN_REPORT, 0);
+  if (err != 0) {
+    throw std::runtime_error(std::string("Failed to write event: ") + strerror(-err));
+  }
 }

howdy/src/pam/main.cc

@@ -190,7 +190,7 @@ auto check_enabled(const INIReader &config, const char *username) -> int {
  * The main function, runs the identification and authentication
  * @param  pamh     The handle to interface directly with PAM
  * @param  flags    Flags passed on to us by PAM, XORed
- * @param  argc     Amount of rules in the PAM config (disregared)
+ * @param  argc     Amount of rules in the PAM config (disregarded)
  * @param  argv     Options defined in the PAM config
  * @param  ask_auth_tok True if we should ask for a password too
  * @return          Returns a PAM return code
@@ -212,14 +212,15 @@ auto identify(pam_handle_t *pamh, int flags, int argc, const char **argv,
 
   // Get the username from PAM, needed to match correct face model
   char *username = nullptr;
-  if ((pam_res = pam_get_user(pamh, const_cast<const char **>(&username),
-                              nullptr)) != PAM_SUCCESS) {
+  pam_res = pam_get_user(pamh, const_cast<const char **>(&username), nullptr);
+  if (pam_res != PAM_SUCCESS) {
     syslog(LOG_ERR, "Failed to get username");
     return pam_res;
   }
 
   // Check if we should continue
-  if ((pam_res = check_enabled(config, username)) != PAM_SUCCESS) {
+  pam_res = check_enabled(config, username);
+  if (pam_res != PAM_SUCCESS) {
     return pam_res;
   }
 
@@ -231,7 +232,9 @@ auto identify(pam_handle_t *pamh, int flags, int argc, const char **argv,
   const void **conv_ptr =
       const_cast<const void **>(reinterpret_cast<void **>(&conv));
 
-  if ((pam_res = pam_get_item(pamh, PAM_CONV, conv_ptr)) != PAM_SUCCESS) {
+  // Retrieve the PAM conversation structure
+  pam_res = pam_get_item(pamh, PAM_CONV, conv_ptr);
+  if (pam_res != PAM_SUCCESS) {
     syslog(LOG_ERR, "Failed to acquire conversation");
     return pam_res;
   }

howdy/src/pam/main.hh

@@ -4,13 +4,13 @@
 #include <cstring>
 #include <string>
 #include <unistd.h>
+#include <cstdint>
 
-enum class ConfirmationType { Unset, Howdy, Pam };
-
-enum class Workaround { Off, Input, Native };
+enum class ConfirmationType : std::uint8_t { Unset, Howdy, Pam };
+enum class Workaround : std::uint8_t { Off, Input, Native };
 
 // Exit status codes returned by the compare process
-enum CompareError : int {
+enum CompareError : std::uint8_t {
   NO_FACE_MODEL = 10,
   TIMEOUT_REACHED = 11,
   ABORT = 12,