Remove C-style casts

Author: maxwellmattryan

src/dsp/generators/oscillator.cpp

@@ -42,7 +42,7 @@ void Oscillator::AttachParameterToSourceImpl(OscillatorParameter parameter, std:
 
 void Oscillator::Reset(float phase)
 {
-    float clampedPhase = clamp(phase, 0.0f, (float)WAVETABLE_SIZE);
+    float clampedPhase = clamp(phase, 0.0f, static_cast<float>(WAVETABLE_SIZE));
     m_phase = clampedPhase;
     if (m_follower != nullptr) {
         m_follower->Reset(clampedPhase);
@@ -52,7 +52,7 @@ void Oscillator::Reset(float phase)
 void Oscillator::SetFrequency(float frequency)
 {
     p_frequency = frequency;
-    m_phaseIncrement = p_frequency * (float)WAVETABLE_SIZE / (float)m_context.sampleRate;
+    m_phaseIncrement = p_frequency * static_cast<float>(WAVETABLE_SIZE) / static_cast<float>(m_context.sampleRate);
 }
 
 void Oscillator::SetWaveform(Waveform waveform)
@@ -75,16 +75,16 @@ void Oscillator::DetachFollower()
 void Oscillator::PopulateWavetable()
 {
     for (size_t idx = 0; idx < WAVETABLE_SIZE; idx++) {
-        float phase = (float)idx * PI * 2.0f / (float)WAVETABLE_SIZE;
+        float phase = static_cast<float>(idx) * PI * 2.0f / static_cast<float>(WAVETABLE_SIZE);
         m_wavetable[idx] = sin(phase);
     }
 }
 
 void Oscillator::IncrementPhase()
 {
     m_phase += m_phaseIncrement;
-    if (m_phase >= (float)WAVETABLE_SIZE) {
-        m_phase -= (float)WAVETABLE_SIZE;
+    if (m_phase >= static_cast<float>(WAVETABLE_SIZE)) {
+        m_phase -= static_cast<float>(WAVETABLE_SIZE);
         if (m_follower != nullptr) {
             m_follower->Reset(m_phase);
         }
@@ -95,7 +95,7 @@ Sample Oscillator::Lerp()
 {
     size_t truncatedIdx = m_phase;
     size_t nextIdx = (truncatedIdx + 1) % WAVETABLE_SIZE;
-    float nextIdxWeight = m_phase - (float)truncatedIdx;
+    float nextIdxWeight = m_phase - static_cast<float>(truncatedIdx);
     float truncatedIdxWeight = 1.0f - nextIdxWeight;
 
     return (m_wavetable[truncatedIdx] * truncatedIdxWeight) + (m_wavetable[nextIdx] * nextIdxWeight);

src/dsp/modulators/adsr.cpp

@@ -13,7 +13,7 @@ AdsrEnvelopeModulator::AdsrEnvelopeModulator(Context& context, AdsrEnvelope enve
 
 float AdsrEnvelopeModulator::ModulateImpl()
 {
-    float position = (float)m_samplesSinceLastStage * (1000.0f / (float)m_context.sampleRate);
+    float position = static_cast<float>(m_samplesSinceLastStage) * (1000.0f / static_cast<float>(m_context.sampleRate));
 
     /**
      * NOTE: The modulation value is calculated based on the current stage of the modulator.
@@ -117,8 +117,8 @@ void AdsrEnvelopeModulator::Update(float stageDuration, AdsrStage nextStage, boo
         m_samplesSinceLastStage++;
     }
 
-    float msPerSample = 1000.0f / (float)m_context.sampleRate;
-    if ((float)m_samplesSinceLastStage * msPerSample >= stageDuration) {
+    float msPerSample = 1000.0f / static_cast<float>(m_context.sampleRate);
+    if (static_cast<float>(m_samplesSinceLastStage) * msPerSample >= stageDuration) {
         m_samplesSinceLastStage = 0;
         m_stage = nextStage;
     }

src/dsp/processors/filter.cpp

@@ -40,6 +40,6 @@ void Filter::SetCutoffFrequency(float frequency)
 void Filter::CalculateAlpha()
 {
     float cutoffResponse = 1.0f / (2.0f * PI * p_cutoffFrequency);
-    float deltaTime = 1.0f / (float)m_context.sampleRate;
+    float deltaTime = 1.0f / static_cast<float>(m_context.sampleRate);
     m_alpha = deltaTime / (cutoffResponse + deltaTime);
 }

tests/dsp/generators/oscillator_test.cpp

@@ -34,7 +34,7 @@ TEST(oscillator_suite, reset_test)
     EXPECT_FLOAT_EQ(osc.Generate(), 0.0f);
     EXPECT_FLOAT_EQ(osc.Generate(), 0.06264372f);
 
-    osc.Reset((float)WAVETABLE_SIZE / 2.0f);
+    osc.Reset(static_cast<float>(WAVETABLE_SIZE) / 2.0f);
     EXPECT_NEAR(osc.Generate(), 0.0f, 1e-5f);
     EXPECT_NEAR(osc.Generate(), -0.06264372f, 1e-5f);
 }