[NTOS:MM][KMTESTS] MmMapViewOfSection: Handle PAGE_NOCACHE and PAGE_WRITECOMBINE flags (reactos#8502)

- Remove the hack for PAGE_NOCACHE flag that was introduced in commits aa52dc7 (r68611) and 33d53d4 (r68612) for CORE-9808. The test case for PAGE_NOCACHE, introduced in 7346aec (r68351), did not expose any additional problems without it anymore.
- Allow a PAGE_WRITECOMBINE flag. Fixes a regression introduced in 59ae6b3 (CORE-20298) that caused the OpenGL ICD in Nvidia 78.05 driver to not use GPU hardware to accelerate OpenGL anymore (reported and tested by winterhell on Discord).
- Add a test case for MmMapViewOfSection with PAGE_WRITECOMBINE. The test passes on Windows 2003 SP2 and Vista RTM.
- Fix ASSERTs in MI_MAKE_HARDWARE_PTE functions.

Author: archeYR

modules/rostests/kmtests/ntos_mm/MmSection.c

@@ -646,6 +646,31 @@ TestPhysicalMemorySection(VOID)
             ok_eq_hex(Status, STATUS_SUCCESS);
         }
 
+        /* Map the zero page with write combining */
+        Mapping = NULL;
+        ViewSize = PAGE_SIZE;
+        Status = ZwMapViewOfSection(SectionHandle,
+                                    ZwCurrentProcess(),
+                                    &Mapping,
+                                    0,
+                                    0,
+                                    &ZeroPagePhysical,
+                                    &ViewSize,
+                                    ViewUnmap,
+                                    0,
+                                    PAGE_READWRITE | PAGE_WRITECOMBINE);
+        ok_eq_hex(Status, STATUS_SUCCESS);
+        if (!skip(NT_SUCCESS(Status), "No view\n"))
+        {
+            ok((LONG_PTR)Mapping > 0, "Mapping = %p\n", Mapping);
+            EqualBytes = RtlCompareMemory(Mapping,
+                                          ZeroPageContents,
+                                          PAGE_SIZE);
+            ok_eq_size(EqualBytes, PAGE_SIZE);
+            Status = ZwUnmapViewOfSection(ZwCurrentProcess(), Mapping);
+            ok_eq_hex(Status, STATUS_SUCCESS);
+        }
+
         /* Map our NP page, compare, and check that modifications are reflected */
         Mapping = NULL;
         ViewSize = PAGE_SIZE;

ntoskrnl/include/internal/mm.h

@@ -145,7 +145,8 @@ typedef ULONG_PTR SWAPENTRY;
      PAGE_EXECUTE_READWRITE | \
      PAGE_EXECUTE_WRITECOPY | \
      PAGE_NOACCESS | \
-     PAGE_NOCACHE)
+     PAGE_NOCACHE | \
+     PAGE_WRITECOMBINE)
 
 #define PAGE_IS_READABLE                    \
     (PAGE_READONLY | \

ntoskrnl/mm/ARM3/miarm.h

@@ -786,7 +786,8 @@ MI_MAKE_HARDWARE_PTE_KERNEL(IN PMMPTE NewPte,
 
     /* Check that we are not setting valid a page that should not be */
     ASSERT(ProtectionMask & MM_PROTECT_ACCESS);
-    ASSERT((ProtectionMask & MM_GUARDPAGE) == 0);
+    ASSERT((ProtectionMask & MM_PROTECT_SPECIAL) != MM_GUARDPAGE);
+    ASSERT(ProtectionMask != MM_OUTSWAPPED_KSTACK && ((ProtectionMask & ~MM_OUTSWAPPED_KSTACK) == 0));
 
     /* Start fresh */
     NewPte->u.Long = 0;
@@ -815,7 +816,8 @@ MI_MAKE_HARDWARE_PTE(IN PMMPTE NewPte,
 {
     /* Check that we are not setting valid a page that should not be */
     ASSERT(ProtectionMask & MM_PROTECT_ACCESS);
-    ASSERT((ProtectionMask & MM_GUARDPAGE) == 0);
+    ASSERT((ProtectionMask & MM_PROTECT_SPECIAL) != MM_GUARDPAGE);
+    ASSERT(ProtectionMask != MM_OUTSWAPPED_KSTACK && ((ProtectionMask & ~MM_OUTSWAPPED_KSTACK) == 0));
 
     /* Set the protection and page */
     NewPte->u.Long = MiDetermineUserGlobalPteMask(MappingPte);
@@ -841,7 +843,8 @@ MI_MAKE_HARDWARE_PTE_USER(IN PMMPTE NewPte,
 
     /* Check that we are not setting valid a page that should not be */
     ASSERT(ProtectionMask & MM_PROTECT_ACCESS);
-    ASSERT((ProtectionMask & MM_GUARDPAGE) == 0);
+    ASSERT((ProtectionMask & MM_PROTECT_SPECIAL) != MM_GUARDPAGE);
+    ASSERT(ProtectionMask != MM_OUTSWAPPED_KSTACK && ((ProtectionMask & ~MM_OUTSWAPPED_KSTACK) == 0));
 
     NewPte->u.Hard.Valid = TRUE;
     NewPte->u.Hard.Owner = TRUE;

ntoskrnl/mm/section.c

@@ -4070,9 +4070,6 @@ MmMapViewOfSection(IN PVOID SectionObject,
         IsAttached = TRUE;
     }
 
-    /* FIXME: We should keep this, but it would break code checking equality */
-    Protect &= ~PAGE_NOCACHE;
-
     Section = SectionObject;
     AddressSpace = &Process->Vm;