Skip to content

Commit 9da4592

Browse files
committed
[CONFIGURE] Adjust some echo'ed strings (reactos#7773)
[CONFIGURE.CMD] Use multi-command syntax instead of AND operator for successive echo's And adjust few strings. [CONFIGURE.SH] Quote the echo'ed strings, and adjust some of them.
1 parent 57fa5a2 commit 9da4592

2 files changed

Lines changed: 17 additions & 19 deletions

File tree

configure.cmd

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ set REACTOS_SOURCE_DIR=%~dp0
2424
REM Ensure there's no spaces in the source path
2525
echo %REACTOS_SOURCE_DIR%| find " " > NUL
2626
if %ERRORLEVEL% == 0 (
27-
echo. && echo Your source path contains at least one space.
27+
echo. & echo Your source path contains at least one space.
2828
echo This will cause problems with building.
2929
echo Please rename your folders so there are no spaces in the source path,
3030
echo or move your source to a different folder.
@@ -97,14 +97,14 @@ set REMAINING=%*
9797
) else if /I "!PARAM!" == "Ninja" (
9898
set CMAKE_GENERATOR="Ninja"
9999
) else if /I "!PARAM!" == "VSSolution" (
100-
echo. && echo Error: Creation of VS Solution files is not supported in a MinGW environment.
100+
echo. & echo Error: Creation of VS Solution files is not supported in a MinGW environment.
101101
echo Please run this command in a [Developer] Command Prompt for Visual Studio.
102102
goto quit
103103
) else if /I "!PARAM:~0,2!" == "-D" (
104104
REM User is passing a switch to CMake
105105
set "CMAKE_PARAMS=%CMAKE_PARAMS% !PARAM!"
106106
) else (
107-
echo. && echo Warning: Unrecognized switch "!PARAM!" && echo.
107+
echo. & echo Warning: Unrecognized switch "!PARAM!" & echo.
108108
)
109109
) else (
110110
if /I "!PARAM!" == "CodeBlocks" (
@@ -145,7 +145,7 @@ set REMAINING=%*
145145
REM User is passing a switch to CMake
146146
set "CMAKE_PARAMS=%CMAKE_PARAMS% !PARAM!"
147147
) else (
148-
echo. && echo Warning: Unrecognized switch "!PARAM!" && echo.
148+
echo. & echo Warning: Unrecognized switch "!PARAM!" & echo.
149149
)
150150
)
151151

@@ -175,17 +175,16 @@ if "%REACTOS_SOURCE_DIR%" == "%CD%\" (
175175
)
176176

177177
if "%VS_SOLUTION%" == "1" (
178-
179178
if exist build.ninja (
180-
echo. && echo Error: This directory has already been configured for ninja.
179+
echo. & echo Error: This directory has already been configured for ninja.
181180
echo An output folder configured for ninja can't be reconfigured for VSSolution.
182181
echo Use an empty folder or delete the contents of this folder, then try again.
183182
goto quit
184183
)
185184
) else if exist REACTOS.sln (
186-
echo. && echo Error: This directory has already been configured for Visual Studio.
185+
echo. & echo Error: This directory has already been configured for Visual Studio.
187186
echo An output folder configured for VSSolution can't be reconfigured for ninja.
188-
echo Use an empty folder or delete the contents of this folder, then try again. && echo.
187+
echo Use an empty folder or delete the contents of this folder, then try again. & echo.
189188
goto quit
190189
)
191190

@@ -195,7 +194,6 @@ if EXIST CMakeCache.txt (
195194
del CMakeCache.txt /q
196195
)
197196

198-
199197
if "%BUILD_ENVIRONMENT%" == "MinGW" (
200198
cmake -G %CMAKE_GENERATOR% -DENABLE_CCACHE:BOOL=0 -DCMAKE_TOOLCHAIN_FILE:FILEPATH=%MINGW_TOOCHAIN_FILE% -DARCH:STRING=%ARCH% %BUILD_TOOLS_FLAG% %CMAKE_PARAMS% "%REACTOS_SOURCE_DIR%"
201199
) else if %USE_CLANG_CL% == 1 (
@@ -213,17 +211,17 @@ if "%CD_SAME_AS_SOURCE%" == "1" (
213211
)
214212

215213
if "%VS_SOLUTION%" == "1" (
216-
set ENDV= You can now use msbuild or open REACTOS.sln%ENDV%.
214+
set ENDV= You can now use msbuild or open REACTOS.sln%ENDV%
217215
) else (
218-
set ENDV= Execute appropriate build commands ^(ex: ninja, make, nmake, etc...^)%ENDV%
216+
set ENDV= Execute appropriate build commands ^(e.g. ninja, make, nmake, etc.^)%ENDV%
219217
)
220218

221-
echo. && echo Configure script complete^^!%ENDV%
219+
echo. & echo Configure script complete^^!%ENDV%
222220

223221
goto quit
224222

225223
:cmake_notfound
226-
echo Unable to find cmake, if it is installed, check your PATH variable.
224+
echo Unable to find cmake. If it is installed, check your PATH variable.
227225

228226
:quit
229227
endlocal

configure.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#!/bin/sh
22

33
if [ "x$ROS_ARCH" = "x" ]; then
4-
echo Could not detect RosBE.
4+
echo "Could not detect RosBE."
55
exit 1
66
fi
77

@@ -11,7 +11,7 @@ REACTOS_SOURCE_DIR=$(cd `dirname $0` && pwd)
1111
REACTOS_OUTPUT_PATH=output-$BUILD_ENVIRONMENT-$ARCH
1212

1313
usage() {
14-
echo Invalid parameter given.
14+
echo "Invalid parameter given."
1515
exit 1
1616
}
1717

@@ -41,18 +41,18 @@ while [ $# -gt 0 ]; do
4141
done
4242

4343
if [ "$REACTOS_SOURCE_DIR" = "$PWD" ]; then
44-
echo Creating directories in $REACTOS_OUTPUT_PATH
44+
echo "Creating directories in $REACTOS_OUTPUT_PATH"
4545
mkdir -p "$REACTOS_OUTPUT_PATH"
4646
cd "$REACTOS_OUTPUT_PATH"
4747
fi
4848

49-
echo Preparing reactos...
49+
echo "Preparing reactos..."
5050
rm -f CMakeCache.txt host-tools/CMakeCache.txt
5151

5252
cmake -G "$CMAKE_GENERATOR" -DENABLE_CCACHE:BOOL=0 -DCMAKE_TOOLCHAIN_FILE:FILEPATH=toolchain-gcc.cmake -DARCH:STRING=$ARCH $EXTRA_ARGS $ROS_CMAKEOPTS "$REACTOS_SOURCE_DIR"
5353
if [ $? -ne 0 ]; then
54-
echo "An error occured while configuring ReactOS"
54+
echo "An error occurred while configuring ReactOS"
5555
exit 1
5656
fi
5757

58-
echo Configure script complete! Enter directories and execute appropriate build commands \(ex: ninja, make, makex, etc...\).
58+
echo "Configure script complete! Execute appropriate build commands (e.g. ninja, make, makex, etc.) from $REACTOS_OUTPUT_PATH"

0 commit comments

Comments
 (0)