Skip to content

Commit 48757bc

Browse files
committed
[WIN32U_APITEST] Improve NtUserScrollDC test
1 parent a479aff commit 48757bc

1 file changed

Lines changed: 17 additions & 18 deletions

File tree

modules/rostests/apitests/win32u/ntuser/NtUserScrollDC.c

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ START_TEST(NtUserScrollDC)
3636

3737
hRgn = CreateRectRgn(0,0,10,10);
3838

39-
4039
/* Test inverted clip rect */
4140
rcScroll.left = 0;
4241
rcScroll.top = 25;
@@ -48,8 +47,8 @@ START_TEST(NtUserScrollDC)
4847
rcClip.bottom = -1000;
4948
SetLastError(ERROR_SUCCESS);
5049
Result = NtUserScrollDC(hDC, 10, 20, &rcScroll, &rcClip, hRgn, &rcUpdate);
51-
RTEST(Result == 1);
52-
RTEST(GetLastError() == ERROR_SUCCESS);
50+
ok_eq_int(Result, TRUE);
51+
ok_eq_ulong(GetLastError(), ERROR_SUCCESS);
5352

5453
/* Test inverted scroll rect */
5554
rcScroll.left = 0;
@@ -62,8 +61,8 @@ START_TEST(NtUserScrollDC)
6261
rcClip.bottom = 1000;
6362
SetLastError(ERROR_SUCCESS);
6463
Result = NtUserScrollDC(hDC, 10, 20, &rcScroll, &rcClip, hRgn, &rcUpdate);
65-
RTEST(Result == 1);
66-
RTEST(GetLastError() == ERROR_SUCCESS);
64+
ok_eq_int(Result, TRUE);
65+
ok_eq_ulong(GetLastError(), ERROR_SUCCESS);
6766

6867
rcScroll.left = 0;
6968
rcScroll.top = 25;
@@ -73,36 +72,36 @@ START_TEST(NtUserScrollDC)
7372
/* Test invalid update region */
7473
SetLastError(ERROR_SUCCESS);
7574
Result = NtUserScrollDC(hDC, 10, 20, &rcScroll, &rcClip, (HRGN)0x123456, &rcUpdate);
76-
RTEST(Result == 0);
77-
TEST(GetLastError() == ERROR_INVALID_HANDLE);
75+
ok_eq_int(Result, FALSE);
76+
ok_eq_ulong(GetLastError(), ERROR_INVALID_HANDLE);
7877

7978
/* Test invalid dc */
8079
SetLastError(ERROR_SUCCESS);
8180
Result = NtUserScrollDC((HDC)0x123456, 10, 20, &rcScroll, &rcClip, hRgn, &rcUpdate);
82-
RTEST(Result == 0);
83-
RTEST(GetLastError() == ERROR_SUCCESS);
81+
ok_eq_int(Result, FALSE);
82+
ok_eq_ulong(GetLastError(), ERROR_SUCCESS);
8483

8584
/* Test invalid update rect */
8685
SetLastError(ERROR_SUCCESS);
8786
Result = NtUserScrollDC(hDC, 10, 20, &rcScroll, &rcClip, hRgn, (PVOID)(LONG_PTR)0x80001000);
88-
RTEST(Result == 0);
89-
RTEST(GetLastError() == ERROR_NOACCESS);
87+
ok_eq_int(Result, FALSE);
88+
ok_eq_ulong(GetLastError(), ERROR_NOACCESS);
9089

9190
Result = NtUserScrollDC(hDC, 10, 20, &rcScroll, &rcClip, hRgn, &rcUpdate);
9291

93-
RTEST(Result == TRUE);
94-
RTEST(rcUpdate.left == 0);
95-
RTEST(rcUpdate.top == 35);
96-
RTEST(rcUpdate.right == 70);
97-
RTEST(rcUpdate.bottom == 55);
92+
ok_eq_int(Result, TRUE);
93+
ok_eq_long(rcUpdate.left, 0);
94+
ok_eq_long(rcUpdate.top, 35);
95+
ok_eq_long(rcUpdate.right, 70);
96+
ok_eq_long(rcUpdate.bottom, 55);
9897

9998
hTmpRgn = CreateRectRgn(10,45,70,55);
10099
Result = CombineRgn(hRgn, hRgn, hTmpRgn, RGN_XOR);
101-
RTEST(Result == SIMPLEREGION);
100+
ok_eq_int(Result, SIMPLEREGION);
102101

103102
SetRectRgn(hTmpRgn,0,35,70,40);
104103
Result = CombineRgn(hRgn, hRgn, hTmpRgn, RGN_XOR);
105-
RTEST(Result == NULLREGION);
104+
ok_eq_int(Result, NULLREGION);
106105

107106
DeleteObject(hTmpRgn);
108107

0 commit comments

Comments
 (0)