[BOOT][HAL] Fix BCD conversion macros (reactos#8574)

- BCD_INT / INT_BCD: Evaluate macro parameter only once
- Remove the stdcall calling convention from PC-98 HAL private functions

Author: disean

boot/armllb/hw/omap3-zoom2/hwinfo.c

@@ -10,7 +10,13 @@
 
 TIMEINFO LlbTime;
 
-#define BCD_INT(bcd) (((bcd & 0xf0) >> 4) * 10 + (bcd &0x0f))
+static
+UCHAR
+BCD_INT(
+    _In_ UCHAR Bcd)
+{
+    return ((Bcd & 0xF0) >> 4) * 10 + (Bcd & 0x0F);
+}
 
 ULONG
 NTAPI

boot/freeldr/freeldr/arch/i386/pc/pcrtc.c

@@ -18,7 +18,13 @@
 
 #include <freeldr.h>
 
-#define BCD_INT(bcd) (((bcd & 0xf0) >> 4) * 10 + (bcd &0x0f))
+static
+UCHAR
+BCD_INT(
+    _In_ UCHAR Bcd)
+{
+    return ((Bcd & 0xF0) >> 4) * 10 + (Bcd & 0x0F);
+}
 
 TIMEINFO*
 PcGetTime(VOID)

boot/freeldr/freeldr/arch/i386/pc98/pc98rtc.c

@@ -7,7 +7,13 @@
 
 #include <freeldr.h>
 
-#define BCD_INT(bcd) (((bcd & 0xF0) >> 4) * 10 + (bcd & 0x0F))
+static
+UCHAR
+BCD_INT(
+    _In_ UCHAR Bcd)
+{
+    return ((Bcd & 0xF0) >> 4) * 10 + (Bcd & 0x0F);
+}
 
 TIMEINFO*
 Pc98GetTime(VOID)

boot/freeldr/freeldr/arch/i386/xbox/xboxrtc.c

@@ -21,7 +21,13 @@
 #define RTC_REGISTER_A   0x0A
 #define   RTC_REG_A_UIP  0x80  /* Update In Progress bit */
 
-#define BCD_INT(bcd) (((bcd & 0xf0) >> 4) * 10 + (bcd &0x0f))
+static
+UCHAR
+BCD_INT(
+    _In_ UCHAR Bcd)
+{
+    return ((Bcd & 0xF0) >> 4) * 10 + (Bcd & 0x0F);
+}
 
 static UCHAR
 HalpQueryCMOS(UCHAR Reg)

hal/halx86/include/halp.h

@@ -67,11 +67,21 @@ VOID
 #define HALP_LOW_STUB_SIZE_IN_PAGES 3
 #endif
 
-/* Conversion functions */
-#define BCD_INT(bcd)            \
-    (((bcd & 0xF0) >> 4) * 10 + (bcd & 0x0F))
-#define INT_BCD(int)            \
-    (UCHAR)(((int / 10) << 4) + (int % 10))
+FORCEINLINE
+UCHAR
+BCD_INT(
+    _In_ UCHAR Bcd)
+{
+    return ((Bcd & 0xF0) >> 4) * 10 + (Bcd & 0x0F);
+}
+
+FORCEINLINE
+UCHAR
+INT_BCD(
+    _In_ CSHORT Int)
+{
+    return ((Int / 10) << 4) + (Int % 10);
+}
 
 typedef
 BOOLEAN

hal/halx86/pc98/cmos.c

@@ -33,26 +33,17 @@ static ULONG_PTR MappedNvram;
 
 /* PRIVATE FUNCTIONS *********************************************************/
 
-/* Avoid double calls */
-#undef BCD_INT
-static UCHAR
-BCD_INT(
-    _In_ UCHAR Bcd)
-{
-    return ((Bcd & 0xF0) >> 4) * 10 + (Bcd & 0x0F);
-}
-
-static UCHAR
-NTAPI
+static
+UCHAR
 HalpReadNvram(
     _In_ UCHAR Register)
 {
     return READ_REGISTER_UCHAR((PUCHAR)(MappedNvram + Register));
 }
 
 _Requires_lock_held_(HalpSystemHardwareLock)
-static VOID
-NTAPI
+static
+VOID
 HalpWriteNvram(
     _In_ UCHAR Register,
     _In_ UCHAR Value)
@@ -63,8 +54,8 @@ HalpWriteNvram(
 }
 
 _Requires_lock_held_(HalpSystemHardwareLock)
-static UCHAR
-NTAPI
+static
+UCHAR
 HalpRtcReadByte(VOID)
 {
     UCHAR i;
@@ -86,8 +77,8 @@ HalpRtcReadByte(VOID)
 }
 
 _Requires_lock_held_(HalpSystemHardwareLock)
-static VOID
-NTAPI
+static
+VOID
 HalpRtcWriteBit(
     _In_ UCHAR Bit)
 {
@@ -101,8 +92,8 @@ HalpRtcWriteBit(
 }
 
 _Requires_lock_held_(HalpSystemHardwareLock)
-static VOID
-NTAPI
+static
+VOID
 HalpRtcWriteCommand(
     _In_ UCHAR Command)
 {