Skip to content

Commit 767def3

Browse files
authored
Merge pull request #178 from akx/flynt
Use f-strings for formatting
2 parents a9c3c69 + 7845596 commit 767def3

12 files changed

Lines changed: 44 additions & 54 deletions

examples/simple_2way.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@
1515

1616

1717
def print_fader_handler(unused_addr, args, value):
18-
print("[{0}] ~ {1:0.2f}".format(args[0], value))
18+
print(f"[{args[0]}] ~ {value:0.2f}")
1919

2020

2121
def print_xy_fader_handler(unused_addr, args, value1, value2):
22-
print("[{0}] ~ {1:0.2f} ~ {2:0.2f}".format(args[0], value2, value1))
22+
print(f"[{args[0]}] ~ {value2:0.2f} ~ {value1:0.2f}")
2323

2424

2525
if __name__ == "__main__":
@@ -54,7 +54,7 @@ def print_xy_fader_handler(unused_addr, args, value1, value2):
5454
def start_server(ip, port):
5555
print("Starting Server")
5656
server = osc_server.ThreadingOSCUDPServer((ip, port), dispatcher)
57-
print("Serving on {}".format(server.server_address))
57+
print(f"Serving on {server.server_address}")
5858
thread = threading.Thread(target=server.serve_forever)
5959
thread.start()
6060

examples/simple_echo_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,5 +26,5 @@ def echo_handler(client_addr, unused_addr, args):
2626
dispatcher.set_default_handler(echo_handler, True)
2727

2828
server = osc_server.ThreadingOSCUDPServer((args.ip, args.port), dispatcher)
29-
print("Serving on {}".format(server.server_address))
29+
print(f"Serving on {server.server_address}")
3030
server.serve_forever()

examples/simple_server.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212

1313

1414
def print_volume_handler(unused_addr, args, volume):
15-
print("[{0}] ~ {1}".format(args[0], volume))
15+
print(f"[{args[0]}] ~ {volume}")
1616

1717

1818
def print_compute_handler(unused_addr, args, volume):
1919
try:
20-
print("[{0}] ~ {1}".format(args[0], args[1](volume)))
20+
print(f"[{args[0]}] ~ {args[1](volume)}")
2121
except ValueError:
2222
pass
2323

@@ -34,5 +34,5 @@ def print_compute_handler(unused_addr, args, volume):
3434
dispatcher.map("/logvolume", print_compute_handler, "Log volume", math.log)
3535

3636
server = osc_server.ThreadingOSCUDPServer((args.ip, args.port), dispatcher)
37-
print("Serving on {}".format(server.server_address))
37+
print(f"Serving on {server.server_address}")
3838
server.serve_forever()

examples/simple_tcp_server.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212

1313

1414
def print_volume_handler(unused_addr, args, volume):
15-
print("[{0}] ~ {1}".format(args[0], volume))
15+
print(f"[{args[0]}] ~ {volume}")
1616

1717

1818
def print_compute_handler(unused_addr, args, volume):
1919
try:
20-
print("[{0}] ~ {1}".format(args[0], args[1](volume)))
20+
print(f"[{args[0]}] ~ {args[1](volume)}")
2121
except ValueError:
2222
pass
2323

@@ -42,5 +42,5 @@ def print_compute_handler(unused_addr, args, volume):
4242
server = osc_tcp_server.ThreadingOSCTCPServer(
4343
(args.ip, args.port), dispatcher, mode=args.mode
4444
)
45-
print("Serving on {}".format(server.server_address))
45+
print(f"Serving on {server.server_address}")
4646
server.serve_forever()

pythonosc/dispatcher.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,8 +175,7 @@ def unmap(self, address, handler, *args, needs_reply_address=False):
175175
except ValueError as e:
176176
if str(e) == "list.remove(x): x not in list":
177177
raise ValueError(
178-
"Address '%s' doesn't have handler '%s' mapped to it"
179-
% (address, handler)
178+
f"Address '{address}' doesn't have handler '{handler}' mapped to it"
180179
) from e
181180

182181
def handlers_for_address(
@@ -202,7 +201,7 @@ def handlers_for_address(
202201
pattern = pattern.replace("\\*", "[\\w|\\+]*")
203202
# The rest of the syntax in the specification is like the re module so
204203
# we're fine.
205-
pattern = pattern + "$"
204+
pattern = f"{pattern}$"
206205
patterncompiled = re.compile(pattern)
207206
matched = False
208207

pythonosc/osc_bundle.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def __init__(self, dgram: bytes) -> None:
3333
try:
3434
self._timestamp, index = osc_types.get_date(self._dgram, index)
3535
except osc_types.ParseError as pe:
36-
raise ParseError("Could not get the date from the datagram: %s" % pe)
36+
raise ParseError(f"Could not get the date from the datagram: {pe}")
3737
# Get the contents as a list of OscBundle and OscMessage.
3838
self._contents = self._parse_contents(index)
3939

@@ -61,10 +61,10 @@ def _parse_contents(
6161
contents.append(osc_message.OscMessage(content_dgram))
6262
else:
6363
logging.warning(
64-
"Could not identify content type of dgram %r" % content_dgram
64+
f"Could not identify content type of dgram {content_dgram!r}"
6565
)
6666
except (osc_types.ParseError, osc_message.ParseError, IndexError) as e:
67-
raise ParseError("Could not parse a content datagram: %s" % e)
67+
raise ParseError(f"Could not parse a content datagram: {e}")
6868

6969
return contents
7070

pythonosc/osc_bundle_builder.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,8 @@ def build(self) -> osc_bundle.OscBundle:
5353
dgram += content.dgram
5454
else:
5555
raise BuildError(
56-
"Content must be either OscBundle or OscMessage"
57-
"found {}".format(type(content))
56+
f"Content must be either OscBundle or OscMessage, found {type(content)}"
5857
)
5958
return osc_bundle.OscBundle(dgram)
6059
except osc_types.BuildError as be:
61-
raise BuildError("Could not build the bundle {}".format(be))
60+
raise BuildError(f"Could not build the bundle {be}")

pythonosc/osc_message.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,21 +73,17 @@ def _parse_datagram(self) -> None:
7373
elif param == "]": # Array stop.
7474
if len(param_stack) < 2:
7575
raise ParseError(
76-
"Unexpected closing bracket in type tag: {0}".format(
77-
type_tag
78-
)
76+
f"Unexpected closing bracket in type tag: {type_tag}"
7977
)
8078
param_stack.pop()
8179
# TODO: Support more exotic types as described in the specification.
8280
else:
83-
logging.warning("Unhandled parameter type: {0}".format(param))
81+
logging.warning(f"Unhandled parameter type: {param}")
8482
continue
8583
if param not in "[]":
8684
param_stack[-1].append(val)
8785
if len(param_stack) != 1:
88-
raise ParseError(
89-
"Missing closing bracket in type tag: {0}".format(type_tag)
90-
)
86+
raise ParseError(f"Missing closing bracket in type tag: {type_tag}")
9187
self._parameters = params
9288
except osc_types.ParseError as pe:
9389
raise ParseError("Found incorrect datagram, ignoring it", pe)

pythonosc/osc_message_builder.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,7 @@ def add_arg(self, arg_value: ArgValue, arg_type: Optional[str] = None) -> None:
9090
"""
9191
if arg_type and not self._valid_type(arg_type):
9292
raise ValueError(
93-
"arg_type must be one of {}, or an array of valid types".format(
94-
self._SUPPORTED_ARG_TYPES
95-
)
93+
f"arg_type must be one of {self._SUPPORTED_ARG_TYPES}, or an array of valid types"
9694
)
9795
if not arg_type:
9896
arg_type = self._get_arg_type(arg_value)
@@ -161,7 +159,7 @@ def build(self) -> osc_message.OscMessage:
161159

162160
# Write the parameters.
163161
arg_types = "".join([arg[0] for arg in self._args])
164-
dgram += osc_types.write_string("," + arg_types)
162+
dgram += osc_types.write_string(f",{arg_types}")
165163
for arg_type, value in self._args:
166164
if arg_type == self.ARG_TYPE_STRING:
167165
dgram += osc_types.write_string(value) # type: ignore[arg-type]
@@ -188,13 +186,11 @@ def build(self) -> osc_message.OscMessage:
188186
):
189187
continue
190188
else:
191-
raise BuildError(
192-
"Incorrect parameter type found {}".format(arg_type)
193-
)
189+
raise BuildError(f"Incorrect parameter type found {arg_type}")
194190

195191
return osc_message.OscMessage(dgram)
196192
except osc_types.BuildError as be:
197-
raise BuildError("Could not build the message: {}".format(be))
193+
raise BuildError(f"Could not build the message: {be}")
198194

199195

200196
def build_msg(address: str, value: ArgValue = "") -> osc_message.OscMessage:

pythonosc/osc_packet.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def __init__(self, dgram: bytes) -> None:
7676
"OscBundle."
7777
)
7878
except (osc_bundle.ParseError, osc_message.ParseError) as pe:
79-
raise ParseError("Could not parse packet %s" % pe)
79+
raise ParseError(f"Could not parse packet {pe}")
8080

8181
@property
8282
def messages(self) -> List[TimedMessage]:

0 commit comments

Comments
 (0)