Skip to content
This repository was archived by the owner on Jun 11, 2024. It is now read-only.

Commit 069f55d

Browse files
committed
Add :meth:atomx.models.ScheduledReport.save to update name and emails
1 parent e2300fd commit 069f55d

3 files changed

Lines changed: 27 additions & 9 deletions

File tree

CHANGES.txt

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,15 @@
55
- remove ``network`` scope in :meth:`atomx.Atomx.report` and add
66
``network_managed``, ``network_buy``, ``network_sell``
77
- Add new models:
8-
- :class:`atomx.models.AccountManager` (alias for `User`)
9-
- :class:`atomx.models.Banned` (alias for `Reason`)
10-
- :class:`atomx.models.PlacementType`
11-
- :class:`atomx.models.CampaignDebugReason`
12-
- :class:`atomx.models.Visibility`
8+
9+
* :class:`atomx.models.AccountManager` (alias for `User`)
10+
* :class:`atomx.models.Banned` (alias for `Reason`)
11+
* :class:`atomx.models.PlacementType`
12+
* :class:`atomx.models.CampaignDebugReason`
13+
* :class:`atomx.models.Visibility`
14+
15+
- Add :meth:`atomx.models.ScheduledReport.save` to edit ``name`` and ``emails``
16+
of a :class:`atomx.models.ScheduledReport`
1317

1418

1519
1.4

atomx/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,9 +236,9 @@ def report(self, scope=None, groups=None, metrics=None, where=None, from_=None,
236236
self.last_response = r_json
237237

238238
if is_scheduled_report:
239-
return models.ScheduledReport(self, query=r.json()['query'], **report)
239+
return models.ScheduledReport(self, **report)
240240

241-
return models.Report(self, query=r.json()['query'], **report)
241+
return models.Report(self, **report)
242242

243243
def report_status(self, report):
244244
"""Get the status for a `report`.

atomx/models.py

Lines changed: 16 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,9 +196,11 @@ class ScheduledReport(object):
196196
<https://wiki.atomx.com/reporting#scheduling_reports>`_.
197197
"""
198198

199-
def __init__(self, session, id, query, **kwargs):
199+
def __init__(self, session, id, name, emails, query, **kwargs):
200200
self.session = session
201201
self.id = id
202+
self.name = name
203+
self.emails = emails
202204
self.query = query
203205

204206
def __repr__(self):
@@ -207,9 +209,21 @@ def __repr__(self):
207209
def __eq__(self, other):
208210
return self.id == getattr(other, 'id', 'INVALID')
209211

212+
def save(self, session=None):
213+
"""Update report `name` and `emails`"""
214+
215+
session = session or self.session
216+
if not session:
217+
raise NoSessionError
218+
return session.put('report', self.id, {'name': self.name, 'emails': self.emails})
219+
210220
def delete(self, session=None):
211221
"""Delete scheduled report"""
212-
return self.session.delete('report', self.id)
222+
223+
session = session or self.session
224+
if not session:
225+
raise NoSessionError
226+
return session.delete('report', self.id)
213227

214228

215229
class Report(object):

0 commit comments

Comments
 (0)