Use traits for state and name

Author: mrm

Atomx/AtomxClient.php

@@ -3,10 +3,6 @@
 use Exception;
 use GuzzleHttp\Message\Response;
 
-/*
- * TODO: Ability to sync back from atomx to DA
- */
-
 class AtomxClient extends ApiClient {
     protected $apiBase = null;
     protected $id = null;

Atomx/Resources/Advertiser.php

@@ -1,9 +1,13 @@
 <?php namespace Atomx\Resources;
 
 use Atomx\AtomxClient;
+use Atomx\Resources\Traits\NameTrait;
+use Atomx\Resources\Traits\StateTrait;
 use InvalidArgumentException;
 
 class Advertiser extends AtomxClient {
+    use NameTrait, StateTrait;
+
     protected $endpoint = 'advertiser';
 
     public function setName($name)

Atomx/Resources/Campaign.php

@@ -1,9 +1,13 @@
 <?php namespace Atomx\Resources;
 
 use Atomx\AtomxClient;
+use Atomx\Resources\Traits\NameTrait;
+use Atomx\Resources\Traits\StateTrait;
 use InvalidArgumentException;
 
 class Campaign extends AtomxClient {
+    use NameTrait, StateTrait;
+
     protected $endpoint = 'campaign';
 
     public function setAdvertiserId($id)
@@ -64,4 +68,9 @@ public function setCreatives($activeCreatives, $inactiveCreatives)
         $this->creatives_active   = $activeCreatives;
         $this->creatives_inactive = $inactiveCreatives;
     }
+
+    public function setConversionPixels($pixels)
+    {
+        $this->conversion_pixels_active = $pixels;
+    }
 }

Atomx/Resources/Creative.php

@@ -1,23 +1,14 @@
 <?php namespace Atomx\Resources;
 
 use Atomx\AtomxClient;
+use Atomx\Resources\Traits\NameTrait;
+use Atomx\Resources\Traits\StateTrait;
 use InvalidArgumentException;
 
 class Creative extends AtomxClient {
-    protected $endpoint = 'creative';
-
-    public function setName($name)
-    {
-        $this->name = $name;
-    }
+    use NameTrait, StateTrait;
 
-    public function setState($state)
-    {
-        if (!in_array($state, ['active', 'inactive']))
-            throw new InvalidArgumentException('API: Invalid state provided');
-
-        $this->state = strtoupper($state);
-    }
+    protected $endpoint = 'creative';
 
     public function setBanner($filename, $extension)
     {

Atomx/Resources/Profile.php

@@ -1,15 +1,13 @@
 <?php namespace Atomx\Resources;
 
 use Atomx\AtomxClient;
+use Atomx\Resources\Traits\NameTrait;
 use InvalidArgumentException;
 
 class Profile extends AtomxClient {
-    protected $endpoint = 'profile';
+    use NameTrait;
 
-    public function setName($name)
-    {
-        $this->name = $name;
-    }
+    protected $endpoint = 'profile';
 
     // Targeting
     public function setCountryTargeting($action, $countries)

Atomx/Resources/Traits/NameTrait.php

@@ -0,0 +1,12 @@
+<?php namespace Atomx\Resources\Traits;
+
+/**
+ * Set the name of a resource
+ */
+trait NameTrait
+{
+    function setName($name)
+    {
+        $this->name = $name;
+    }
+}

Atomx/Resources/Traits/StateTrait.php

@@ -0,0 +1,15 @@
+<?php namespace Atomx\Resources\Traits;
+
+/**
+ * Set the state of a resource
+ */
+trait StateTrait
+{
+    public function setState($state)
+    {
+        if (!in_array($state, ['active', 'inactive']))
+            throw new InvalidArgumentException('API: Invalid state provided');
+
+        $this->state = strtoupper($state);
+    }
+}