Update shell.openExternal to promise due to electron update on atom

Author: sadick254

lib/controllers/issueish-list-controller.js

@@ -90,15 +90,9 @@ export class BareIssueishListController extends React.Component {
     return null;
   }
 
-  openOnGitHub = url => {
-    return new Promise((resolve, reject) => {
-      shell.openExternal(url, {}, err => {
-        if (err) { reject(err); } else {
-          resolve();
-          addEvent('open-issueish-in-browser', {package: 'github', component: this.constructor.name});
-        }
-      });
-    });
+  openOnGitHub = async url => {
+    await shell.openExternal(url);
+    addEvent('open-issueish-in-browser', {package: 'github', component: this.constructor.name});
   }
 
   showActionsMenu = /* istanbul ignore next */ issueish => {

lib/controllers/issueish-searches-controller.js

@@ -113,13 +113,8 @@ export default class IssueishSearchesController extends React.Component {
     });
   }
 
-  onOpenSearch = search => {
+  onOpenSearch = async search => {
     const searchURL = search.getWebURL(this.props.remote);
-
-    return new Promise((resolve, reject) => {
-      shell.openExternal(searchURL, {}, err => {
-        if (err) { reject(err); } else { resolve(); }
-      });
-    });
+    await shell.openExternal(searchURL);
   }
 }

lib/controllers/remote-controller.js

@@ -67,15 +67,7 @@ export default class RemoteController extends React.Component {
     createPrUrl += '/compare/' + encodeURIComponent(currentBranch.getName());
     createPrUrl += '?expand=1';
 
-    return new Promise((resolve, reject) => {
-      shell.openExternal(createPrUrl, {}, err => {
-        if (err) {
-          reject(err);
-        } else {
-          incrementCounter('create-pull-request');
-          resolve();
-        }
-      });
-    });
+    await shell.openExternal(createPrUrl);
+    incrementCounter('create-pull-request');
   }
 }

lib/views/actionable-review-view.js

@@ -124,28 +124,17 @@ export default class ActionableReviewView extends React.Component {
     }
   }
 
-  reportAbuse = (commentUrl, author) => {
-    return new Promise((resolve, reject) => {
-      const url = 'https://github.com/contact/report-content?report=' +
-        `${encodeURIComponent(author)}&content_url=${encodeURIComponent(commentUrl)}`;
-      shell.openExternal(url, {}, err => {
-        if (err) { reject(err); } else {
-          resolve();
-          addEvent('report-abuse', {package: 'github', component: this.constructor.name});
-        }
-      });
-    });
+  reportAbuse = async (commentUrl, author) => {
+    const url = 'https://github.com/contact/report-content?report=' +
+      `${encodeURIComponent(author)}&content_url=${encodeURIComponent(commentUrl)}`;
+
+    await shell.openExternal(url);
+    addEvent('report-abuse', {package: 'github', component: this.constructor.name});
   }
 
-  openOnGitHub = url => {
-    return new Promise((resolve, reject) => {
-      shell.openExternal(url, {}, err => {
-        if (err) { reject(err); } else {
-          resolve();
-          addEvent('open-comment-in-browser', {package: 'github', component: this.constructor.name});
-        }
-      });
-    });
+  openOnGitHub = async url => {
+    await shell.openExternal(url);
+    addEvent('open-comment-in-browser', {package: 'github', component: this.constructor.name});
   }
 
   showActionsMenu = (event, content, author) => {

lib/views/issueish-link.js

@@ -44,17 +44,9 @@ export function openIssueishLinkInNewTab(url, options = {}) {
   }
 }
 
-export function openLinkInBrowser(uri) {
-  return new Promise((resolve, reject) => {
-    shell.openExternal(uri, {}, err => {
-      if (err) {
-        reject(err);
-      } else {
-        addEvent('open-issueish-in-browser', {package: 'github', from: 'issueish-link'});
-        resolve();
-      }
-    });
-  });
+export async function openLinkInBrowser(uri) {
+  await shell.openExternal(uri);
+  addEvent('open-issueish-in-browser', {package: 'github', from: 'issueish-link'});
 }
 
 function getAtomUriForGithubUrl(githubUrl) {