Skip to content
This repository was archived by the owner on Aug 18, 2025. It is now read-only.

Commit 4335611

Browse files
authored
Merge branch 'master' into master
2 parents 5c9b77f + 925c4fe commit 4335611

26 files changed

Lines changed: 382 additions & 353 deletions

File tree

.size-snapshot.json

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
{
22
"dist/react-beautiful-dnd.js": {
3-
"bundled": 363505,
4-
"minified": 133056,
5-
"gzipped": 39410
3+
"bundled": 364318,
4+
"minified": 133393,
5+
"gzipped": 39449
66
},
77
"dist/react-beautiful-dnd.min.js": {
8-
"bundled": 306984,
9-
"minified": 108949,
10-
"gzipped": 31683
8+
"bundled": 307797,
9+
"minified": 109292,
10+
"gzipped": 31782
1111
},
1212
"dist/react-beautiful-dnd.esm.js": {
13-
"bundled": 239949,
14-
"minified": 124825,
15-
"gzipped": 32469,
13+
"bundled": 240708,
14+
"minified": 125264,
15+
"gzipped": 32618,
1616
"treeshaked": {
1717
"rollup": {
18-
"code": 21007,
18+
"code": 21121,
1919
"import_statements": 503
2020
},
2121
"webpack": {
22-
"code": 23898
22+
"code": 24005
2323
}
2424
}
2525
}

docs/api/drag-drop-context.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ type Props = {|
2222
// We do not technically need any children for this component
2323
children: Node | null,
2424
// Read out by screen readers when focusing on a drag handle
25-
liftInstruction?: string,
25+
dragHandleUsageInstructions?: string,
2626
// Used for strict content security policies
2727
nonce?: string,
2828
// Used for custom sensors
@@ -31,7 +31,7 @@ type Props = {|
3131
|};
3232
```
3333
34-
- `liftInstruction`: What is read out to screen reader users when a _drag handle_ is given browser focus. See our [screen reader guide](/docs/guides/screen-reader.md)
34+
- `dragHandleUsageInstructions`: What is read out to screen reader users when a _drag handle_ is given browser focus. See our [screen reader guide](/docs/guides/screen-reader.md)
3535
- `nonce`: Used for strict content security policy setups. See our [content security policy guide](/docs/guides/content-security-policy.md)
3636
- `sensors`: Used to pass in your own `sensor`s for a `<DragDropContext />`. See our [sensor api documentation](/docs/sensors/sensor-api.md)
3737
- `enableDefaultSensors`: Whether or not the default sensors ([mouse](/docs/sensors/mouse.md), [keyboard](/docs/sensors/keyboard.md), and [touch](/docs/sensors/touch.md)) are enabled. See our [sensor api documentation](/docs/sensors/sensor-api.md)
@@ -127,8 +127,4 @@ Responders are top level application events that you can use to perform your own
127127
128128
[Please see our Responders guide](/docs/guides/responders.md) for detailed information about responders ❤️
129129
130-
## `liftInstruction`
131-
132-
This is text used as the screen reader lift instruction for *drag-handle*s. We will use our default english message if no liftInstruction is provided. See our [screen reader guide](/docs/guides/screen-reader.md)
133-
134130
[← Back to documentation](/README.md#documentation-)

docs/guides/preset-styles.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Here are the styles that are applied at various points in the drag lifecycle:
88

99
### Always: drag handle
1010

11-
Styles applied to: **drag handle element** using the `data-react-beautiful-dnd-drag-handle` attribute.
11+
Styles applied to: **drag handle element** using the `data-rbd-drag-handle-context-id` attribute.
1212

1313
A long press on anchors usually pops a content menu that has options for the link such as 'Open in new tab'. Because long press is used to start a drag we need to opt out of this behavior
1414

@@ -30,7 +30,7 @@ touch-action: manipulation;
3030

3131
### Always: Droppable
3232

33-
Styles applied to: **droppable element** using the `data-react-beautiful-dnd-droppable` attribute.
33+
Styles applied to: **droppable element** using the `data-rbd-droppable-context-id` attribute.
3434

3535
Opting out of the browser feature which tries to maintain the scroll position when the DOM changes above the fold. We already correctly maintain the scroll position. The automatic `overflow-anchor` behavior leads to incorrect scroll positioning post drop.
3636

@@ -42,7 +42,7 @@ overflow-anchor: none;
4242

4343
### (Phase: resting): drag handle
4444

45-
Styles applied to: **drag handle element** using the `data-react-beautiful-dnd-drag-handle` attribute.
45+
Styles applied to: **drag handle element** using the `data-rbd-drag-handle-context-id` attribute.
4646

4747
Adding a cursor style to let the user know this element is draggable. You are welcome to override this.
4848

@@ -54,7 +54,7 @@ cursor: grab;
5454

5555
### (Phase: dragging): drag handle element
5656

57-
**Styles applied using the `data-react-beautiful-dnd-drag-handle` attribute**
57+
**Styles applied using the `data-rbd-drag-handle-context-id` attribute**
5858

5959
An optimisation to avoid processing `pointer-events` while dragging. Also used to allow scrolling through a drag handle with a track pad or mouse wheel.
6060

@@ -64,7 +64,7 @@ pointer-events: none;
6464

6565
### (Phase: dragging): Draggable element
6666

67-
**Styles applied using the `data-react-beautiful-dnd-draggable` attribute**
67+
**Styles applied using the `data-rbd-draggable-context-id` attribute**
6868

6969
This is what we use to control `<Draggable />`s that need to move out of the way of a dragging `<Draggable />`.
7070

@@ -74,7 +74,7 @@ transition: ${string};
7474

7575
### (Phase: dragging): Droppable element
7676

77-
**Styles applied using the `data-react-beautiful-dnd-droppable` attribute**
77+
**Styles applied using the `data-rbd-droppable-context-id` attribute**
7878

7979
We apply `pointer-events: none` to a `<Droppable />` during a drag. This is technically not required as an optimisation. However, it gets around a common issue where hover styles are triggered during a drag. You are welcome to opt out of this one as it is it not required for functinality.
8080

@@ -113,7 +113,7 @@ user-select: none;
113113

114114
### (Phase: dropping): drag handle element
115115

116-
**Styles applied using the `data-react-beautiful-dnd-drag-handle` attribute**
116+
**Styles applied using the `data-rbd-drag-handle-context-id` attribute**
117117

118118
We apply the grab cursor to all drag handles except the drag handle for the dropping `<Draggable />`. At this point the user is able to drag other `<Draggable />`'s if they like.
119119

0 commit comments

Comments
 (0)