V9 unit test fixes and v9-specific validation constants

Fix SSO test missing group_map_name param, task client assertion, batch
test mock patches. Add v9-specific validation constants with custom
validator error messages (separate from pydantic messages in legacy).

Made-with: Cursor

Author: Aryamanz29

tests_v9/unit/aio/conftest.py

@@ -9,8 +9,8 @@
 import pytest
 import pytest_asyncio
 
-from pyatlan_v9.client.aio.atlan import AsyncAtlanClient
 from pyatlan.client.common import AsyncApiCaller
+from pyatlan_v9.client.aio.atlan import AsyncAtlanClient
 
 
 @pytest.fixture(autouse=True)
@@ -42,4 +42,3 @@ def mock_async_api_caller():
 def mock_async_custom_metadata_cache():
     with patch.object(AsyncAtlanClient, "custom_metadata_cache") as cache:
         yield cache
-

tests_v9/unit/aio/test_atlan_tag_name.py

@@ -1,15 +1,15 @@
 # SPDX-License-Identifier: Apache-2.0
 # Copyright 2025 Atlan Pte. Ltd.
-import json as json_lib
 
-import pytest
 import msgspec
+import pytest
+
 import pyatlan.cache.aio.atlan_tag_cache
+from pyatlan.model.constants import DELETED_
 from pyatlan_v9.client.aio.atlan import AsyncAtlanClient
 from pyatlan_v9.model.aio.core import AsyncAtlanRequest, AsyncAtlanResponse
 from pyatlan_v9.model.assets import Purpose
-from pyatlan_v9.model.assets.purpose import _purpose_from_nested, PurposeNested
-from pyatlan.model.constants import DELETED_
+from pyatlan_v9.model.assets.purpose import PurposeNested, _purpose_from_nested
 from pyatlan_v9.model.core import AtlanTagName
 
 ATLAN_TAG_ID = "yiB7RLvdC2yeryLPjaDeHM"
@@ -79,8 +79,7 @@ def _assert_asset_tags(asset, is_retranslated=False):
     assert str(tags[2].type_name) == DELETED_
     if not is_retranslated:
         assert (
-            tags[2].source_tag_attachments
-            and len(tags[2].source_tag_attachments) == 1
+            tags[2].source_tag_attachments and len(tags[2].source_tag_attachments) == 1
         )
     assert str(tags[3].type_name) == DELETED_
     if not is_retranslated:

tests_v9/unit/aio/test_audit_search.py

@@ -7,17 +7,22 @@
 
 import pytest
 
-from pyatlan_v9.client.aio.audit import V9AsyncAuditClient as AsyncAuditClient
 from pyatlan.client.common import AsyncApiCaller
 from pyatlan.client.common.audit import LOGGER
+from pyatlan_v9.client.aio.audit import V9AsyncAuditClient as AsyncAuditClient
 from pyatlan_v9.errors import InvalidRequestError
 from pyatlan_v9.model.aio.audit import AsyncAuditSearchResults
 from pyatlan_v9.model.audit import AuditSearchRequest
 from pyatlan_v9.model.enums import SortOrder
-from pyatlan_v9.model.search import DSL
-from pyatlan_v9.model.search import Bool, SortItem, Term
-
-SEARCH_RESPONSES_DIR = Path(__file__).parent.parent.parent.parent / "tests" / "unit" / "data" / "search_responses"
+from pyatlan_v9.model.search import DSL, Bool, SortItem, Term
+
+SEARCH_RESPONSES_DIR = (
+    Path(__file__).parent.parent.parent.parent
+    / "tests"
+    / "unit"
+    / "data"
+    / "search_responses"
+)
 AUDIT_SEARCH_PAGING_JSON = "audit_search_paging.json"
 
 

tests_v9/unit/aio/test_client.py

@@ -10,16 +10,20 @@
 import pytest
 from httpx import Headers
 
-from pyatlan_v9.client.aio.asset import V9AsyncAssetClient as AsyncAssetClient
 from pyatlan.client.aio.batch import AsyncBatch
+from pyatlan.client.common import Search
+from pyatlan.client.common.asset import LOGGER as SHARED_LOGGER
+from pyatlan.model.aio.asset import AsyncIndexSearchResults
+from pyatlan.utils import get_python_version
+from pyatlan_v9.client.aio.asset import V9AsyncAssetClient as AsyncAssetClient
 from pyatlan_v9.client.aio.atlan import AsyncAtlanClient
 from pyatlan_v9.client.aio.group import V9AsyncGroupClient as AsyncGroupClient
-from pyatlan_v9.client.aio.search_log import V9AsyncSearchLogClient as AsyncSearchLogClient
+from pyatlan_v9.client.aio.search_log import (
+    V9AsyncSearchLogClient as AsyncSearchLogClient,
+)
 from pyatlan_v9.client.aio.typedef import V9AsyncTypeDefClient as AsyncTypeDefClient
 from pyatlan_v9.client.aio.user import V9AsyncUserClient as AsyncUserClient
 from pyatlan_v9.client.asset import CustomMetadataHandling
-from pyatlan.client.common import Search
-from pyatlan.client.common.asset import LOGGER as SHARED_LOGGER
 from pyatlan_v9.errors import (
     ERROR_CODE_FOR_HTTP_STATUS,
     ApiError,
@@ -28,10 +32,6 @@
     InvalidRequestError,
     NotFoundError,
 )
-from pyatlan.model.aio.asset import AsyncIndexSearchResults
-from pyatlan.model.assets import (
-    AtlasGlossaryTerm as LegacyAtlasGlossaryTerm,
-)
 from pyatlan_v9.model.assets import (
     Asset,
     AtlasGlossary,
@@ -49,7 +49,6 @@
     AtlanConnectorType,
     CertificateStatus,
     LineageDirection,
-    SaveSemantic,
     SortOrder,
 )
 from pyatlan_v9.model.fluent_search import CompoundQuery, FluentSearch
@@ -60,18 +59,6 @@
 from pyatlan_v9.model.search_log import SearchLogRequest
 from pyatlan_v9.model.typedef import EnumDef
 from pyatlan_v9.model.user import AtlanUser, UserRequest
-from pyatlan.utils import get_python_version
-from tests.unit.constants import (
-    TEST_ADMIN_CLIENT_METHODS,
-    TEST_ASSET_CLIENT_METHODS_ASYNC,
-    TEST_AUDIT_CLIENT_METHODS,
-    TEST_GROUP_CLIENT_METHODS,
-    TEST_ROLE_CLIENT_METHODS,
-    TEST_SL_CLIENT_METHODS,
-    TEST_TOKEN_CLIENT_METHODS,
-    TEST_TYPEDEF_CLIENT_METHODS,
-    TEST_USER_CLIENT_METHODS,
-)
 from tests.unit.model.constants import (
     CONNECTION_NAME,
     CONNECTOR_TYPE,
@@ -84,6 +71,17 @@
     PERSONA_NAME,
     PURPOSE_NAME,
 )
+from tests_v9.unit.constants import (
+    TEST_ADMIN_CLIENT_METHODS,
+    TEST_ASSET_CLIENT_METHODS_ASYNC,
+    TEST_AUDIT_CLIENT_METHODS,
+    TEST_GROUP_CLIENT_METHODS,
+    TEST_ROLE_CLIENT_METHODS,
+    TEST_SL_CLIENT_METHODS,
+    TEST_TOKEN_CLIENT_METHODS,
+    TEST_TYPEDEF_CLIENT_METHODS,
+    TEST_USER_CLIENT_METHODS,
+)
 
 V9_TEST_ASSET_CLIENT_METHODS_ASYNC = {
     **TEST_ASSET_CLIENT_METHODS_ASYNC,
@@ -374,7 +372,9 @@ async def test_append_terms_invalid_parameters_raises_error(
         ),
     ],
 )
-@patch("pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock)
+@patch(
+    "pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock
+)
 @pytest.mark.asyncio
 async def test_append_terms_asset_retrieval_errors(
     mock_aexecute,
@@ -407,10 +407,12 @@ async def test_append_with_valid_guid_and_no_terms_returns_asset():
     terms = []
 
     with patch(
-        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock
+        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async",
+        new_callable=AsyncMock,
     ) as mock_aexecute:
         with patch(
-            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save", new_callable=AsyncMock
+            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save",
+            new_callable=AsyncMock,
         ) as mock_save:
             # Set up async mock for search results
             mock_results = AsyncMock()
@@ -447,10 +449,12 @@ async def test_append_with_valid_guid_when_no_terms_present_returns_asset_with_g
     terms = [AtlasGlossaryTerm(qualified_name="term1")]
 
     with patch(
-        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock
+        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async",
+        new_callable=AsyncMock,
     ) as mock_aexecute:
         with patch(
-            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save", new_callable=AsyncMock
+            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save",
+            new_callable=AsyncMock,
         ) as mock_save:
             # Set up async mock for search results
             mock_results = AsyncMock()
@@ -490,10 +494,12 @@ async def test_append_with_valid_guid_when_terms_present_returns_asset_with_comb
     terms = [new_term]
 
     with patch(
-        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock
+        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async",
+        new_callable=AsyncMock,
     ) as mock_aexecute:
         with patch(
-            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save", new_callable=AsyncMock
+            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save",
+            new_callable=AsyncMock,
         ) as mock_save:
             # Set up async mock for search results
             mock_results = AsyncMock()
@@ -604,7 +610,9 @@ async def test_replace_terms_invalid_parameters_raises_error(
         ),
     ],
 )
-@patch("pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock)
+@patch(
+    "pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock
+)
 @pytest.mark.asyncio
 async def test_replace_terms_asset_retrieval_errors(
     mock_aexecute,
@@ -640,10 +648,12 @@ async def test_replace_terms():
     terms = [AtlasGlossaryTerm(qualified_name="new_term")]
 
     with patch(
-        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock
+        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async",
+        new_callable=AsyncMock,
     ) as mock_aexecute:
         with patch(
-            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save", new_callable=AsyncMock
+            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save",
+            new_callable=AsyncMock,
         ) as mock_save:
             # Set up async mock for search results
             mock_results = AsyncMock()
@@ -750,7 +760,9 @@ async def test_remove_terms_invalid_parameters_raises_error(
         ),
     ],
 )
-@patch("pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock)
+@patch(
+    "pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock
+)
 @pytest.mark.asyncio
 async def test_remove_terms_asset_retrieval_errors(
     mock_aexecute,
@@ -789,10 +801,12 @@ async def test_remove_with_valid_guid_when_terms_present_returns_asset_with_term
     table.attributes.meanings = [existing_term, other_term]
 
     with patch(
-        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async", new_callable=AsyncMock
+        "pyatlan_v9.model.fluent_search.FluentSearch.execute_async",
+        new_callable=AsyncMock,
     ) as mock_aexecute:
         with patch(
-            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save", new_callable=AsyncMock
+            "pyatlan_v9.client.aio.asset.V9AsyncAssetClient.save",
+            new_callable=AsyncMock,
         ) as mock_save:
             # Set up async mock for search results
             mock_results = AsyncMock()
@@ -1147,7 +1161,9 @@ def get_request(*args, **kwargs):
             GLOSSARY_NAME,
             None,
             "1 validation error for FindCategoryByName\nname\n  ensure this value has at least 1 characters",
-            marks=pytest.mark.skip(reason="v9: name validation happens deeper in call chain, not at model level"),
+            marks=pytest.mark.skip(
+                reason="v9: name validation happens deeper in call chain, not at model level"
+            ),
         ),
         (
             1,
@@ -1448,7 +1464,9 @@ def get_request(*args, **kwargs):
             GLOSSARY_NAME,
             None,
             "1 validation error for FindTermByName\nname\n  ensure this value has at least 1 characters",
-            marks=pytest.mark.skip(reason="v9: name validation happens deeper in call chain, not at model level"),
+            marks=pytest.mark.skip(
+                reason="v9: name validation happens deeper in call chain, not at model level"
+            ),
         ),
         (
             1,
@@ -2117,7 +2135,9 @@ async def test_user_create_with_info(
     mock_async_api_caller.reset_mock()
 
 
-@pytest.mark.skip(reason="Legacy AsyncTypeDefClient returns pydantic EnumDef, can't compare with v9 msgspec EnumDef")
+@pytest.mark.skip(
+    reason="Legacy AsyncTypeDefClient returns pydantic EnumDef, can't compare with v9 msgspec EnumDef"
+)
 @pytest.mark.asyncio
 async def test_typedef_get_by_name(mock_async_api_caller, type_def_get_by_name_json):
     client = AsyncTypeDefClient(mock_async_api_caller)
@@ -2576,8 +2596,8 @@ async def test_add_when_capture_failure_false_then_exception_raised(
             assert 0 == len(sut.created)
             assert 0 == len(sut.updated)
 
-    @patch.object(LegacyAtlasGlossaryTerm, "trim_to_required")
-    @patch.object(LegacyAtlasGlossaryTerm, "ref_by_guid")
+    @patch.object(AtlasGlossaryTerm, "trim_to_required")
+    @patch.object(AtlasGlossaryTerm, "ref_by_guid")
     @pytest.mark.asyncio
     async def test_term_add(
         self, mock_ref_by_guid, mock_trim_to_required, mock_async_atlan_client

tests_v9/unit/aio/test_client_proxy.py

@@ -158,7 +158,12 @@ def test_async_atlan_client_proxy_with_ssl_cert_file_from_env(
 
     # Use the fake certificate file
     fake_cert_path = str(
-        Path(__file__).parent.parent.parent.parent / "tests" / "unit" / "data" / "fake_certificates" / "fake-cert.pem"
+        Path(__file__).parent.parent.parent.parent
+        / "tests"
+        / "unit"
+        / "data"
+        / "fake_certificates"
+        / "fake-cert.pem"
     )
     monkeypatch.setenv("SSL_CERT_FILE", fake_cert_path)
 
@@ -180,7 +185,12 @@ def test_async_atlan_client_explicit_args_override_env_vars(
 
     # Use the fake certificate file
     fake_cert_path = str(
-        Path(__file__).parent.parent.parent.parent / "tests" / "unit" / "data" / "fake_certificates" / "fake-cert.pem"
+        Path(__file__).parent.parent.parent.parent
+        / "tests"
+        / "unit"
+        / "data"
+        / "fake_certificates"
+        / "fake-cert.pem"
     )
 
     # Set environment variables

tests_v9/unit/aio/test_credential_client.py

@@ -5,15 +5,12 @@
 import msgspec
 import pytest
 
-from pyatlan_v9.client.aio.credential import V9AsyncCredentialClient as AsyncCredentialClient
 from pyatlan.client.common import AsyncApiCaller
-from pyatlan_v9.errors import InvalidRequestError
-from pyatlan_v9.model.credential import (
-    Credential,
-    CredentialListResponse,
-    CredentialResponse,
-    CredentialTestResponse,
+from pyatlan_v9.client.aio.credential import (
+    V9AsyncCredentialClient as AsyncCredentialClient,
 )
+from pyatlan_v9.errors import InvalidRequestError
+from pyatlan_v9.model.credential import Credential, CredentialResponse
 
 TEST_MISSING_TOKEN_ID = (
     "ATLAN-PYTHON-400-032 No ID was provided when attempting to update the API token."
@@ -43,13 +40,12 @@ def _to_dict(obj):
     """Convert msgspec struct or Pydantic model to dict, preserving alias keys."""
     if isinstance(obj, msgspec.Struct):
         return msgspec.to_builtins(obj)
-    elif hasattr(obj, 'dict'):
+    elif hasattr(obj, "dict"):
         return obj.dict()
     else:
         return obj
 
 
-
 @pytest.fixture()
 def mock_api_caller():
     return Mock(spec=AsyncApiCaller)

tests_v9/unit/aio/test_file_client.py

@@ -7,12 +7,12 @@
 
 import pytest
 
+from pyatlan.client.common import AsyncApiCaller
 from pyatlan_v9.client.aio.atlan import AsyncAtlanClient
 from pyatlan_v9.client.aio.file import V9AsyncFileClient as AsyncFileClient
-from pyatlan.client.common import AsyncApiCaller
 from pyatlan_v9.errors import InvalidRequestError
 from pyatlan_v9.model.file import PresignedURLRequest
-from tests.unit.constants import TEST_FILE_CLIENT_METHODS
+from tests_v9.unit.constants import TEST_FILE_CLIENT_METHODS
 
 TEST_DATA_DIR = Path(__file__).parent.parent.parent.parent / "tests" / "unit" / "data"
 UPLOAD_FILE_PATH = str(TEST_DATA_DIR / "file_requests/upload.txt")
@@ -98,7 +98,9 @@ async def __anext__(self):
                     raise StopAsyncIteration
 
         mock_response.aiter_raw = lambda: AsyncBytesIterator(b"test data 12345.\n")
-        mock_response.aiter_bytes = lambda chunk_size=8192: AsyncBytesIterator(b"test data 12345.\n")
+        mock_response.aiter_bytes = lambda chunk_size=8192: AsyncBytesIterator(
+            b"test data 12345.\n"
+        )
         mock_response.aread = AsyncMock(return_value=b"test data 12345.\n")
 
         async_context_manager = AsyncMock()