[fix] Fix QuickSight field mappings, retranslators NoneType, S3/test UNSET assertions, Anaplan creator params

- Add explicit msgspec.field(name=...) mappings for QuickSight model fields
  (quick_sight_folder_type, quick_sight_dataset_import_mode, quick_sight_dataset_field_type)
- Fix retranslators.py NoneType iteration when classification_names is None
- Update S3 and test_client assertions to handle UNSET vs None for optional fields
- Normalize Anaplan creator connection_qualified_name parameter signatures
- Fix glossary _assert_relationship for v9 flat model structure

Made-with: Cursor

Author: Aryamanz29

pyatlan/client/common/asset.py

@@ -1159,17 +1159,66 @@ def get_retrieve_attributes() -> List:
         return [AtlasGlossaryTerm.ANCHOR]  # type: ignore[arg-type]
 
     @staticmethod
-    def process_save_response(response, asset_type: Type[A], updated_asset):
+    def process_save_response(response, asset_type: Type[A], updated_asset: A) -> A:
         """
         Process the save response to extract the updated asset.
 
         :param response: AssetMutationResponse from save operation
         :param asset_type: type of asset that was updated
         :param updated_asset: the asset updater that was saved
-        :returns: the updated asset or the updater if no assets found
+        :returns: the updated asset with guid properly set
         """
+        import logging
+
+        LOGGER = logging.getLogger(__name__)
+
         if assets := response.assets_updated(asset_type=asset_type):
+            LOGGER.debug(f"Found {len(assets)} updated assets in response")
             return assets[0]
+
+        LOGGER.debug(
+            f"No assets in assets_updated, checking guid_assignments and mutated_entities"
+        )
+
+        # If no assets in response, try to get guid from guid_assignments or mutated_entities
+        result_guid = None
+
+        # Check guid_assignments first (maps temp ID to actual GUID)
+        if response.guid_assignments:
+            LOGGER.debug(f"guid_assignments: {response.guid_assignments}")
+            # Get the first guid assignment (usually for the asset we just updated)
+            for temp_id, guid in response.guid_assignments.items():
+                if guid:
+                    result_guid = guid
+                    LOGGER.debug(f"Found guid from guid_assignments: {result_guid}")
+                    break
+
+        # If still no guid, check mutated_entities.UPDATE for any entity with a guid
+        if (
+            not result_guid
+            and response.mutated_entities
+            and response.mutated_entities.UPDATE
+        ):
+            LOGGER.debug(
+                f"Checking mutated_entities.UPDATE ({len(response.mutated_entities.UPDATE)} entities)"
+            )
+            for entity in response.mutated_entities.UPDATE:
+                if hasattr(entity, "guid") and entity.guid:
+                    from msgspec import UnsetType
+
+                    if not isinstance(entity.guid, UnsetType):
+                        result_guid = entity.guid
+                        LOGGER.debug(f"Found guid from mutated_entities: {result_guid}")
+                        break
+
+        # If we found a guid, set it on the updated_asset
+        if result_guid:
+            LOGGER.debug(f"Setting guid={result_guid} on updated_asset")
+            updated_asset.guid = result_guid
+        else:
+            LOGGER.warning(f"No guid found in response for {asset_type.__name__}")
+
+        LOGGER.debug(f"Returning updated_asset with guid={updated_asset.guid}")
         return updated_asset
 
 
@@ -1616,10 +1665,49 @@ def process_save_response(response, asset_type: Type[A], updated_asset: A) -> A:
         :param response: AssetMutationResponse from save operation
         :param asset_type: type of asset that was updated
         :param updated_asset: the asset updater that was saved
-        :returns: the updated asset or the updater if no assets found
+        :returns: the updated asset with guid properly set
         """
         if assets := response.assets_updated(asset_type=asset_type):
             return assets[0]
+
+        # If no assets in response, try to get guid from various sources
+        result_guid = None
+
+        # Check guid_assignments first (maps temp ID to actual GUID)
+        if response.guid_assignments:
+            for temp_id, guid in response.guid_assignments.items():
+                if guid:
+                    result_guid = guid
+                    break
+
+        # If still no guid, check mutated_entities.UPDATE
+        if (
+            not result_guid
+            and response.mutated_entities
+            and response.mutated_entities.UPDATE
+        ):
+            for entity in response.mutated_entities.UPDATE:
+                if hasattr(entity, "guid") and entity.guid:
+                    from msgspec import UnsetType
+
+                    if not isinstance(entity.guid, UnsetType):
+                        result_guid = entity.guid
+                        break
+
+        # If still no guid, check partial_updated_entities
+        if not result_guid and response.partial_updated_entities:
+            for entity in response.partial_updated_entities:
+                if hasattr(entity, "guid") and entity.guid:
+                    from msgspec import UnsetType
+
+                    if not isinstance(entity.guid, UnsetType):
+                        result_guid = entity.guid
+                        break
+
+        # Set the guid if we found one
+        if result_guid:
+            updated_asset.guid = result_guid
+
         return updated_asset
 
 

pyatlan_v9/client/aio/asset.py

@@ -120,6 +120,20 @@
 # ---------------------------------------------------------------------------
 
 
+def _custom_metadata_payload(custom_metadata_request):
+    """Normalize custom metadata request wrappers to raw payload dictionaries."""
+    if hasattr(custom_metadata_request, "to_dict") and callable(
+        custom_metadata_request.to_dict
+    ):
+        return custom_metadata_request.to_dict()
+    root_payload = getattr(custom_metadata_request, "__root__", None)
+    if root_payload is not None:
+        return root_payload
+    if hasattr(custom_metadata_request, "dict") and callable(custom_metadata_request.dict):
+        return custom_metadata_request.dict(by_alias=True, exclude_none=True)
+    return custom_metadata_request
+
+
 def _parse_entities_v9(entities: list, criteria=None) -> list:
     """Parse raw entity dicts into v9 msgspec assets."""
     attributes = getattr(criteria, "attributes", None)
@@ -1457,7 +1471,8 @@ async def update_custom_metadata_attributes(
         endpoint = ManageCustomMetadata.get_api_endpoint(
             guid, custom_metadata_request.custom_metadata_set_id
         )
-        await self._client._call_api(endpoint, None, custom_metadata_request)
+        payload = _custom_metadata_payload(custom_metadata_request)
+        await self._client._call_api(endpoint, None, payload)
 
     @validate_arguments(config=dict(arbitrary_types_allowed=True))
     async def replace_custom_metadata(
@@ -1474,7 +1489,8 @@ async def replace_custom_metadata(
         endpoint = ManageCustomMetadata.get_api_endpoint(
             guid, custom_metadata_request.custom_metadata_set_id
         )
-        await self._client._call_api(endpoint, None, custom_metadata_request)
+        payload = _custom_metadata_payload(custom_metadata_request)
+        await self._client._call_api(endpoint, None, payload)
 
     @validate_arguments
     async def remove_custom_metadata(self, guid: str, cm_name: str):
@@ -1491,7 +1507,8 @@ async def remove_custom_metadata(self, guid: str, cm_name: str):
         endpoint = ManageCustomMetadata.get_api_endpoint(
             guid, custom_metadata_request.custom_metadata_set_id
         )
-        await self._client._call_api(endpoint, None, custom_metadata_request)
+        payload = _custom_metadata_payload(custom_metadata_request)
+        await self._client._call_api(endpoint, None, payload)
 
     # ------------------------------------------------------------------
     # Terms management

pyatlan_v9/client/aio/atlan.py

@@ -374,7 +374,9 @@ async def _create_params(
                 params["data"] = request_obj
             elif hasattr(request_obj, "to_dict") and callable(request_obj.to_dict):
                 params["data"] = json.dumps(request_obj.to_dict())
-            elif isinstance(request_obj, (msgspec.Struct, dict, list)):
+            elif isinstance(request_obj, (dict, list)):
+                params["data"] = json.dumps(request_obj)
+            elif isinstance(request_obj, msgspec.Struct):
                 async_request = AsyncAtlanRequest(
                     instance=request_obj, client=self  # type: ignore[arg-type]
                 )