feat: enhance table level to accept rule_conditions

Author: UdaySagar-Git

pyatlan/generator/templates/methods/asset/data_quality_rule.jinja2

@@ -63,35 +63,64 @@
         client: AtlanClient,
         rule_type: DataQualityRuleTemplateType,
         asset: Asset,
-        threshold_compare_operator: DataQualityRuleThresholdCompareOperator,
         threshold_value: int,
         alert_priority: DataQualityRuleAlertPriority,
+        threshold_compare_operator: Optional[
+            DataQualityRuleThresholdCompareOperator
+        ] = None,
         threshold_unit: Optional[DataQualityRuleThresholdUnit] = None,
+        rule_conditions: Optional[str] = None,
+        row_scope_filtering_enabled: Optional[bool] = False,
     ) -> DataQualityRule:
         validate_required_fields(
             [
                 "client",
                 "rule_type",
                 "asset",
-                "threshold_compare_operator",
                 "threshold_value",
                 "alert_priority",
             ],
             [
                 client,
                 rule_type,
                 asset,
-                threshold_compare_operator,
                 threshold_value,
                 alert_priority,
             ],
         )
+        template_config = client.dq_template_config_cache.get_template_config(
+            rule_type.value
+        )
+
+        asset_for_validation, target_table_asset = (
+            DataQualityRule.Attributes._fetch_assets_for_row_scope_validation(
+                client, asset, rule_conditions, row_scope_filtering_enabled or False
+            )
+        )
+
+        validated_threshold_operator = (
+            DataQualityRule.Attributes._validate_template_features(
+                rule_type,
+                rule_conditions,
+                row_scope_filtering_enabled,
+                template_config,
+                threshold_compare_operator,
+                asset_for_validation,
+                target_table_asset,
+            )
+        )
+
+        final_threshold_compare_operator = (
+            validated_threshold_operator
+            or threshold_compare_operator
+            or DataQualityRuleThresholdCompareOperator.LESS_THAN_EQUAL
+        )
 
         attributes = DataQualityRule.Attributes.creator(
             client=client,
             rule_type=rule_type,
             asset=asset,
-            threshold_compare_operator=threshold_compare_operator,
+            threshold_compare_operator=final_threshold_compare_operator,
             threshold_value=threshold_value,
             alert_priority=alert_priority,
             rule_name=None,
@@ -100,6 +129,8 @@
             dimension=None,
             custom_sql=None,
             description=None,
+            rule_conditions=rule_conditions,
+            row_scope_filtering_enabled=row_scope_filtering_enabled,
         )
         return cls(attributes=attributes)
 

pyatlan/model/assets/core/data_quality_rule.py

@@ -111,35 +111,64 @@ def table_level_rule_creator(
         client: AtlanClient,
         rule_type: DataQualityRuleTemplateType,
         asset: Asset,
-        threshold_compare_operator: DataQualityRuleThresholdCompareOperator,
         threshold_value: int,
         alert_priority: DataQualityRuleAlertPriority,
+        threshold_compare_operator: Optional[
+            DataQualityRuleThresholdCompareOperator
+        ] = None,
         threshold_unit: Optional[DataQualityRuleThresholdUnit] = None,
+        rule_conditions: Optional[str] = None,
+        row_scope_filtering_enabled: Optional[bool] = False,
     ) -> DataQualityRule:
         validate_required_fields(
             [
                 "client",
                 "rule_type",
                 "asset",
-                "threshold_compare_operator",
                 "threshold_value",
                 "alert_priority",
             ],
             [
                 client,
                 rule_type,
                 asset,
-                threshold_compare_operator,
                 threshold_value,
                 alert_priority,
             ],
         )
+        template_config = client.dq_template_config_cache.get_template_config(
+            rule_type.value
+        )
+
+        asset_for_validation, target_table_asset = (
+            DataQualityRule.Attributes._fetch_assets_for_row_scope_validation(
+                client, asset, rule_conditions, row_scope_filtering_enabled or False
+            )
+        )
+
+        validated_threshold_operator = (
+            DataQualityRule.Attributes._validate_template_features(
+                rule_type,
+                rule_conditions,
+                row_scope_filtering_enabled,
+                template_config,
+                threshold_compare_operator,
+                asset_for_validation,
+                target_table_asset,
+            )
+        )
+
+        final_threshold_compare_operator = (
+            validated_threshold_operator
+            or threshold_compare_operator
+            or DataQualityRuleThresholdCompareOperator.LESS_THAN_EQUAL
+        )
 
         attributes = DataQualityRule.Attributes.creator(
             client=client,
             rule_type=rule_type,
             asset=asset,
-            threshold_compare_operator=threshold_compare_operator,
+            threshold_compare_operator=final_threshold_compare_operator,
             threshold_value=threshold_value,
             alert_priority=alert_priority,
             rule_name=None,
@@ -148,6 +177,8 @@ def table_level_rule_creator(
             dimension=None,
             custom_sql=None,
             description=None,
+            rule_conditions=rule_conditions,
+            row_scope_filtering_enabled=row_scope_filtering_enabled,
         )
         return cls(attributes=attributes)
 

tests/unit/model/data_quality_rule_test.py

@@ -180,14 +180,6 @@ def test_custom_sql_creator_with_missing_parameters_raise_value_error(
             DataQualityRuleAlertPriority.NORMAL,
             "asset is required",
         ),
-        (
-            DataQualityRuleTemplateType.ROW_COUNT,
-            Table.ref_by_qualified_name(qualified_name=DQ_TABLE_QUALIFIED_NAME),
-            None,
-            DQ_RULE_THRESHOLD_VALUE,
-            DataQualityRuleAlertPriority.NORMAL,
-            "threshold_compare_operator is required",
-        ),
         (
             DataQualityRuleTemplateType.ROW_COUNT,
             Table.ref_by_qualified_name(qualified_name=DQ_TABLE_QUALIFIED_NAME),