[fix] Fix certificate serialization, PopularityInsights deserialization, glossary UDR

- Change certificate_status/message defaults from None to UNSET in Asset
  so setting them to None is properly serialized (not omitted by omit_defaults)
- Simplify PopularityInsights.record_last_timestamp type to Union[int, None]
  to fix msgspec type union restriction while keeping __post_init__ conversion
- Construct PopularityInsights via kwargs (not post-init mutation) so
  datetime→epoch conversion runs during construction
- Add msgspec.convert in test_sql_assets verify_popularity to handle dict
  responses from API for source_read_recent_user_record_list
- Fix glossary _assert_relationship to check relationship_attributes dict

Made-with: Cursor

Author: Aryamanz29

pyatlan_v9/model/assets/asset.py

@@ -24,6 +24,7 @@
     merge_relationships,
 )
 from pyatlan_v9.model.serde import Serde, get_serde
+from pyatlan_v9.model.structs import PopularityInsights
 
 from .referenceable import (
     Referenceable,
@@ -82,10 +83,10 @@ class Asset(Referenceable):
     tenant_id: Union[str, None, UnsetType] = UNSET
     """Name of the Atlan workspace in which this asset exists."""
 
-    certificate_status: Union[str, None, UnsetType] = None
+    certificate_status: Union[str, None, UnsetType] = UNSET
     """Status of this asset's certification."""
 
-    certificate_status_message: Union[str, None, UnsetType] = None
+    certificate_status_message: Union[str, None, UnsetType] = UNSET
     """Human-readable descriptive message used to provide further detail to certificateStatus."""
 
     certificate_updated_by: Union[str, None, UnsetType] = UNSET
@@ -951,10 +952,10 @@ class AssetAttributes(ReferenceableAttributes):
     tenant_id: Union[str, None, UnsetType] = UNSET
     """Name of the Atlan workspace in which this asset exists."""
 
-    certificate_status: Union[str, None, UnsetType] = None
+    certificate_status: Union[str, None, UnsetType] = UNSET
     """Status of this asset's certification."""
 
-    certificate_status_message: Union[str, None, UnsetType] = None
+    certificate_status_message: Union[str, None, UnsetType] = UNSET
     """Human-readable descriptive message used to provide further detail to certificateStatus."""
 
     certificate_updated_by: Union[str, None, UnsetType] = UNSET

pyatlan_v9/model/structs.py

@@ -565,20 +565,16 @@ class PopularityInsights(msgspec.Struct, kw_only=True, rename="camel", frozen=Fa
     record_compute_cost: Union[float, None] = None
     record_max_compute_cost: Union[float, None] = None
     record_compute_cost_unit: Union[SourceCostUnitType, None] = None
-    record_last_timestamp: Union[int, date, datetime, None] = None
-    """Timestamp in epoch milliseconds, or date/datetime object that will be converted"""
+    record_last_timestamp: Union[int, None] = None
+    """Timestamp in epoch milliseconds."""
     record_warehouse: Union[str, None] = None
 
     def __post_init__(self):
         """Convert date/datetime to epoch milliseconds if needed."""
-        if isinstance(self.record_last_timestamp, (date, datetime)):
-            if isinstance(self.record_last_timestamp, date) and not isinstance(
-                self.record_last_timestamp, datetime
-            ):
-                dt = datetime.combine(self.record_last_timestamp, datetime.min.time())
-            else:
-                dt = self.record_last_timestamp
-            # Convert to epoch milliseconds
+        if isinstance(self.record_last_timestamp, datetime):
+            self.record_last_timestamp = int(self.record_last_timestamp.timestamp() * 1000)
+        elif isinstance(self.record_last_timestamp, date):
+            dt = datetime.combine(self.record_last_timestamp, datetime.min.time())
             self.record_last_timestamp = int(dt.timestamp() * 1000)
 
 

tests_v9/integration/glossary_test.py

@@ -1114,8 +1114,9 @@ def _assert_relationship(relationship, expected_type_name, udr):
     assert relationship
     assert relationship.guid
     assert relationship.type_name
-    if hasattr(relationship, "relationship_type"):
-        assert relationship.relationship_type == expected_type_name
+    ra = getattr(relationship, "relationship_attributes", None)
+    if ra and isinstance(ra, dict):
+        assert ra.get("typeName") == expected_type_name
     elif hasattr(relationship, "attributes") and relationship.attributes:
         assert relationship.attributes.relationship_attributes
         assert (

tests_v9/integration/test_sql_assets.py

@@ -3,6 +3,7 @@
 import time
 from typing import Callable, List, Optional, Type
 
+import msgspec
 import pytest
 
 from pyatlan_v9.client.atlan import AtlanClient
@@ -282,17 +283,16 @@ class TestTable:
 
     @pytest.fixture(scope="module")
     def popularity_insight(self):
-        popularity = PopularityInsights()
-        popularity.record_user = "ernest"
-        popularity.record_query_count = 1
-        popularity.record_compute_cost = 1.00
-        popularity.record_query_count = 2
-        popularity.record_total_user_count = 3
-        popularity.record_compute_cost_unit = SourceCostUnitType.BYTES
-        popularity.record_last_timestamp = datetime.date.today()
-        popularity.record_query_duration = 4
-        popularity.record_warehouse = "there"
-        return popularity
+        return PopularityInsights(
+            record_user="ernest",
+            record_query_count=2,
+            record_compute_cost=1.00,
+            record_total_user_count=3,
+            record_compute_cost_unit=SourceCostUnitType.BYTES,
+            record_last_timestamp=datetime.datetime.now(),
+            record_query_duration=4,
+            record_warehouse="there",
+        )
 
     def test_create(
         self,
@@ -443,30 +443,22 @@ def test_source_read_recent_user_record_list_readable_with_fluent_search(
             self.verify_popularity(asset_popularity, popularity_insight)
 
     def verify_popularity(self, asset_popularity, popularity_insight):
-        assert popularity_insight.record_user == asset_popularity.record_user
-        assert (
-            popularity_insight.record_query_count == asset_popularity.record_query_count
-        )
-        assert (
-            popularity_insight.record_compute_cost
-            == asset_popularity.record_compute_cost
-        )
-        assert (
-            popularity_insight.record_query_count == asset_popularity.record_query_count
-        )
-        assert (
-            popularity_insight.record_total_user_count
-            == asset_popularity.record_total_user_count
-        )
+        if isinstance(asset_popularity, dict):
+            ap = msgspec.convert(asset_popularity, PopularityInsights)
+        else:
+            ap = asset_popularity
+        assert popularity_insight.record_user == ap.record_user
+        assert popularity_insight.record_query_count == ap.record_query_count
+        assert popularity_insight.record_compute_cost == ap.record_compute_cost
+        assert popularity_insight.record_query_count == ap.record_query_count
         assert (
-            popularity_insight.record_compute_cost_unit
-            == asset_popularity.record_compute_cost_unit
+            popularity_insight.record_total_user_count == ap.record_total_user_count
         )
         assert (
-            popularity_insight.record_query_duration
-            == asset_popularity.record_query_duration
+            popularity_insight.record_compute_cost_unit == ap.record_compute_cost_unit
         )
-        assert popularity_insight.record_warehouse == asset_popularity.record_warehouse
+        assert popularity_insight.record_query_duration == ap.record_query_duration
+        assert popularity_insight.record_warehouse == ap.record_warehouse
 
 
 @pytest.mark.order(after="TestTable")