Skip to content

Commit 3953628

Browse files
committed
[test:fix] Fixed audit search assertions
1 parent 9f87526 commit 3953628

4 files changed

Lines changed: 24 additions & 24 deletions

File tree

pyatlan/test_utils/base_vcr.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,5 +267,9 @@ def vcr_cassette_dir(self, request):
267267
"""
268268
# Set self._CASSETTES_DIR or use the default directory path based on the test module name.
269269
# V9 tests (module name starting with tests_v9) use tests_v9/vcr_cassettes; legacy use tests/vcr_cassettes.
270-
root = "tests_v9/vcr_cassettes" if request.module.__name__.startswith("tests_v9") else "tests/vcr_cassettes"
270+
root = (
271+
"tests_v9/vcr_cassettes"
272+
if request.module.__name__.startswith("tests_v9")
273+
else "tests/vcr_cassettes"
274+
)
271275
return self._CASSETTES_DIR or os.path.join(root, request.module.__name__)

tests/unit/aio/test_audit_search.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,23 +47,21 @@ def load_json(filename):
4747
async def _assert_audit_search_results(
4848
results: AsyncAuditSearchResults, response_json, sorts, bulk=False
4949
):
50+
first = response_json["entityAudits"][0]
5051
async for audit in results:
51-
assert audit.entity_id == response_json["entityAudits"][0]["entity_id"]
52-
assert (
53-
audit.entity_qualified_name
54-
== response_json["entityAudits"][0]["entity_qualified_name"]
55-
)
56-
assert audit.type_name == response_json["entityAudits"][0]["type_name"]
52+
assert audit.entity_id == first["entityId"]
53+
assert audit.entity_qualified_name == first["entityQualifiedName"]
54+
assert audit.type_name == first["typeName"]
5755
expected_timestamp = datetime.fromtimestamp(
58-
response_json["entityAudits"][0]["timestamp"] / 1000, tz=timezone.utc
56+
first["timestamp"] / 1000, tz=timezone.utc
5957
)
6058
assert audit.timestamp == expected_timestamp
6159
expected_created = datetime.fromtimestamp(
62-
response_json["entityAudits"][0]["created"] / 1000, tz=timezone.utc
60+
first["created"] / 1000, tz=timezone.utc
6361
)
6462
assert audit.created == expected_created
65-
assert audit.user == response_json["entityAudits"][0]["user"]
66-
assert audit.action == response_json["entityAudits"][0]["action"]
63+
assert audit.user == first["user"]
64+
assert audit.action == first["action"]
6765

6866
assert results.total_count == response_json["totalCount"]
6967
assert results._bulk == bulk

tests/unit/data/search_responses/audit_search_paging.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
"totalCount": 1,
33
"entityAudits": [
44
{
5-
"entity_qualified_name": "sample_entity_1",
6-
"type_name": "AtlasGlossaryTerm",
7-
"entity_id": "guid_1",
5+
"entityQualifiedName": "sample_entity_1",
6+
"typeName": "AtlasGlossaryTerm",
7+
"entityId": "guid_1",
88
"timestamp": 1733491479782,
99
"created": 1733491480576,
1010
"user": "user1",

tests/unit/test_audit_search.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,23 +41,21 @@ def load_json(filename):
4141
def _assert_audit_search_results(
4242
results: AuditSearchResults, response_json, sorts, bulk=False
4343
):
44+
first = response_json["entityAudits"][0]
4445
for audit in results:
45-
assert audit.entity_id == response_json["entityAudits"][0]["entity_id"]
46-
assert (
47-
audit.entity_qualified_name
48-
== response_json["entityAudits"][0]["entity_qualified_name"]
49-
)
50-
assert audit.type_name == response_json["entityAudits"][0]["type_name"]
46+
assert audit.entity_id == first["entityId"]
47+
assert audit.entity_qualified_name == first["entityQualifiedName"]
48+
assert audit.type_name == first["typeName"]
5149
expected_timestamp = datetime.fromtimestamp(
52-
response_json["entityAudits"][0]["timestamp"] / 1000, tz=timezone.utc
50+
first["timestamp"] / 1000, tz=timezone.utc
5351
)
5452
assert audit.timestamp == expected_timestamp
5553
expected_created = datetime.fromtimestamp(
56-
response_json["entityAudits"][0]["created"] / 1000, tz=timezone.utc
54+
first["created"] / 1000, tz=timezone.utc
5755
)
5856
assert audit.created == expected_created
59-
assert audit.user == response_json["entityAudits"][0]["user"]
60-
assert audit.action == response_json["entityAudits"][0]["action"]
57+
assert audit.user == first["user"]
58+
assert audit.action == first["action"]
6159

6260
assert results.total_count == response_json["totalCount"]
6361
assert results._bulk == bulk

0 commit comments

Comments
 (0)