Skip to content

Commit 1262dfa

Browse files
committed
[fix/unit] Legacy audit search tests use camelCase keys from fixture
tests/unit and tests/unit/aio assert on audit_search_paging.json which was updated to camelCase (entityQualifiedName, typeName, entityId); update _assert_audit_search_results to read first['entityId'] etc. Made-with: Cursor
1 parent 7817d35 commit 1262dfa

2 files changed

Lines changed: 16 additions & 20 deletions

File tree

tests/unit/aio/test_audit_search.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -47,23 +47,21 @@ def load_json(filename):
4747
async def _assert_audit_search_results(
4848
results: AsyncAuditSearchResults, response_json, sorts, bulk=False
4949
):
50+
first = response_json["entityAudits"][0]
5051
async for audit in results:
51-
assert audit.entity_id == response_json["entityAudits"][0]["entity_id"]
52-
assert (
53-
audit.entity_qualified_name
54-
== response_json["entityAudits"][0]["entity_qualified_name"]
55-
)
56-
assert audit.type_name == response_json["entityAudits"][0]["type_name"]
52+
assert audit.entity_id == first["entityId"]
53+
assert audit.entity_qualified_name == first["entityQualifiedName"]
54+
assert audit.type_name == first["typeName"]
5755
expected_timestamp = datetime.fromtimestamp(
58-
response_json["entityAudits"][0]["timestamp"] / 1000, tz=timezone.utc
56+
first["timestamp"] / 1000, tz=timezone.utc
5957
)
6058
assert audit.timestamp == expected_timestamp
6159
expected_created = datetime.fromtimestamp(
62-
response_json["entityAudits"][0]["created"] / 1000, tz=timezone.utc
60+
first["created"] / 1000, tz=timezone.utc
6361
)
6462
assert audit.created == expected_created
65-
assert audit.user == response_json["entityAudits"][0]["user"]
66-
assert audit.action == response_json["entityAudits"][0]["action"]
63+
assert audit.user == first["user"]
64+
assert audit.action == first["action"]
6765

6866
assert results.total_count == response_json["totalCount"]
6967
assert results._bulk == bulk

tests/unit/test_audit_search.py

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -41,23 +41,21 @@ def load_json(filename):
4141
def _assert_audit_search_results(
4242
results: AuditSearchResults, response_json, sorts, bulk=False
4343
):
44+
first = response_json["entityAudits"][0]
4445
for audit in results:
45-
assert audit.entity_id == response_json["entityAudits"][0]["entity_id"]
46-
assert (
47-
audit.entity_qualified_name
48-
== response_json["entityAudits"][0]["entity_qualified_name"]
49-
)
50-
assert audit.type_name == response_json["entityAudits"][0]["type_name"]
46+
assert audit.entity_id == first["entityId"]
47+
assert audit.entity_qualified_name == first["entityQualifiedName"]
48+
assert audit.type_name == first["typeName"]
5149
expected_timestamp = datetime.fromtimestamp(
52-
response_json["entityAudits"][0]["timestamp"] / 1000, tz=timezone.utc
50+
first["timestamp"] / 1000, tz=timezone.utc
5351
)
5452
assert audit.timestamp == expected_timestamp
5553
expected_created = datetime.fromtimestamp(
56-
response_json["entityAudits"][0]["created"] / 1000, tz=timezone.utc
54+
first["created"] / 1000, tz=timezone.utc
5755
)
5856
assert audit.created == expected_created
59-
assert audit.user == response_json["entityAudits"][0]["user"]
60-
assert audit.action == response_json["entityAudits"][0]["action"]
57+
assert audit.user == first["user"]
58+
assert audit.action == first["action"]
6159

6260
assert results.total_count == response_json["totalCount"]
6361
assert results._bulk == bulk

0 commit comments

Comments
 (0)