[change] AtlanTag.of(): update to use client instance used for translating source-specific details

Author: Aryamanz29

pyatlan/model/core.py

@@ -22,6 +22,7 @@
 
 from pydantic.v1.generics import GenericModel
 
+from pyatlan.errors import ErrorCode
 from pyatlan.model.constants import DELETED_, DELETED_SENTINEL
 from pyatlan.model.enums import AnnouncementType, EntityStatus, SaveSemantic
 from pyatlan.model.retranslators import AtlanTagRetranslator
@@ -51,11 +52,11 @@ def __init__(self, display_text: str):
         # ):
         #     raise ValueError(f"{display_text} is not a valid Classification")
         self._display_text = display_text
-        self._id = id
+        # self._id = id
 
-    @property
-    def id(self):
-        return self._id
+    # @property
+    # def id(self):
+    #     return self._id
 
     @classmethod
     def get_deleted_sentinel(cls) -> "AtlanTagName":
@@ -319,17 +320,12 @@ class Config:
     )
 
     attributes: Optional[Dict[str, Any]] = None
+    tag_id: Optional[str] = Field(default=True, exclude=True)
 
     # @property
     # def source_tag_attachements(self) -> List[SourceTagAttachment]:
     #     return self._source_tag_attachements
 
-    # @validator("type_name", pre=True)
-    # def type_name_is_tag_name(cls, value):
-    #     if isinstance(value, AtlanTagName):
-    #         return value
-    #     return AtlanTagName._convert_to_display_text(value)
-
     # def __init__(self, *args, **kwargs):
     #     from pyatlan.client.atlan import AtlanClient
 
@@ -351,27 +347,28 @@ def of(
         atlan_tag_name: AtlanTagName,
         entity_guid: Optional[str] = None,
         source_tag_attachment: Optional[SourceTagAttachment] = None,
+        client: Optional[AtlanClient] = None,
     ) -> AtlanTag:
-        from pyatlan.client.atlan import AtlanClient
-
         """
         Construct an Atlan tag assignment for a specific entity.
 
         :param atlan_tag_name: human-readable name of the Atlan tag
         :param entity_guid: unique identifier (GUID) of the entity to which the Atlan tag is to be assigned
         :param source_tag_attachment: (optional) source-specific details for the tag
+        :param client: (optional) client instance used for translating source-specific details
         :return: an Atlan tag assignment with default settings for propagation and a specific entity assignment
+        :raises InvalidRequestError: if client is not provided and source_tag_attachment is specified
         """
         tag = AtlanTag(type_name=atlan_tag_name)
         if entity_guid:
             tag.entity_guid = entity_guid
             tag.entity_status = EntityStatus.ACTIVE
         if source_tag_attachment:
+            if not client:
+                raise ErrorCode.NO_ATLAN_CLIENT.exception_with_parameters()
+            tag_id = client.atlan_tag_cache.get_id_for_name(str(atlan_tag_name))
             source_tag_attr_id = (
-                AtlanClient.get_current_client().atlan_tag_cache.get_source_tags_attr_id(
-                    atlan_tag_name.id
-                )
-                or ""
+                client.atlan_tag_cache.get_source_tags_attr_id(tag_id) or ""
             )
             tag.attributes = {source_tag_attr_id: [source_tag_attachment]}
             tag.source_tag_attachements.append(source_tag_attachment)

pyatlan/model/translators.py

@@ -47,6 +47,7 @@ def translate(self, data: Dict[str, Any]) -> Dict[str, Any]:
                     if not tag_name:
                         return
                     classification[self._TYPE_NAME] = tag_name
+                    classification["tag_id"] = tag_id
                     # Check if the tag is a source tag (in that case tag has "attributes")
                     attr_id = self.client.atlan_tag_cache.get_source_tags_attr_id(
                         tag_id

tests/integration/test_index_search.py

@@ -229,6 +229,7 @@ def test_source_tag_assign_with_value(client: AtlanClient, table: Table):
                     SourceTagAttachmentValue(tag_attachment_value="Not Restricted")
                 ],
             ),
+            client=client,
         ),
     ]
     response = client.asset.save(to_update, replace_atlan_tags=True)