[tests/fix] Fixed failing integration tests due to refactoring changes

Author: Aryamanz29

pyatlan/client/open_lineage.py

@@ -63,6 +63,7 @@ def create_connection(
         }
         response = self._client.credentials.creator(credential=create_credential)  # type: ignore[attr-defined]
         connection = Connection.creator(
+            client=self._client,
             name=name,
             connector_type=connector_type,
             admin_users=admin_users,

pyatlan/client/typedef.py

@@ -233,7 +233,7 @@ def purge(self, name: str, typedef_type: type) -> None:
                 typedef_type
             )
         if internal_name:
-            self._client._client._call_api(  # type: ignore[attr-defined]
+            self._client._call_api(  # type: ignore[attr-defined]
                 DELETE_TYPE_DEF_BY_NAME.format_path_with_params(internal_name)
             )
         else:

pyatlan/model/search.py

@@ -1968,6 +1968,17 @@ def validate_sort(cls, sort, values):
         return sort
 
 
+class IndexSearchRequestMetadata(AtlanObject):
+    save_search_log: bool = Field(
+        default=False,
+        description="Whether to log this search (True) or not (False)",
+    )
+    utm_tags: List[str] = Field(
+        default_factory=list,
+        description="Tags to associate with the search request",
+    )
+
+
 class IndexSearchRequest(SearchRequest):
     dsl: DSL
     relation_attributes: Optional[List[str]] = Field(
@@ -2013,26 +2024,13 @@ class IndexSearchRequest(SearchRequest):
         default=None,
         description="Qualified name of the purpose eg: default/zL6uqsrZGuf1hz9XFYnw9x",
     )
-
-    class Metadata(AtlanObject):
-        # Set this to `False` to prevent the frequent
-        # Out of memory (OOM) issue in Metastore pods.
-        save_search_log: bool = Field(
-            default=False,
-            description="Whether to log this search (True) or not (False)",
-        )
-        utm_tags: List[str] = Field(
-            default_factory=list,
-            description="Tags to associate with the search request",
-        )
-
-    request_metadata: Optional[Metadata] = Field(
-        default_factory=lambda: IndexSearchRequest.Metadata(
+    request_metadata: Optional[IndexSearchRequestMetadata] = Field(
+        default_factory=lambda: IndexSearchRequestMetadata(
             # Set this to `False` to prevent the frequent
             # Out of memory (OOM) issue in Metastore pods.
             save_search_log=False,
             utm_tags=[UTMTags.PROJECT_SDK_PYTHON],
-        ),
+        )
     )
 
     class Config:

tests/integration/connection_test.py

@@ -56,7 +56,9 @@ def test_invalid_connection(client: AtlanClient):
     with pytest.raises(
         ValueError, match="One of admin_user, admin_groups or admin_roles is required"
     ):
-        Connection.create(name=MODULE_NAME, connector_type=AtlanConnectorType.POSTGRES)
+        Connection.create(
+            client=client, name=MODULE_NAME, connector_type=AtlanConnectorType.POSTGRES
+        )
 
 
 def test_invalid_connection_admin_role(
@@ -66,6 +68,7 @@ def test_invalid_connection_admin_role(
         ValueError, match="Provided role ID abc123 was not found in Atlan."
     ):
         Connection.create(
+            client=client,
             name=MODULE_NAME,
             connector_type=AtlanConnectorType.SAPHANA,
             admin_roles=["abc123"],
@@ -79,6 +82,7 @@ def test_invalid_connection_admin_group(
         ValueError, match="Provided group name abc123 was not found in Atlan."
     ):
         Connection.create(
+            client=client,
             name=MODULE_NAME,
             connector_type=AtlanConnectorType.SAPHANA,
             admin_groups=["abc123"],
@@ -92,6 +96,7 @@ def test_invalid_connection_admin_user(
         ValueError, match="Provided username abc123 was not found in Atlan."
     ):
         Connection.create(
+            client=client,
             name=MODULE_NAME,
             connector_type=AtlanConnectorType.SAPHANA,
             admin_users=["abc123"],

tests/integration/document_db_asset_test.py

@@ -30,6 +30,7 @@ def test_creator(
         assert role
         connection_name = TestId.make_unique("DOC_Conn")
         c = Connection.creator(
+            client=client,
             name=connection_name,
             connector_type=AtlanConnectorType.DOCUMENTDB,
             admin_roles=[role],

tests/integration/test_client.py

@@ -37,7 +37,14 @@
     UTMTags,
 )
 from pyatlan.model.fluent_search import CompoundQuery, FluentSearch
-from pyatlan.model.search import DSL, Bool, IndexSearchRequest, SortItem, Term
+from pyatlan.model.search import (
+    DSL,
+    Bool,
+    IndexSearchRequest,
+    IndexSearchRequestMetadata,
+    SortItem,
+    Term,
+)
 from pyatlan.model.user import UserMinimalResponse
 from tests.integration.client import TestId
 from tests.integration.lineage_test import create_database, delete_asset
@@ -1227,7 +1234,7 @@ def _view_test_glossary_by_search(
     index = (
         FluentSearch().where(Asset.GUID.eq(sl_glossary.guid, case_insensitive=True))
     ).to_request()
-    index.request_metadata = IndexSearchRequest.Metadata(
+    index.request_metadata = IndexSearchRequestMetadata(
         utm_tags=[
             UTMTags.ACTION_ASSET_VIEWED,
             UTMTags.UI_PROFILE,

tests/integration/test_sql_assets.py

@@ -79,6 +79,7 @@ def test_create(
         assert role
         connection_name = TestId.make_unique("INT")
         c = Connection.create(
+            client=client,
             name=connection_name,
             connector_type=AtlanConnectorType.SNOWFLAKE,
             admin_roles=[role],