Skip to content

Commit e9960f8

Browse files
committed
chore: remove redundant compileJava genCustomPkg dependency and clarify CI comment
The compileJava task dependency on genCustomPkg is already covered by sourcesJar; removing the duplicate from asset-import and RAB builds. Also tightens the comment in custom-package-container.yml to accurately describe the branch-tag logic (manual run, not all non-main branches). Signed-off-by: Chris (He/Him) <cgrote@gmail.com>
1 parent 6d0bfad commit e9960f8

3 files changed

Lines changed: 1 addition & 7 deletions

File tree

.github/workflows/custom-package-container.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949
id: tags
5050
run: |
5151
if [ -n "${{ inputs.branch }}" ]; then
52-
# For non-main branches, use version and branch name (sanitized)
52+
# For manual runs with branch specified, use version and branch name (sanitized)
5353
BRANCH_NAME=$(echo "${{ inputs.branch }}" | sed 's/[^a-zA-Z0-9._-]/-/g')
5454
echo "tags=ghcr.io/atlanhq/csa-${{inputs.package_name}}:${{inputs.version}}-${BRANCH_NAME}" >> $GITHUB_OUTPUT
5555
echo "build_version=${{inputs.version}}-${BRANCH_NAME}" >> $GITHUB_OUTPUT

samples/packages/asset-import/build.gradle.kts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ tasks {
2020
getByName("sourcesJar") {
2121
dependsOn("genCustomPkg")
2222
}
23-
compileJava {
24-
dependsOn("genCustomPkg")
25-
}
2623
}
2724

2825
publishing {

samples/packages/relational-assets-builder/build.gradle.kts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,6 @@ java {
2020
}
2121

2222
tasks {
23-
compileJava {
24-
dependsOn("genCustomPkg")
25-
}
2623
shadowJar {
2724
isZip64 = true
2825
archiveClassifier.set("")

0 commit comments

Comments
 (0)