chore: add more linting checks and fix them

Author: levivannoort

.github/workflows/ci.yml

@@ -33,9 +33,9 @@ jobs:
           cache: true
 
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v6
-        with:
-          version: latest
+        run: |
+          go install github.com/golangci/golangci-lint/cmd/golangci-lint@latest
+          golangci-lint run
 
       - name: Check formatting
         run: |

.golangci.yml

@@ -1,15 +1,86 @@
 linters:
   enable:
+    # Default linters
     - errcheck
     - gosimple
     - govet
     - ineffassign
     - staticcheck
     - unused
 
+    # Code style
+    - gofmt
+    - goimports
+    - misspell
+    - unconvert
+    - whitespace
+
+    # Bug detection
+    - bodyclose
+    - durationcheck
+    - nilerr
+    - noctx
+    - rowserrcheck
+    - sqlclosecheck
+    - wastedassign
+
+    # Code complexity & maintenance
+    - copyloopvar
+    - dupword
+    - errname
+    - errorlint
+    - fatcontext
+    - goconst
+    - goprintffuncname
+    - makezero
+    - nosprintfhostport
+    - prealloc
+    - predeclared
+    - reassign
+    - revive
+    - usetesting
+    - tparallel
+    - usestdlibvars
+
+linters-settings:
+  errcheck:
+    check-type-assertions: true
+  goconst:
+    min-len: 3
+    min-occurrences: 3
+  misspell:
+    locale: US
+  revive:
+    rules:
+      - name: blank-imports
+      - name: context-as-argument
+      - name: context-keys-type
+      - name: dot-imports
+      - name: error-return
+      - name: error-strings
+      - name: error-naming
+      - name: exported
+        disabled: true
+      - name: increment-decrement
+      - name: var-naming
+      - name: range
+      - name: receiver-naming
+      - name: time-naming
+      - name: unexported-return
+      - name: indent-error-flow
+      - name: errorf
+      - name: empty-block
+      - name: superfluous-else
+      - name: unused-parameter
+        disabled: true
+      - name: unreachable-code
+      - name: redefines-builtin-id
+
 issues:
   exclude-dirs:
     - vendor
+  max-issues-per-linter: 0
+  max-same-issues: 0
 
 run:
   timeout: 5m

internal/common/helpers.go

@@ -3,6 +3,7 @@ package common
 import (
 	"context"
 	"encoding/json"
+	"errors"
 	"fmt"
 	"strings"
 	"time"
@@ -36,8 +37,8 @@ func WithUserAgent(version string) client.ClientOption {
 
 // ClientForProject creates a new SDK client targeting a specific project.
 func (ac *AppwriteClients) ClientForProject(projectID string) client.Client {
-	opts := make([]client.ClientOption, len(ac.BaseOptions))
-	copy(opts, ac.BaseOptions)
+	opts := make([]client.ClientOption, 0, len(ac.BaseOptions)+1)
+	opts = append(opts, ac.BaseOptions...)
 	opts = append(opts, appwrite.WithProject(projectID))
 	return appwrite.NewClient(opts...)
 }
@@ -66,23 +67,26 @@ func ProjectIDAttribute() schema.StringAttribute {
 
 // IsNotFoundError checks if an Appwrite SDK error is a 404.
 func IsNotFoundError(err error) bool {
-	if appErr, ok := err.(*client.AppwriteError); ok {
+	var appErr *client.AppwriteError
+	if errors.As(err, &appErr) {
 		return appErr.GetStatusCode() == 404
 	}
 	return false
 }
 
 // IsColumnNotAvailableError checks if the error is due to a column still being processed.
 func IsColumnNotAvailableError(err error) bool {
-	if appErr, ok := err.(*client.AppwriteError); ok {
+	var appErr *client.AppwriteError
+	if errors.As(err, &appErr) {
 		return appErr.GetStatusCode() == 400 && strings.Contains(appErr.GetMessage(), "not yet available")
 	}
 	return false
 }
 
 // FormatError returns a detailed error string including status code and response body.
 func FormatError(err error) string {
-	if appErr, ok := err.(*client.AppwriteError); ok {
+	var appErr *client.AppwriteError
+	if errors.As(err, &appErr) {
 		return fmt.Sprintf("%s (status: %d, response: %s)", appErr.GetMessage(), appErr.GetStatusCode(), appErr.GetResponse())
 	}
 	return err.Error()
@@ -104,8 +108,12 @@ func GetColumnRaw(c client.Client, databaseID, tableID, key string) (map[string]
 	if !strings.HasPrefix(resp.Type, "application/json") {
 		return nil, fmt.Errorf("unexpected response type: %s", resp.Type)
 	}
+	resultStr, ok := resp.Result.(string)
+	if !ok {
+		return nil, fmt.Errorf("unexpected response result type: %T", resp.Result)
+	}
 	var result map[string]interface{}
-	if err := json.Unmarshal([]byte(resp.Result.(string)), &result); err != nil {
+	if err := json.Unmarshal([]byte(resultStr), &result); err != nil {
 		return nil, fmt.Errorf("failed to unmarshal column response: %w", err)
 	}
 	return result, nil