- r clean up unused bool

Co-Authored-By: jmasonlee <262853+jmasonlee@users.noreply.github.com>
Co-Authored-By: Gregor Riegler <rieglerg85@gmail.com>
Co-Authored-By: blade290 <43077216+blade290@users.noreply.github.com>
Co-Authored-By: Nitsan Avni <nitsanav@gmail.com>
Co-Authored-By: bhargavgundu <7643639+bhargavgundu@users.noreply.github.com>

Author: 6 people

approvaltests/inline/inline_options.py

@@ -27,9 +27,8 @@ def semi_automatic():
         class SemiAutomaticInlineOptions(InlineOptions):
             def apply(self, options: "Options") -> "Options":
                 return options.with_reporter(
-                    InlinePythonReporter(
-                        ReporterThatAutomaticallyApproves(), add_approval_line=False, previous_result=lambda __: DELETE_ME_TO_APPROVE_
-                    )
+                    InlinePythonReporter(ReporterThatAutomaticallyApproves(),
+                                         footer=lambda __: DELETE_ME_TO_APPROVE_)
                 )
 
         return SemiAutomaticInlineOptions()
@@ -70,9 +69,8 @@ def create_previous_capture_suffix(approved_path):
         class PreviousCaptureInlineOptions(InlineOptions):
             def apply(self, options: "Options") -> "Options":
                 return options.with_reporter(
-                    InlinePythonReporter(
-                        ReporterThatAutomaticallyApproves(), add_approval_line=False, previous_result=create_previous_capture_suffix
-                    )
+                    InlinePythonReporter(ReporterThatAutomaticallyApproves(),
+                                         footer=create_previous_capture_suffix)
                 )
 
         return PreviousCaptureInlineOptions()

approvaltests/namer/inline_python_reporter.py

@@ -11,17 +11,15 @@
 
 
 class InlinePythonReporter(Reporter):
-    def __init__(self, reporter, add_approval_line=False, previous_result=None):
+    def __init__(self, reporter, footer=None):
         self.diffReporter = reporter
-        self.semi_automatic_extra_line = (
-            DELETE_ME_TO_APPROVE_ if add_approval_line else ""
-        )
-        self.previous_result = previous_result
+        self.footer = footer
+        self.semi_automatic_extra_line = ""
 
     def report(self, received_path: str, approved_path: str) -> bool:
         test_source_file = self.get_test_source_file()
-        if self.previous_result:
-            self.semi_automatic_extra_line = self.previous_result(approved_path)
+        if self.footer:
+            self.semi_automatic_extra_line = self.footer(approved_path)
         received_path = self.create_received_file(received_path, test_source_file)
         return self.diffReporter.report(received_path, test_source_file)