Skip to content

Commit 19533b6

Browse files
isidore4dsherwoodsusanfungblade290Tegsy
committed
. t Confirmed blank lines work
Co-Authored-By: 4dsherwood <4dsherwood@users.noreply.github.com> Co-Authored-By: Susan Fung <38925660+susanfung@users.noreply.github.com> Co-Authored-By: blade290 <43077216+blade290@users.noreply.github.com> Co-Authored-By: T. E. Green <78671457+Tegsy@users.noreply.github.com>
1 parent 2857e91 commit 19533b6

2 files changed

Lines changed: 18 additions & 7 deletions

File tree

TODO.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,18 +14,16 @@ Try to make the smallest change possible, then rotate
1414

1515

1616
Inline Approvals Bugs
17-
1. [? ] fix inline bug with whitespace (trailing and leading as well as blank lines)
18-
2. [ ] fix inline bug with blank lines
19-
2. [ ] rename all of the reporters to start with the word report
20-
3. [ ] check all reporters return True or False
17+
1. [ ] rename all of the reporters to start with the word report
18+
2. [ ] check all reporters return True or False
2119
4. [ ] add mypy to the CI (type hints exist and they are being inforced)
22-
4. [ ] make it so that approvals works with Python 12
23-
5. [ ] Improve verify_all for no header
20+
3. [ ] make it so that approvals works with Python 12
21+
4. [ ] Improve verify_all for no header
2422
Expects VerifyAll to have a header
2523
this is mandatory For PYthon Approval Tests
2624
added an example to Test_inline_approvals.py
2725
see: def test_uppercase_with_verify_all():
28-
6. [ ] expand functionality of parse_doc_string NOTE: this is WIP from 3/3/24 parse inputs
26+
5. [ ] expand functionality of parse_doc_string NOTE: this is WIP from 3/3/24 parse inputs
2927
2. [ ] =>, :
3028
3. [ ] maybe not only docstring but any text or approved file?
3129
4. [ ] multiple parameters 1, 2, 3 ->

tests/test_inline_approvals.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,3 +178,16 @@ def test_trailing_whitespace():
178178
# Note: Pycharm will remove the trailing whitespaces, to disable this go to:
179179
# File -> Settings -> Editor -> General -> On Save -> [ ] Remove trailing spaces
180180
verify("4 trailing whitespaces ", options=Options().inline(show_code=False))
181+
182+
# 2. [ ] fix inline bug with blank lines <- from todo list
183+
def test_bug_blank_lines():
184+
"""
185+
186+
187+
test bug with blank lines
188+
189+
190+
191+
"""
192+
verify("\n\ntest bug with blank lines\n\n\n\n", options=Options().inline(show_code=True))
193+

0 commit comments

Comments
 (0)