- r enable explicit-override in mypy

Author: JayBazuzi

approval_utilities/utilities/markdown_table.py

@@ -1,3 +1,4 @@
+from typing_extensions import override
 from typing import Any, Callable, Iterable, TYPE_CHECKING
 
 from approval_utilities.approvaltests.core.verifiable import Verifiable
@@ -11,6 +12,7 @@ class MarkdownTable(Verifiable):
     def __init__(self) -> None:
         self.markdown: str = ""
 
+    @override
     def get_verify_parameters(self, options: "Options") -> VerifyParameters:
         return VerifyParameters(options.for_file.with_extension(".md"))
 
@@ -26,6 +28,7 @@ def add_rows(self, *column_names: str) -> "MarkdownTable":
         self.markdown += MarkdownTable.print_row(*column_names)
         return self
 
+    @override
     def __str__(self) -> str:
         return self.markdown
 

approval_utilities/utilities/string_wrapper.py

@@ -1,12 +1,15 @@
+from typing_extensions import override
 class StringWrapper:
     def __init__(self) -> None:
         self.string = ""
 
     def append(self, text: str) -> None:
         self.string += text
 
+    @override
     def __str__(self) -> str:
         return self.string
 
+    @override
     def __repr__(self) -> str:
         return self.string

approval_utilities/utilities/wrapper.py

@@ -1,3 +1,4 @@
+from typing_extensions import override
 import threading
 from abc import ABC, abstractmethod
 
@@ -12,6 +13,7 @@ class SingleWrapper(Wrapper):
     def __init__(self, instance):
         self.instance = instance
 
+    @override
     def get(self):
         return self.instance
 
@@ -21,6 +23,7 @@ def __init__(self, generator):
         self.generator = generator
         self.local = threading.local()
 
+    @override
     def get(self):
         if not hasattr(self.local, "value"):
             self.local.value = self.generator()

approvaltests/approval_exception.py

@@ -1,8 +1,10 @@
+from typing_extensions import override
 class ApprovalException(Exception):
     def __init__(self, value: str) -> None:
         super().__init__(self)
         self.value = value
 
+    @override
     def __str__(self) -> str:
         return self.value
 

approvaltests/asserts.py

@@ -1,3 +1,4 @@
+from typing_extensions import override
 from typing import Optional, Any
 
 from approval_utilities.utils import write_to_temporary_file
@@ -15,6 +16,7 @@ def __init__(self, file_path: str, extension: None = None) -> None:
         StackFrameNamer.__init__(self, extension)
         self.file_path = file_path
 
+    @override
     def get_approved_filename(self, base: Optional[str] = None) -> str:
         return self.file_path
 

approvaltests/binary_writer.py

@@ -1,3 +1,4 @@
+from typing_extensions import override
 import io
 from typing import ByteString
 
@@ -16,6 +17,7 @@ def __init__(
         self.contents = contents
         self.extension_with_dot = extension
 
+    @override
     def write_received_file(self, received_file: str) -> str:
         create_directory_if_needed(received_file)
         with io.open(received_file, mode="wb") as file:

approvaltests/core/comparator.py

@@ -1,3 +1,4 @@
+from typing_extensions import override
 from abc import ABC, abstractmethod
 
 
@@ -11,6 +12,7 @@ class Comparator(ABC):
     returns a truthy value on success.
     """
 
+    @override
     def __eq__(self, other):
         return repr(self) == repr(other)
 

approvaltests/core/format_wrapper.py

@@ -1,3 +1,4 @@
+from typing_extensions import override
 import abc
 import typing
 
@@ -13,8 +14,10 @@ def is_match(self, data: typing.Any) -> bool:
 
 
 class AlwaysMatch(FormatWrapper):
+    @override
     def wrap(self, data: typing.Any) -> typing.Any:
         return data
 
+    @override
     def is_match(self, data: typing.Any) -> bool:
         return True

approvaltests/core/reporter.py

@@ -1,3 +1,4 @@
+from typing_extensions import override
 from abc import ABC, abstractmethod
 
 
@@ -11,6 +12,7 @@ class Reporter(ABC):
     returns a truthy value on success.
     """
 
+    @override
     def __eq__(self, other):
         return repr(self) == repr(other)
 

approvaltests/core/scenario_namer.py

@@ -1,3 +1,4 @@
+from typing_extensions import override
 from typing import Optional, Any
 
 from approvaltests.core.namer import Namer
@@ -20,10 +21,12 @@ def get_basename(self) -> str:
         scenarios = ".".join(map(str, self.scenario_names))
         return f"{basename}.{scenarios}"
 
+    @override
     def get_approved_filename(self, base: Optional[str] = None) -> str:
         base = base or self.get_basename()
         return self.base_namer.get_approved_filename(base)
 
+    @override
     def get_received_filename(self, base: Optional[str] = None) -> str:
         base = base or self.get_basename()
         return self.base_namer.get_received_filename(base)