*** moving to quartz

Co-Authored-By: Jay Bazuzi <1259628+JayBazuzi@users.noreply.github.com>
Co-Authored-By: Scott Wierschem <28421044+ScottBob@users.noreply.github.com>

Author: 3 people

.windsurf/UnitTestStyleGuide.process.md

@@ -0,0 +1,6 @@
+# Unit Test Style Guide
+
+## Approvals vs Asserts
+
+* Preferable tests over multiple asserts.
+* Use toStrings and Printers. If the toString on an object is good, use it. If not, create a printing function either in the test or in production code and use that.

approvaltests-util-tests/pom.xml

@@ -29,12 +29,6 @@
             <artifactId>velocity-engine-core</artifactId>
                  <version>2.4.1</version>
         </dependency>
-        <dependency>
-            <groupId>quartz</groupId>
-            <artifactId>quartz</artifactId>
-            <version>1.5.2</version>
-            <optional>true</optional>
-        </dependency>
         <dependency>
             <groupId>com.google.code.gson</groupId>
             <artifactId>gson</artifactId>
@@ -68,6 +62,12 @@
             <artifactId>approvaltests-util</artifactId>
             <version>${project.parent.version}</version>
         </dependency>
+        <dependency>
+            <groupId>org.quartz-scheduler</groupId>
+            <artifactId>quartz</artifactId>
+            <version>2.4.0</version>
+            <scope>test</scope>
+        </dependency>
     </dependencies>
 
     <build>

approvaltests-util-tests/src/test/java/com/spun/util/quartz/QuartzUtilsTest.java

@@ -0,0 +1,52 @@
+package com.spun.util.quartz;
+
+import org.approvaltests.Approvals;
+import org.junit.jupiter.api.Test;
+import org.quartz.JobKey;
+import org.quartz.Trigger;
+import org.quartz.impl.triggers.SimpleTriggerImpl;
+
+import java.util.Date;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.junit.jupiter.api.Assertions.assertTrue;
+
+class QuartzUtilsTest
+{
+  @Test
+  void testCreateTrigger()
+  {
+    // Arrange
+    SimpleTriggerImpl oldTrigger = new SimpleTriggerImpl();
+    oldTrigger.setName("oldName");
+    oldTrigger.setGroup("oldGroup");
+    // A JobKey is required for getTriggerBuilder() and for the trigger to be valid for scheduling with a scheduler
+    oldTrigger.setJobKey(new JobKey("jobName", "jobGroup"));
+    String newName = "testTriggerName";
+    String newGroup = "testTriggerGroup";
+    long beforeTime = System.currentTimeMillis();
+    // Act
+    Trigger newTrigger = QuartzUtils.createTrigger(oldTrigger, newName, newGroup);
+    long afterTime = System.currentTimeMillis();
+    // Assert
+    assertNotNull(newTrigger, "New trigger should not be null");
+    assertEquals(newName, newTrigger.getKey().getName(), "Trigger name should be updated");
+    assertEquals(newGroup, newTrigger.getKey().getGroup(), "Trigger group should be updated");
+    assertNotNull(newTrigger.getStartTime(), "Start time should be set");
+    // Check if start time is within a small delta (e.g., 100ms) of the call time to account for execution time
+    assertTrue(
+        newTrigger.getStartTime().getTime() >= beforeTime
+            && newTrigger.getStartTime().getTime() <= afterTime + 100,
+        "Start time should be approximately now. Expected between " + beforeTime + " and " + (afterTime + 100)
+            + " but was " + newTrigger.getStartTime().getTime());
+    assertNotNull(newTrigger.getEndTime(), "End time should be set");
+    assertEquals(new Date(Long.MAX_VALUE).getTime(), newTrigger.getEndTime().getTime(),
+        "End time should be Long.MAX_VALUE");
+    // Verify that the JobKey is carried over
+    assertEquals(oldTrigger.getJobKey(), newTrigger.getJobKey(), "JobKey should be carried over from old trigger");
+    // Use ApprovalTests to verify the trigger's key aspects
+    Approvals.verify(String.format("Trigger Key: %s\nJob Key: %s\nStart Time: %s\nEnd Time: %s",
+        newTrigger.getKey(), newTrigger.getJobKey(), newTrigger.getStartTime(), newTrigger.getEndTime()));
+  }
+}

approvaltests-util-tests/src/test/java/com/spun/util/quartz/QuartzUtilsTest.testCreateTrigger.approved.txt

@@ -0,0 +1,4 @@
+Trigger Key: testTriggerGroup.testTriggerName
+Job Key: jobGroup.jobName
+Start Time: Thu May 15 22:06:52 UTC 2025
+End Time: Sun Aug 17 07:12:55 UTC 292278994

approvaltests-util/src/main/java/com/spun/util/quartz/QuartzUtils.java

@@ -9,11 +9,9 @@ public class QuartzUtils
 {
   public static Trigger createTrigger(Trigger oldTrigger, String name, String defaultGroup)
   {
-    // Get a TriggerBuilder that is configured to produce a Trigger
-    // identical to the oldTrigger one in terms of job, schedule type etc.
     TriggerBuilder<? extends Trigger> builder = oldTrigger.getTriggerBuilder();
-    // Now, set the new identity (name and group) and start/end times
-    Trigger newTrigger = builder.withIdentity(name, defaultGroup).startAt(new Date()) // Start immediately
+    Trigger newTrigger = builder.withIdentity(name, defaultGroup) //
+        .startAt(new Date()) // Start immediately
         .endAt(new Date(Long.MAX_VALUE)) // Effectively never ends
         .build();
     return newTrigger;