Merge pull request #49 from rubenpenyafiel/fix/unsettled-request-promises

Bug fixes and improvements in handling requests errors.

Author: mmoreram

dist/apisearch.js

@@ -0,0 +1,12 @@
+import { ErrorWithMessage } from "./ErrorWithMessage";
+/**
+ * Connection error
+ */
+export declare class UnknownError extends ErrorWithMessage {
+    /**
+     * Unknown error
+     *
+     * @return this
+     */
+    static createUnknownError(): UnknownError;
+}

dist/apisearch.js.map

@@ -0,0 +1,23 @@
+"use strict";
+exports.__esModule = true;
+var tslib_1 = require("tslib");
+var ErrorWithMessage_1 = require("./ErrorWithMessage");
+/**
+ * Connection error
+ */
+var UnknownError = /** @class */ (function (_super) {
+    tslib_1.__extends(UnknownError, _super);
+    function UnknownError() {
+        return _super !== null && _super.apply(this, arguments) || this;
+    }
+    /**
+     * Unknown error
+     *
+     * @return this
+     */
+    UnknownError.createUnknownError = function () {
+        return new this("Unknown error.");
+    };
+    return UnknownError;
+}(ErrorWithMessage_1.ErrorWithMessage));
+exports.UnknownError = UnknownError;

dist/apisearch.min.js

@@ -2,6 +2,7 @@
 exports.__esModule = true;
 var tslib_1 = require("tslib");
 var axios_1 = require("axios");
+var __1 = require("..");
 var Client_1 = require("./Client");
 var Response_1 = require("./Response");
 /**
@@ -55,24 +56,24 @@ var AxiosClient = /** @class */ (function (_super) {
                     this.abort(url);
                 }
                 return [2 /*return*/, new Promise(function (resolve, reject) {
-                        var headers = "get" == method
+                        var headers = "get" === method
                             ? {}
                             : {
                                 "Content-Encoding": "gzip",
                                 "Content-Type": "application/json"
                             };
                         var axiosRequestConfig = {
-                            url: url + "?" + Client_1.Client.objectToUrlParameters(tslib_1.__assign({}, parameters, {
-                                'token': credentials.token
-                            })),
+                            baseURL: that.host.replace(/\/*$/g, ""),
                             data: data,
                             headers: headers,
                             method: method,
-                            baseURL: that.host.replace(/\/*$/g, ""),
                             timeout: that.timeout,
-                            transformRequest: [function (data) { return JSON.stringify(data); }]
+                            transformRequest: [function (rawData) { return JSON.stringify(rawData); }],
+                            url: url + "?" + Client_1.Client.objectToUrlParameters(tslib_1.__assign({}, parameters, {
+                                token: credentials.token
+                            }))
                         };
-                        if (typeof _this.cancelToken[url] != 'undefined') {
+                        if (typeof _this.cancelToken[url] !== "undefined") {
                             axiosRequestConfig.cancelToken = _this.cancelToken[url].token;
                         }
                         axios_1["default"]
@@ -81,11 +82,16 @@ var AxiosClient = /** @class */ (function (_super) {
                             var response = new Response_1.Response(axiosResponse.status, axiosResponse.data);
                             return resolve(response);
                         })["catch"](function (error) {
-                            if (error.response === undefined) {
-                                return;
+                            var response;
+                            if (error.response) {
+                                response = new Response_1.Response(error.response.status, error.response.data);
+                            }
+                            else {
+                                response = new Response_1.Response(__1.ConnectionError.getTransportableHTTPError(), {
+                                    message: "Connection failed or timed out"
+                                });
                             }
-                            var response = new Response_1.Response(error.response.status, error.response.data);
-                            return reject(response);
+                            reject(response);
                         });
                     })];
             });
@@ -98,7 +104,7 @@ var AxiosClient = /** @class */ (function (_super) {
      * @param url
      */
     AxiosClient.prototype.abort = function (url) {
-        if (typeof this.cancelToken[url] != 'undefined') {
+        if (typeof this.cancelToken[url] !== "undefined") {
             this.cancelToken[url].cancel();
         }
         this.generateCancelToken(url);

dist/apisearch.min.js.map

@@ -1,15 +1,14 @@
 import { Config } from "../Config/Config";
 import { HttpClient } from "../Http/HttpClient";
-import { Response } from "../Http/Response";
 import { Changes } from "../Model/Changes";
+import { Index } from "../Model/Index";
+import { IndexUUID } from "../Model/IndexUUID";
 import { Item } from "../Model/Item";
 import { ItemUUID } from "../Model/ItemUUID";
 import { Query } from "../Query/Query";
 import { Result } from "../Result/Result";
 import { Transformer } from "../Transformer/Transformer";
 import { Repository } from "./Repository";
-import { IndexUUID } from "../Model/IndexUUID";
-import { Index } from "../Model/Index";
 /**
  * Aggregation class
  */
@@ -36,84 +35,80 @@ export declare class HttpRepository extends Repository {
      * Generate item document by a simple object.
      *
      * @param object
+     *
+     * @returns {void}
      */
     addObject(object: any): void;
     /**
      * Delete item document by uuid.
      *
      * @param object
+     *
+     * @returns {void}
      */
     deleteObject(object: any): void;
     /**
      * Flush update items
      *
-     * @param itemsToUpdate
+     * @param {Item[]} itemsToUpdate
      *
      * @return {Promise<void>}
      */
     flushUpdateItems(itemsToUpdate: Item[]): Promise<void>;
     /**
      * Flush delete items
      *
-     * @param itemsToDelete
+     * @param {ItemUUID[]} itemsToDelete
      *
      * @return {Promise<void>}
      */
     flushDeleteItems(itemsToDelete: ItemUUID[]): Promise<void>;
     /**
      * Query
      *
-     * @param query
+     * @param {Query} query
      *
      * @return {Promise<Result>}
      */
     query(query: Query): Promise<Result>;
-    /**
-     * Apply transformers to results
-     *
-     * @param result
-     *
-     * @return {Result}
-     */
-    private applyTransformersToResult;
     /**
      * Update items
      *
-     * @param query
-     * @param changes
+     * @param {Query} query
+     * @param {Changes} changes
      *
      * @return {Promise<void>}
      */
     updateItems(query: Query, changes: Changes): Promise<void>;
     /**
      * Create index
      *
-     * @param indexUUID
-     * @param config
+     * @param {IndexUUID} indexUUID
+     * @param {Config} config
      *
      * @return {Promise<void>}
      */
     createIndex(indexUUID: IndexUUID, config: Config): Promise<void>;
     /**
      * Delete index
      *
-     * @param indexUUID
+     * @param {IndexUUID} indexUUID
      *
      * @return {Promise<void>}
      */
     deleteIndex(indexUUID: IndexUUID): Promise<void>;
     /**
      * Reset index
      *
-     * @param indexUUID
+     * @param {IndexUUID} indexUUID
      *
      * @return {Promise<void>}
      */
     resetIndex(indexUUID: IndexUUID): Promise<void>;
     /**
      * Check index
      *
-     * @param indexUUID
+     * @param {IndexUUID} indexUUID
      *
      * @return {Promise<boolean>}
      */
@@ -127,8 +122,8 @@ export declare class HttpRepository extends Repository {
     /**
      * Configure index
      *
-     * @param indexUUID
-     * @param config
+     * @param {IndexUUID} indexUUID
+     * @param {Config} config
      *
      * @return {Promise<void>}
      */
@@ -140,9 +135,17 @@ export declare class HttpRepository extends Repository {
      */
     private getCredentials;
     /**
-     * throw error if needed
+     * Apply transformers to results
+     *
+     * @param {Result} result
+     *
+     * @return {Result}
+     */
+    private applyTransformersToResult;
+    /**
+     * Create exception to match an error response
      *
-     * @param response
+     * @param any response
      */
-    static throwTransportableExceptionIfNeeded(response: Response): void;
+    private createErrorFromResponse;
 }