Skip to content

Commit 882d4aa

Browse files
dididyjongyoul
authored andcommitted
apply meaningful copilot reviews
1 parent 91042fb commit 882d4aa

4 files changed

Lines changed: 5 additions & 8 deletions

File tree

zeppelin-web-angular/e2e/models/base-page.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,7 @@ export class BasePage {
9494
}
9595
}
9696

97-
async fillAndVerifyInput(
98-
locator: Locator,
99-
value: string,
100-
options?: { timeout?: number; clearFirst?: boolean }
101-
): Promise<void> {
97+
async fillAndVerifyInput(locator: Locator, value: string, options?: { timeout?: number }): Promise<void> {
10298
const { timeout = 10000 } = options || {};
10399

104100
await expect(locator).toBeVisible({ timeout });

zeppelin-web-angular/e2e/models/home-page.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ export class HomePage extends BasePage {
7878
}
7979

8080
async navigateToHome(): Promise<void> {
81-
await this.page.goto('/');
81+
await this.page.goto('/#/');
8282
await this.waitForPageLoad();
8383
}
8484

zeppelin-web-angular/e2e/tests/share/node-list/node-list-functionality.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ test.describe('Node List Functionality', () => {
8888
if (notes.length === 0) {
8989
// Seed a note so the test always runs — critical navigation path must not be skipped
9090
await homePage.createNote(`_e2e_nav_${Date.now()}`);
91-
await page.goto('/');
91+
await page.goto('/#/');
9292
await waitForZeppelinReady(page);
9393
notes = await nodeListPage.getAllVisibleNoteNames();
9494
}

zeppelin-web-angular/e2e/tests/workspace/notebook-repos/notebook-repo-item-workflow.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ test.describe('Notebook Repository Item - Edit Workflow', () => {
5555

5656
const isInputVisible = await row.locator('input[nz-input]').isVisible();
5757
if (isInputVisible) {
58-
savedValue = (await repoItemPage.getSettingInputValue(settingName)) || 'test-value';
58+
const currentValue = (await repoItemPage.getSettingInputValue(settingName)) || '';
59+
savedValue = currentValue ? `${currentValue}_edited` : 'test-value';
5960
await repoItemPage.fillSettingInput(settingName, savedValue);
6061
savedSettingName = settingName;
6162
break;

0 commit comments

Comments
 (0)