Skip to content

Commit 78e38eb

Browse files
authored
Fix comment typos: succesfully→successfully, sould→should, dont→don't (#18291)
1 parent 1d2d191 commit 78e38eb

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1016,7 +1016,7 @@ public void run() {
10161016
TimeUnit.MILLISECONDS.toSeconds(now() - initialConsumptionEnd));
10171017
}
10181018
// There is a race condition that the destroy() method can be called which ends up calling stop on the consumer.
1019-
// The destroy() method does not wait for the thread to terminate (and reasonably so, we dont want to wait
1019+
// The destroy() method does not wait for the thread to terminate (and reasonably so, we don't want to wait
10201020
// forever).
10211021
// Since the _shouldStop variable is set to true only in stop() method, we know that the metric will be destroyed,
10221022
// so it is ok not to mark it non-consuming, as the main thread will clean up this metric in destroy() method

pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/PurgeMinionClusterIntegrationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ protected TableTaskConfig getPurgeTaskConfig() {
203203
public void testFirstRunPurge()
204204
throws Exception {
205205
// Expected purge task generation :
206-
// 1. No previous purge run so all segment should be processed and purge metadata sould be added to the segments
206+
// 1. No previous purge run so all segment should be processed and purge metadata should be added to the segments
207207
// 2. Check that we cannot run on same time two purge generation ensuring running segment will be skipped
208208
// 3. Check segment ZK metadata to ensure purge time is updated into the metadata
209209
// 4. Check after the first run of the purge if we rerun a purge task generation no task should be scheduled

pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotRuleUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public static boolean isAggregate(RelNode rel) {
100100
* <ul>
101101
* <li>`RelNode` that are single-in, single-out are possible (Project/Filter/)</li>
102102
* <li>`Join` can be stacked on top if we only consider SEMI-JOIN</li>
103-
* <li>`Window` should be allowed but we dont have impl for Window on leaf, so not yet included.</li>
103+
* <li>`Window` should be allowed but we don't have impl for Window on leaf, so not yet included.</li>
104104
* <li>`Sort` should be allowed but we need to reorder Sort and Join first, so not yet included.</li>
105105
* </ul>
106106
*/

pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/tablestate/TableStateUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,12 +76,12 @@ public static List<String> getSegmentsInGivenStateForThisInstance(HelixManager h
7676
}
7777

7878
/**
79-
* Checks if all segments for the given @param tableNameWithType were succesfully loaded
79+
* Checks if all segments for the given @param tableNameWithType were successfully loaded
8080
* This function will get all segments in IDEALSTATE and CURRENTSTATE for the given table,
8181
* and then check if all ONLINE segments in IDEALSTATE match with CURRENTSTATE.
8282
* @param helixManager helix manager for the server instance
8383
* @param tableNameWithType table name for which segment state is to be checked
84-
* @return true if all segments for the given table are succesfully loaded. False otherwise
84+
* @return true if all segments for the given table are successfully loaded. False otherwise
8585
*/
8686
public static boolean isAllSegmentsLoaded(HelixManager helixManager, String tableNameWithType) {
8787
List<String> onlineSegments =

0 commit comments

Comments
 (0)