Disambiguate FieldConfig test constructors

Author: xiangfu0

pinot-core/src/test/java/org/apache/pinot/core/data/manager/TableIndexingTest.java

@@ -47,6 +47,7 @@
 import org.apache.pinot.segment.spi.datasource.DataSource;
 import org.apache.pinot.segment.spi.index.IndexService;
 import org.apache.pinot.segment.spi.index.startree.StarTreeV2;
+import org.apache.pinot.spi.config.table.CompressionCodecSpec;
 import org.apache.pinot.spi.config.table.FieldConfig;
 import org.apache.pinot.spi.config.table.IndexingConfig;
 import org.apache.pinot.spi.config.table.MultiColumnTextIndexConfig;
@@ -472,8 +473,8 @@ public void testAddIndex(TestCase testCase) {
           throw new IllegalArgumentException("Unexpected index type " + indexType);
       }
 
-      config =
-          new FieldConfig(field.getName(), encoding, null, indexTypes, null, tstmpConfig, indexes, properties, null);
+      config = new FieldConfig(field.getName(), encoding, null, indexTypes, (CompressionCodecSpec) null, tstmpConfig,
+          indexes, properties, null);
 
       tableConfig.getFieldConfigList().add(config);
 

pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunctionTest.java

@@ -48,6 +48,7 @@
 import org.apache.pinot.segment.spi.IndexSegment;
 import org.apache.pinot.segment.spi.creator.SegmentGeneratorConfig;
 import org.apache.pinot.segment.spi.datasource.DataSource;
+import org.apache.pinot.spi.config.table.CompressionCodecSpec;
 import org.apache.pinot.spi.config.table.FieldConfig;
 import org.apache.pinot.spi.config.table.TableConfig;
 import org.apache.pinot.spi.config.table.TableType;
@@ -340,9 +341,8 @@ protected TableConfig getTableConfig() {
     jsonIndexProps.put("disableCrossArrayUnnest", true);
     ObjectNode indexNode = JsonNodeFactory.instance.objectNode();
     indexNode.put("json", jsonIndexProps);
-    FieldConfig jsonFieldConfig =
-        new FieldConfig(JSON_STRING_SV_COLUMN, FieldConfig.EncodingType.DICTIONARY, null, null, null, null, indexNode,
-            null, null);
+    FieldConfig jsonFieldConfig = new FieldConfig(JSON_STRING_SV_COLUMN, FieldConfig.EncodingType.DICTIONARY, null,
+        null, (CompressionCodecSpec) null, null, indexNode, null, null);
     fieldConfigList.add(jsonFieldConfig);
     TableConfig tableConfig =
         new TableConfigBuilder(TableType.OFFLINE).setTableName("test").setTimeColumnName(TIME_COLUMN)

pinot-core/src/test/java/org/apache/pinot/queries/BaseFSTBasedRegexpLikeQueriesTest.java

@@ -44,6 +44,7 @@
 import org.apache.pinot.segment.spi.ImmutableSegment;
 import org.apache.pinot.segment.spi.IndexSegment;
 import org.apache.pinot.segment.spi.creator.SegmentGeneratorConfig;
+import org.apache.pinot.spi.config.table.CompressionCodecSpec;
 import org.apache.pinot.spi.config.table.FieldConfig;
 import org.apache.pinot.spi.config.table.FieldConfig.EncodingType;
 import org.apache.pinot.spi.config.table.TableConfig;
@@ -91,8 +92,10 @@ private static List<FieldConfig> getFieldConfigs(String indexType) {
 
       // Create FieldConfig with the index configuration
       return List.of(
-          new FieldConfig(DOMAIN_NAMES_COL, EncodingType.DICTIONARY, null, null, null, null, indexes, null, null),
-          new FieldConfig(URL_COL, EncodingType.DICTIONARY, null, null, null, null, indexes, null, null));
+          new FieldConfig(DOMAIN_NAMES_COL, EncodingType.DICTIONARY, null, null, (CompressionCodecSpec) null, null,
+              indexes, null, null),
+          new FieldConfig(URL_COL, EncodingType.DICTIONARY, null, null, (CompressionCodecSpec) null, null, indexes,
+              null, null));
     } catch (Exception e) {
       throw new RuntimeException("Failed to create field configs", e);
     }

pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/custom/TextIndicesTest.java

@@ -33,6 +33,7 @@
 import org.apache.avro.Schema.Type;
 import org.apache.avro.file.DataFileWriter;
 import org.apache.avro.generic.GenericData;
+import org.apache.pinot.spi.config.table.CompressionCodecSpec;
 import org.apache.pinot.spi.config.table.FieldConfig;
 import org.apache.pinot.spi.config.table.TableConfig;
 import org.apache.pinot.spi.config.table.TableType;
@@ -93,13 +94,12 @@ protected List<FieldConfig> getFieldConfigs() {
     }
 
     FieldConfig nullableTextConfig =
-        new FieldConfig(TEXT_COLUMN_NULL_NAME, FieldConfig.EncodingType.RAW, null, null, null, null, textColumnIndexes,
-            null,
-            null);
+        new FieldConfig(TEXT_COLUMN_NULL_NAME, FieldConfig.EncodingType.RAW, null, null, (CompressionCodecSpec) null,
+            null, textColumnIndexes, null, null);
 
     FieldConfig textColumnFieldConfig =
-        new FieldConfig(TEXT_COLUMN_NAME, FieldConfig.EncodingType.RAW, null, null, null, null, textColumnIndexes, null,
-            null);
+        new FieldConfig(TEXT_COLUMN_NAME, FieldConfig.EncodingType.RAW, null, null, (CompressionCodecSpec) null, null,
+            textColumnIndexes, null, null);
 
     ObjectNode textColumnCaseSensitiveIndexes;
     try {
@@ -115,7 +115,8 @@ protected List<FieldConfig> getFieldConfigs() {
       throw new RuntimeException(e);
     }
     FieldConfig textColumnCaseSensitiveFieldConfig =
-        new FieldConfig(TEXT_COLUMN_NAME_CASE_SENSITIVE, FieldConfig.EncodingType.RAW, null, null, null, null,
+        new FieldConfig(TEXT_COLUMN_NAME_CASE_SENSITIVE, FieldConfig.EncodingType.RAW, null, null,
+            (CompressionCodecSpec) null, null,
             textColumnCaseSensitiveIndexes, null, null);
     return Arrays.asList(nullableTextConfig, textColumnFieldConfig, textColumnCaseSensitiveFieldConfig);
   }

pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java

@@ -35,6 +35,7 @@
 import org.apache.pinot.segment.spi.index.startree.AggregationFunctionColumnPair;
 import org.apache.pinot.spi.config.table.BloomFilterConfig;
 import org.apache.pinot.spi.config.table.ColumnPartitionConfig;
+import org.apache.pinot.spi.config.table.CompressionCodecSpec;
 import org.apache.pinot.spi.config.table.DedupConfig;
 import org.apache.pinot.spi.config.table.FieldConfig;
 import org.apache.pinot.spi.config.table.FieldConfig.CompressionCodec;
@@ -1486,8 +1487,8 @@ public void testValidateBFOnBoolean() {
     TableConfig tableconfig3 = new TableConfigBuilder(TableType.REALTIME).setTableName(TABLE_NAME).build();
     ObjectNode indexesNode = JsonNodeFactory.instance.objectNode();
     indexesNode.putObject("bloom");
-    FieldConfig fieldConfig =
-        new FieldConfig("MyCol", FieldConfig.EncodingType.DICTIONARY, null, null, null, null, indexesNode, null, null);
+    FieldConfig fieldConfig = new FieldConfig("MyCol", FieldConfig.EncodingType.DICTIONARY, null, null,
+        (CompressionCodecSpec) null, null, indexesNode, null, null);
     tableconfig3.setFieldConfigList(Arrays.asList(fieldConfig));
     assertThrows(IllegalStateException.class, () -> TableConfigUtils.validate(tableconfig3, schema));
   }