Skip to content

Commit 589f9d4

Browse files
authored
remove support for Node.js v16 (EOL 9/11/23). (#241)
1 parent 28ac4c0 commit 589f9d4

12 files changed

Lines changed: 5 additions & 290 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ jobs:
8888
working-directory: runtime
8989
run: |
9090
SHORT_COMMIT=$(git rev-parse --short "$GITHUB_SHA")
91-
./gradlew :core:nodejs16Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly
92-
./gradlew :core:nodejs16Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=$SHORT_COMMIT
9391
./gradlew :core:nodejs18Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly
9492
./gradlew :core:nodejs18Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=$SHORT_COMMIT
9593
./gradlew :core:nodejs20Action:distDocker -PdockerRegistry=docker.io -PdockerImagePrefix=openwhisk -PdockerImageTag=nightly

README.md

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ This repository contains sources files needed to build the Node.js runtimes for
2626

2727
The following Node.js runtime versions (with kind & image labels) are generated by the build system:
2828

29-
- Node.js 16 (`nodejs:16` & `openwhisk/action-nodejs-v16`)
3029
- Node.js 18 (`nodejs:18` & `openwhisk/action-nodejs-v18`)
3130
- Node.js 20 (`nodejs:20` & `openwhisk/action-nodejs-v20`)
3231

@@ -38,24 +37,23 @@ This README documents the build, customisation and testing of these runtime imag
3837

3938
If the deployment of Apache OpenWhisk includes these images in the runtime manifest, use the `--kind` parameter to select the Node.js runtime version.
4039

41-
### Node.js v16
40+
### Node.js v20
4241

4342
```
44-
wsk action update myAction myAction.js --kind nodejs:16
43+
wsk action update myAction myAction.js --kind nodejs:20
4544
```
4645

4746
## Images
4847

4948
All the runtime images are published by the project to Docker Hub @ [https://hub.docker.com/u/openwhisk](https://hub.docker.com/u/openwhisk)
5049

51-
- [https://hub.docker.com/r/openwhisk/action-nodejs-v16](https://hub.docker.com/r/openwhisk/action-nodejs-v16)
5250
- [https://hub.docker.com/r/openwhisk/action-nodejs-v18](https://hub.docker.com/r/openwhisk/action-nodejs-v18)
5351
- [https://hub.docker.com/r/openwhisk/action-nodejs-v20](https://hub.docker.com/r/openwhisk/action-nodejs-v20)
5452

5553
These images can be used to execute Node.js actions on any deployment of Apache OpenWhisk, even those without those images defined the in runtime manifest, using the `--docker` action parameter.
5654

5755
```
58-
wsk action update myAction myAction.js --docker openwhisk/action-nodejs-v16
56+
wsk action update myAction myAction.js --docker openwhisk/action-nodejs-v20
5957
```
6058

6159
If you build a custom version of the images, pushing those an external Docker Hub repository will allow you to use those on the Apache OpenWhisk deployment.
@@ -77,11 +75,11 @@ The `core/nodejsActionBase` folder contains the Node.js app server used to imple
7775
- Run the `distDocker` command to generate local Docker images for the different runtime versions.
7876

7977
```
80-
./gradlew core:nodejs16Action:distDocker
8178
./gradlew core:nodejs18Action:distDocker
79+
./gradlew core:nodejs20Action:distDocker
8280
```
8381

84-
This will return the following runtime images with the following names: `action-nodejs-v16`, and `action-nodejs-v18`.
82+
This will return the following runtime images with the following names: `action-nodejs-v18`, and `action-nodejs-v20`.
8583

8684
### Testing
8785

@@ -97,7 +95,6 @@ This will return the following runtime images with the following names: `action-
9795
- Build the custom Docker images used in local testing.
9896

9997
```
100-
./gradlew tests:dat:docker:nodejs16docker:distDocker
10198
./gradlew tests:dat:docker:nodejs18docker:distDocker
10299
./gradlew tests:dat:docker:nodejs20docker:distDocker
103100
```

core/nodejs16Action/.dockerignore

Lines changed: 0 additions & 13 deletions
This file was deleted.

core/nodejs16Action/CHANGELOG.md

Lines changed: 0 additions & 35 deletions
This file was deleted.

core/nodejs16Action/Dockerfile

Lines changed: 0 additions & 44 deletions
This file was deleted.

core/nodejs16Action/build.gradle

Lines changed: 0 additions & 86 deletions
This file was deleted.

settings.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,8 @@
1818
include 'tests'
1919

2020
include 'core:nodejsActionBase'
21-
include 'core:nodejs16Action'
2221
include 'core:nodejs18Action'
2322
include 'core:nodejs20Action'
24-
include 'tests:dat:docker:nodejs16docker'
2523
include 'tests:dat:docker:nodejs18docker'
2624
include 'tests:dat:docker:nodejs20docker'
2725

tests/dat/docker/nodejs16docker/Dockerfile

Lines changed: 0 additions & 19 deletions
This file was deleted.

tests/dat/docker/nodejs16docker/build.gradle

Lines changed: 0 additions & 19 deletions
This file was deleted.

tests/dat/docker/nodejs16docker/package.json

Lines changed: 0 additions & 8 deletions
This file was deleted.

0 commit comments

Comments
 (0)