chore: remove Groovy compilation from the build pipeline

Author: vlsi

CONTRIBUTING.md

@@ -53,8 +53,7 @@ Optionally you can generate an Eclipse project by running
 The steps to import the sources (based on Eclipse 2019-06) into Eclipse are as follows:
 
 1. Install `Eclipse IDE for Java Developers`
-1. Install the Groovy Eclipse plugin and select Groovy Compiler 2.4 (some tests are written in Groovy)
-1. Install `Kotlin for Eclipse` plugin (builds scripts are written in Kotlin)
+1. Install `Kotlin for Eclipse` plugin (JMeter code uses Java and Kotlin)
 1. Make sure you have a Java 8 compatible JDK configured in your workspace
 1. Open `File->Import...`
 1. Select `Existing Gradle Project` and click `Next`

build-logic/jvm/src/main/kotlin/build-logic.groovy.gradle.kts

@@ -19,10 +19,6 @@ plugins {
     id("build-logic.java-library")
 }
 
-if (file("src/main/groovy").isDirectory || file("src/test/groovy").isDirectory) {
-    apply(plugin = "build-logic.groovy")
-}
-
 if (file("src/main/kotlin").isDirectory || file("src/test/kotlin").isDirectory) {
     apply(plugin = "build-logic.kotlin")
 }

build-logic/jvm/src/main/kotlin/build-logic.jvm-library.gradle.kts

@@ -61,20 +61,4 @@ tasks.configureEach<Test> {
     passProperty("skip.test_TestDNSCacheManager.testWithCustomResolverAnd1Server")
     // Enable testing ByteBuddy with EA Java versions
     passProperty("net.bytebuddy.experimental", "true")
-    // Spock tests use cglib proxies that access ClassLoader.defineClass reflectively,
-    // So we pass --add-opens
-    // See https://github.com/apache/jmeter/pull/5763
-    jvmArgumentProviders += AddOpensArgumentsProvider(javaLauncher.map { it.metadata.languageVersion })
-}
-
-class AddOpensArgumentsProvider(
-    @Input val javaLanguageVersion: Provider<JavaLanguageVersion>
-): CommandLineArgumentProvider {
-    override fun asArguments(): Iterable<String> =
-        if (javaLanguageVersion.get().asInt() <= 8) {
-            // Jave 1.8 does not need add-opens, so we omit it
-            listOf()
-        } else {
-            listOf("--add-opens=java.base/java.lang=ALL-UNNAMED")
-        }
 }

build-logic/jvm/src/main/kotlin/build-logic.test-base.gradle.kts

@@ -211,7 +211,6 @@
     <trusted-key id='60200ac4ae761f1614d6c46766d68daa073be985' group='org.slf4j' />
     <trusted-key id='2b1042677fd8190c7b9fc0dc2161d72e7dcd4258' group='org.sonarsource.scanner.api' />
     <trusted-key id='f1182e81c792928921dbcab4cfca4a29d26468de' group='org.sonarsource.scanner.api' />
-    <trusted-key id='76e94e8ff0ab5af3b6f8366972fefd1572eb75e1' group='org.spockframework' />
     <trusted-key id='8756c4f765c9ac3cb6b85d62379ce192d401ab61' group='org.springframework' />
     <trusted-key id='e2acb037933cdeaab7bf77d49a2c7a98e457c53d' group='org.springframework' />
     <trusted-key id='7cd52b5a8295137c88fb5748dddafa7674e54418' group='org.testng' />

build-logic/jvm/src/main/kotlin/build-logic.test-spock.gradle.kts

@@ -113,12 +113,6 @@
       "groupName": "org.slf4j",
       "allowedVersions": "< 2.0.0"
     },
-    {
-      "matchPackagePrefixes": ["org.spockframework"],
-      "groupName": "org.spockframework",
-      "description": "TODO: change when we upgrade to Groovy 4.0",
-      "allowedVersions": "/.*-groovy-3.0/"
-    },
     {
       "matchPackagePatterns": ["^src:protocol"],
       "enabled": false

checksum.xml

@@ -56,7 +56,6 @@ dependencies {
         api("org.objenesis:objenesis:3.3")
         api("org.openjdk.jmh:jmh-core:1.37")
         api("org.openjdk.jmh:jmh-generator-annprocess:1.37")
-        api("org.spockframework:spock-core:2.3-groovy-3.0")
         api("org.springframework:spring-beans:4.3.30.RELEASE")
         api("org.springframework:spring-context:4.3.30.RELEASE")
     }

renovate.json

@@ -91,7 +91,6 @@ dependencies {
     testFixturesImplementation(testFixtures(projects.src.core))
     testFixturesImplementation("junit:junit")
     testImplementation("io.mockk:mockk")
-    testFixturesImplementation("org.spockframework:spock-core")
 }
 
 if (!buildParameters.enableJavaFx) {