fix: Fix File->Open recent showing old files across multiple JVMs

Closes #6509

Author: KingRabbid

src/core/src/main/java/org/apache/jmeter/gui/action/LoadRecentProject.java

@@ -27,13 +27,17 @@
 import java.util.List;
 import java.util.Objects;
 import java.util.Set;
+import java.util.prefs.BackingStoreException;
 import java.util.prefs.Preferences;
 import java.util.stream.Collectors;
 import java.util.stream.IntStream;
 
 import javax.swing.JComponent;
 import javax.swing.JMenuItem;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 import com.google.auto.service.AutoService;
 
 /**
@@ -47,6 +51,7 @@ public class LoadRecentProject extends Load {
     /** The number of menu items used for recent files */
     private static final int NUMBER_OF_MENU_ITEMS = 9;
     private static final Set<String> commands = new HashSet<>();
+    private static final Logger log = LoggerFactory.getLogger(LoadRecentProject.class);
 
     static {
         commands.add(ActionNames.OPEN_RECENT);
@@ -89,6 +94,11 @@ private static File getRecentFile(ActionEvent e) {
      * @return a List of JMenuItem, representing recent files. JMenuItem may not be visible
      */
     public static List<JComponent> getRecentFileMenuItems() {
+        try {
+            prefs.sync();
+        } catch (BackingStoreException e) {
+            log.warn("Unable to sync preferences for recent files", e);
+        }
         List<JComponent> menuItems = new ArrayList<>();
         // Get the preference for the recent files
         for(int i = 0; i < NUMBER_OF_MENU_ITEMS; i++) {
@@ -223,6 +233,11 @@ public static String getRecentFile(int index) {
      */
     private static void setRecentFile(int index, String fileName) {
         prefs.put(USER_PREFS_KEY + index, fileName);
+        try {
+            prefs.flush();
+        } catch (BackingStoreException e) {
+            log.warn("Unable to flush preferences for recent files", e);
+        }
     }
 
     private static void removeRecentFile(int index) {

src/core/src/main/java/org/apache/jmeter/gui/util/JMeterMenuBar.java

@@ -39,6 +39,8 @@
 import javax.swing.MenuElement;
 import javax.swing.UIManager;
 import javax.swing.UIManager.LookAndFeelInfo;
+import javax.swing.event.MenuEvent;
+import javax.swing.event.MenuListener;
 
 import org.apache.jmeter.gui.GuiPackage;
 import org.apache.jmeter.gui.action.ActionNames;
@@ -530,6 +532,30 @@ private void makeFileMenu() {
         fileLoadRecentFiles.forEach(jc -> recentFilesOpen.add(jc));
         recentFilesOpen.setEnabled(LoadRecentProject.hasVisibleMenuItem(fileLoadRecentFiles));
 
+        // Add menu listener to refresh recent files when menu is selected
+        recentFilesOpen.addMenuListener(new MenuListener() {
+            @Override
+            public void menuSelected(MenuEvent e) {
+                // Clear existing recent files from menu
+                recentFilesOpen.removeAll();
+
+                // Reload recent files
+                fileLoadRecentFiles = LoadRecentProject.getRecentFileMenuItems();
+                fileLoadRecentFiles.forEach(jc -> recentFilesOpen.add(jc));
+                recentFilesOpen.setEnabled(LoadRecentProject.hasVisibleMenuItem(fileLoadRecentFiles));
+            }
+
+            @Override
+            public void menuDeselected(MenuEvent e) {
+                // Not needed
+            }
+
+            @Override
+            public void menuCanceled(MenuEvent e) {
+                // Not needed
+            }
+        });
+
         addPluginsMenuItems(fileMenu, menuCreators, MENU_LOCATION.FILE);
 
         // When JMeter menu is integrated with macOS system menu, there's no need in extra "exit"

xdocs/changes.xml

@@ -70,6 +70,7 @@ Summary
     <li><issue>6352</issue> Calculate delays in Open Model Thread Group and Precise Throughput
         Timer relative to start of Thread Group instead of the start of the test.</li>
     <li><issue>6357</issue><pr>6358</pr> Ensure writable directories when copying template files while report generation.</li>
+    <li><pr>6509</pr><pr>6675</pr> Synchronize recent file menu across multiple JVMs. Contributed by Corneliu C (https://github.com/KingRabbid)</li>
   </ul>
 
   <h3>HTTP Samplers and Test Script Recorder</h3>