Skip to content

Commit ca708c8

Browse files
dk2kvlsi
authored andcommitted
Removed several collections which are updated, but seem to be never accessed.
1 parent 6b65008 commit ca708c8

3 files changed

Lines changed: 0 additions & 13 deletions

File tree

src/core/src/main/java/org/apache/jmeter/gui/HtmlReportUI.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
import org.slf4j.LoggerFactory;
5353

5454
public class HtmlReportUI implements ActionListener {
55-
private static final Set<String> commands = new HashSet<>();
5655
private static final Logger LOGGER = LoggerFactory.getLogger(HtmlReportUI.class);
5756

5857
private static final String CREATE_REQUEST = "CREATE_REQUEST";
@@ -82,11 +81,6 @@ public class HtmlReportUI implements ActionListener {
8281
private final ImageIcon inErrorIcon = JMeterUtils.getImage(IMAGES_PREFIX + iconSize +"/dialog-error-5.png");// $NON-NLS-1$
8382
private final ImageIcon completedIcon = JMeterUtils.getImage(IMAGES_PREFIX + iconSize +"/task-complete.png");// $NON-NLS-1$
8483

85-
86-
static {
87-
commands.add(ActionNames.HTML_REPORT);
88-
}
89-
9084
public HtmlReportUI() {
9185
super();
9286
}

src/core/src/main/java/org/apache/jmeter/testelement/TestPlan.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,8 +43,6 @@ public class TestPlan extends AbstractTestElement implements Serializable, TestS
4343

4444
private static final String BASEDIR = "basedir";
4545

46-
private transient List<AbstractThreadGroup> threadGroups = new ArrayList<>();
47-
4846
// There's only 1 test plan, so can cache the mode here
4947
private static volatile boolean functionalMode = false;
5048

@@ -68,7 +66,6 @@ public TestPlanSchema getSchema() {
6866

6967
// create transient item
7068
protected Object readResolve(){
71-
threadGroups = new ArrayList<>();
7269
return this;
7370
}
7471

@@ -213,7 +210,6 @@ public void addTestElement(TestElement tg) {
213210
* the feature to be added to the AbstractThreadGroup attribute
214211
*/
215212
public void addThreadGroup(AbstractThreadGroup group) {
216-
threadGroups.add(group);
217213
}
218214

219215
/**

src/protocol/jms/src/main/java/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -254,7 +254,6 @@ private void handleOneWay(SampleResult res) throws JMSException {
254254

255255
private void handleRead(JMeterContext context, SampleResult res) {
256256
LOGGER.debug("isRead");
257-
StringBuilder sb = new StringBuilder(75);
258257
res.setSuccessful(true);
259258
Sampler sampler = context.getPreviousSampler();
260259
SampleResult sr = context.getPreviousResult();
@@ -273,8 +272,6 @@ private void handleRead(JMeterContext context, SampleResult res) {
273272
do {
274273
result = browseQueueForConsumption(sendQueue, jmsSelector, res, buffer, propBuffer);
275274
if (result != null) {
276-
sb.append(result);
277-
sb.append('\n');
278275
sampleCounter++;
279276
}
280277
sampleTries++;

0 commit comments

Comments
 (0)