refactor: migrate JUnit 3 tests to JUnit 5, remove JUnit 4 test dependency

Now we have only JUnit 5 on the test compilation classpath, and IDE
no longer suggests multiple different @test and assertEquals implementations.

Author: vlsi

build-logic/jvm/src/main/kotlin/build-logic.test-junit5.gradle.kts

@@ -23,10 +23,14 @@ plugins {
 }
 
 dependencies {
-    testImplementation("junit:junit")
     testImplementation("org.junit.jupiter:junit-jupiter")
     testImplementation("org.hamcrest:hamcrest")
-    testRuntimeOnly("org.junit.vintage:junit-vintage-engine")
+}
+
+plugins.withId("java-test-fixtures") {
+    dependencies {
+        "testFixturesImplementation"("org.junit.jupiter:junit-jupiter")
+    }
 }
 
 tasks.configureEach<Test> {

src/bom-testing/build.gradle.kts

@@ -39,7 +39,6 @@ dependencies {
         // to make runtime classpath consistent with the compile one.
         api("com.github.tomakehurst:wiremock-jre8:2.35.1")
         api("io.mockk:mockk:1.13.7")
-        api("junit:junit:4.13.2")
         api("net.bytebuddy:byte-buddy:1.14.11")
         api("nl.jqno.equalsverifier:equalsverifier:3.15.5")
         // activemq-all should not be used as it provides secondary slf4j binding

src/components/build.gradle.kts

@@ -89,7 +89,6 @@ dependencies {
     testImplementation("nl.jqno.equalsverifier:equalsverifier")
     testImplementation(testFixtures(projects.src.testkitWiremock))
     testFixturesImplementation(testFixtures(projects.src.core))
-    testFixturesImplementation("junit:junit")
     testImplementation("io.mockk:mockk")
 }
 

src/components/src/main/java/org/apache/jmeter/config/KeystoreConfigBeanInfo.java

@@ -44,7 +44,7 @@ public KeystoreConfigBeanInfo() {
 
         PropertyDescriptor p = property(PRELOAD);
         p.setValue(NOT_UNDEFINED, Boolean.TRUE);
-        p.setValue(DEFAULT, "true"); // $NON-NLS-1$
+        p.setValue(DEFAULT, "True"); // $NON-NLS-1$
         p.setValue(NOT_EXPRESSION, Boolean.TRUE);
         p.setValue(NOT_OTHER, Boolean.TRUE);
         p.setValue(TAGS, new String[]{"True", "False"}); // $NON-NLS-1$ $NON-NLS-2$

src/components/src/test/java/org/apache/jmeter/extractor/json/jmespath/TestJMESPathExtractor.java

@@ -32,7 +32,6 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.Arguments;
 import org.junit.jupiter.params.provider.MethodSource;
-import org.junit.runners.Parameterized.Parameters;
 
 class TestJMESPathExtractor {
     private static final String DEFAULT_VALUE = "NONE"; // $NON-NLS-1$
@@ -151,7 +150,6 @@ private void testMultipleMatchesOnAllExtractedValues(boolean fromVars, String da
             + "    {\"missing\": \"different\"}\r\n" + "  ],\r\n" + "  \"foo\": {\"bar\": \"baz\"}\r\n"
             + "}";
 
-    @Parameters
     private static Stream<Arguments> dataMatchNumberMoreThanZero() {
         return Stream.of(
             Arguments.of(TEST_DATA, "people[:3].first", "1", "James", "3"),

src/core/build.gradle.kts

@@ -123,7 +123,6 @@ dependencies {
     testImplementation("io.mockk:mockk")
 
     testFixturesApi(testFixtures(projects.src.jorphan))
-    testFixturesImplementation("junit:junit")
     testFixturesImplementation(projects.src.testkit)
     testFixturesImplementation("org.junit.jupiter:junit-jupiter")
 }

src/core/src/main/java/org/apache/jmeter/testbeans/gui/TestBeanGUI.java

@@ -33,6 +33,7 @@
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
+import java.util.Objects;
 import java.util.ResourceBundle;
 
 import javax.swing.JPopupMenu;
@@ -152,7 +153,7 @@ public TestBeanGUI() {
     }
 
     public TestBeanGUI(Class<?> testBeanClass) {
-        super();
+        Objects.requireNonNull(testBeanClass, "testBeanClass");
         log.debug("testing class: {}", testBeanClass);
         // A quick verification, just in case:
         if (!TestBean.class.isAssignableFrom(testBeanClass)) {