Skip to content

Commit 78a51ce

Browse files
author
jvangaalen
committed
Revert "doc: update documentation for sampleresult.default.encoding default value"
This reverts commit 4340b2a.
1 parent afc2337 commit 78a51ce

4 files changed

Lines changed: 44 additions & 4 deletions

File tree

bin/jmeter.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1101,8 +1101,8 @@ csvdataset.file.encoding_list=UTF-8|UTF-16|ISO-8859-15|US-ASCII
11011101
# List of extra HTTP methods that should be available in select box
11021102
#httpsampler.user_defined_methods=VERSION-CONTROL,REPORT,CHECKOUT,CHECKIN,UNCHECKOUT,MKWORKSPACE,UPDATE,LABEL,MERGE,BASELINE-CONTROL,MKACTIVITY
11031103

1104-
# The encoding to be used if none is provided (default UTF-8 since JMeter 5.6.1)
1105-
#sampleresult.default.encoding=UTF-8
1104+
# The encoding to be used if none is provided (default ISO-8859-1)
1105+
#sampleresult.default.encoding=ISO-8859-1
11061106

11071107
# CookieManager behaviour - should cookies with null/empty values be deleted?
11081108
# Default is true. Use false to revert to original behaviour

src/core/src/main/java/org/apache/jmeter/samplers/SampleResult.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,10 +66,15 @@ public class SampleResult implements Serializable, Cloneable, Searchable {
6666
private static final String INVALID_CALL_SEQUENCE_MSG = "Invalid call sequence"; // $NON-NLS-1$
6767

6868

69+
// Bug 33196 - encoding ISO-8859-1 is only suitable for Western countries
70+
// However the suggested System.getProperty("file.encoding") is Cp1252 on
71+
// Windows
72+
// So use a new property with the original value as default
73+
// needs to be accessible from test code
6974
/**
7075
* The default encoding to be used to decode the responseData byte array.
7176
* The value is defined by the property "sampleresult.default.encoding"
72-
* with a default of {@link #DEFAULT_HTTP_ENCODING} if that is not defined.
77+
* with a default of DEFAULT_HTTP_ENCODING if that is not defined.
7378
*/
7479
protected static final String DEFAULT_ENCODING
7580
= JMeterUtils.getPropDefault("sampleresult.default.encoding", // $NON-NLS-1$

xdocs/changes.xml

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,41 @@ Summary
6969
Timer relative to start of Thread Group instead of the start of the test.</li>
7070
<li><issue>6357</issue><pr>6358</pr> Ensure writable directories when copying template files while report generation.</li>
7171
</ul>
72+
<ch_section>New and Noteworthy</ch_section>
73+
74+
<ch_section>Improvements</ch_section>
75+
76+
<h3>HTTP Samplers and Test Script Recorder</h3>
77+
<ul>
78+
<li><pr>6010</pr>Use UTF-8 as a default encoding in HTTP sampler. It enables sending parameter names, and filenames with unicode characters</li>
79+
<li><pr>6010</pr>Test Recorder will use UTF-8 encoding by default, so it will infer human-readable arguments rather than percent-encoded ones</li>
80+
</ul>
81+
82+
<ch_section>Non-functional changes</ch_section>
83+
<ul>
84+
<li><pr>6000</pr>Add release-drafter for populating GitHub releases info based on the merged PRs</li>
85+
<li><pr>5989</pr>Use Gradle toolchains for JDK provisioning, enable building and testing with different JDKs, start testing with Java 21</li>
86+
<li><pr>5991</pr>Update jackson-core, jackson-databind, jackson-annotations to 2.15.2 (from 2.15.1)</li>
87+
<li><pr>5993</pr>Update ph-commons to 10.2.5 (from 10.2.4)</li>
88+
<li><pr>6017</pr>Update kotlin-stdlib to 1.8.22 (from 1.8.21)</li>
89+
<li><pr>6020</pr>Update error_prone_annotations to 2.20.0 (from 2.19.1)</li>
90+
<li><pr>6023</pr>Update checker-qual to 3.35.0 (from 3.34.0)</li>
91+
</ul>
92+
93+
<!-- =================== Bug fixes =================== -->
94+
95+
<ch_section>Bug fixes</ch_section>
96+
97+
<h3>Thread Groups</h3>
98+
<ul>
99+
<li><pr>6011</pr>Regression since 5.6: ThreadGroups are running endlessly in non-gui mode: use default value
100+
for LoopController.continue_forever rather than initializing it in the constructor</li>
101+
</ul>
102+
103+
<h3>Other Samplers</h3>
104+
<ul>
105+
<li><pr>6012</pr> Java Request sampler cannot be enabled again after disabling in UI (regression since 5.6)</li>
106+
</ul>
72107

73108
<!-- =================== Thanks =================== -->
74109

xdocs/usermanual/properties_reference.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1399,7 +1399,7 @@ JMETER-SERVER</source>
13991399
</property>
14001400
<property name="sampleresult.default.encoding">
14011401
The encoding to be used if none is provided.<br/>
1402-
Defaults to: <code>UTF-8</code> (since 5.6.1)
1402+
Defaults to: <code>ISO-8859-1</code>
14031403
</property>
14041404
<property name="CookieManager.delete_null_cookies">
14051405
CookieManager behaviour - should cookies with null/empty values be deleted?<br/>

0 commit comments

Comments
 (0)