Skip to content

Commit 471a9ff

Browse files
committed
Skip checking empty filenames for result collectors
On Java 25 the semantic of checking existance for empty filenames has been changed. See https://bugs.openjdk.org/browse/JDK-8024695 The old behaviour was used in JMeter to skip empty filenames in result collectors. This patch should resolve the bug while maintaining backwards compatibility. This should fix #6611.
1 parent 18d8cb3 commit 471a9ff

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

src/core/src/main/java/org/apache/jmeter/gui/action/AbstractAction.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,10 @@ protected boolean popupCheckExistingFileListener(HashTree tree) {
8989
SearchByClass<ResultCollector> resultListeners = new SearchByClass<>(ResultCollector.class);
9090
tree.traverse(resultListeners);
9191
for (ResultCollector rc : resultListeners.getSearchResults()) {
92+
if ("".equals(rc.getFilename())) {
93+
log.debug("Skip result collector ({}) as it has empty filename", rc.getName());
94+
continue;
95+
}
9296
File f = new File(rc.getFilename());
9397
if (f.exists()) {
9498
switch (actionOnFile) {

xdocs/changes.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ Summary
5858
</p>
5959
<ul>
6060
<li><a href="#Changes">Changes</a></li>
61+
<li><a href="#Bug fixes">Bug fixes</a></li>
6162
</ul>
6263

6364
<ch_section>Changes</ch_section>
@@ -76,6 +77,11 @@ Summary
7677
<li><pr>5891</pr>Skip Internet Explorer 6-9 conditional comment processing when fetching resource links</li>
7778
</ul>
7879

80+
<ch_section>Bug fixes</ch_section>
81+
<h3>General</h3>
82+
<ul>
83+
<li><pr>6654</pr><issue>6611</issue>Support JDK 25 and above for result collectors with empty file names</li>
84+
</ul>
7985
<!-- =================== Thanks =================== -->
8086

8187
<ch_section>Thanks</ch_section>

0 commit comments

Comments
 (0)