Skip to content

Commit 2c17f5d

Browse files
committed
test: JUnit5 does not execute static test methods, so revert static modifiers
1 parent 7a729c5 commit 2c17f5d

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricFixedModeTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ public void checkResetKoAndAllStats() throws Exception {
7878
}
7979

8080
@Test
81-
public static void checkErrorsDetailStat() {
81+
public void checkErrorsDetailStat() {
8282
SamplerMetric metric = new SamplerMetric();
8383
metric.add(createSampleResult("400", "bad request"));
8484
metric.add(createSampleResult("400", "Bad Request "));
@@ -124,7 +124,7 @@ private static SampleResult createSampleResultWithSubresults(boolean success) {
124124
}
125125

126126
@Test
127-
public static void checkAddCumulatedOk() throws Exception {
127+
public void checkAddCumulatedOk() throws Exception {
128128
SamplerMetric metric = new SamplerMetric();
129129
SampleResult sample = createSampleResultWithSubresults(true);
130130
assertEquals(true, TransactionController.isFromTransactionController(sample), "We are recognized as a TransactionController made sample");
@@ -145,7 +145,7 @@ public static void checkAddCumulatedOk() throws Exception {
145145
}
146146

147147
@Test
148-
public static void checkAddCumulatedKo() throws Exception {
148+
public void checkAddCumulatedKo() throws Exception {
149149
SamplerMetric metric = new SamplerMetric();
150150
SampleResult sample = createSampleResultWithSubresults(false);
151151
assertEquals(true, TransactionController.isFromTransactionController(sample), "We are recognized as a TransactionController made sample");

src/components/src/test/java/org/apache/jmeter/visualizers/backend/SamplerMetricTimedModeTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ private static SampleResult createSampleResultWithSubresults(boolean success) {
106106
}
107107

108108
@Test
109-
public static void checkAddCumulatedOk() throws Exception {
109+
public void checkAddCumulatedOk() throws Exception {
110110
SamplerMetric metric = new SamplerMetric();
111111
SampleResult sample = createSampleResultWithSubresults(true);
112112
assertEquals(true, TransactionController.isFromTransactionController(sample), "We are recognized as a TransactionController made sample");
@@ -127,7 +127,7 @@ public static void checkAddCumulatedOk() throws Exception {
127127
}
128128

129129
@Test
130-
public static void checkAddCumulatedKo() throws Exception {
130+
public void checkAddCumulatedKo() throws Exception {
131131
SamplerMetric metric = new SamplerMetric();
132132
SampleResult sample = createSampleResultWithSubresults(false);
133133
assertEquals(true, TransactionController.isFromTransactionController(sample), "We are recognized as a TransactionController made sample");

0 commit comments

Comments
 (0)