Skip to content

Commit 09d8744

Browse files
dlwldnjs1009vlsi
authored andcommitted
Remove NestedForDepth Checkstyle rule
The rule has led to patterns like `stream().forEach()` in test parameter generation where plain nested loops would be clearer. Remove the rule and drop the stale `NestedForDepth` comment in `TestDecompression`. Fixes #6665
1 parent f8bf969 commit 09d8744

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

config/checkstyle/checkstyle.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@
118118
<module name="IllegalThrows"/>
119119
<module name="ModifiedControlVariable"/>
120120
<module name="MultipleVariableDeclarations"/>
121-
<module name="NestedForDepth"/>
121+
122122
<module name="NestedIfDepth">
123123
<!-- TODO: reduce this number -->
124124
<property name="max" value="4"/>

src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/sampler/TestDecompression.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ enum ServerGzip {
5353

5454
public static List<Arguments> mockServerParams() {
5555
List<Arguments> res = new ArrayList<>();
56-
// Nested for depth is 2 (max allowed is 1). [NestedForDepth]
5756
Arrays.stream(HTTPSamplerFactory.getImplementations()).forEach(httpImpl -> {
5857
for (ClientGzip clientGzip : ClientGzip.values()) {
5958
for (ServerGzip serverGzip : ServerGzip.values()) {

0 commit comments

Comments
 (0)