IGNITE-28377 Removed lazy flag of SqlFieldsQuery (#12947)

Author: NSAmelchev

docs/_docs/SQL/JDBC/jdbc-driver.adoc

@@ -162,7 +162,6 @@ For the list of security parameters, refer to the <<Using SSL>> section.
 - `jdbc:ignite:thin://myHost:11900;user=ignite;password=ignite` - connect to myHost on custom port 11900 with user credentials for authentication.
 - `jdbc:ignite:thin://myHost:11900;distributedJoins=true&autoCloseServerCursor=true` - connect to myHost on custom port 11900 with enabled distributed joins and autoCloseServerCursor optimization.
 - `jdbc:ignite:thin://myHost:11900/myschema;` - connect to myHost on custom port 11900 and access to MYSCHEMA.
-- `jdbc:ignite:thin://myHost:11900/"MySchema";lazy=false` - connect to myHost on custom port 11900 with disabled lazy query execution and access to MySchema (schema name is case sensitive).
 
 === Multiple Endpoints
 
@@ -676,21 +675,3 @@ The table below lists all the link:https://en.wikipedia.org/wiki/SQLSTATE[ANSI S
 |50000| Internal error.
 The code is not defined by ANSI and refers to an Ignite specific error. Refer to the `java.sql.SQLException` error message for more information.
 |=======================================================================
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-

docs/_docs/SQL/sql-tuning.adoc

@@ -52,43 +52,10 @@ Avoid having too many columns in the result set of a `SELECT` query. Due to limi
 
 == Lazy Loading
 
-By default, Ignite attempts to load the whole result set to memory and send it back to the query initiator (which is usually your application).
-This approach provides optimal performance for queries of small or medium result sets.
-However, if the result set is too big to fit in the available memory, it can lead to prolonged GC pauses and even `OutOfMemoryError` exceptions.
-
-To minimize memory consumption, at the cost of a moderate performance hit, you can load and process the result sets lazily by passing the `lazy` parameter to the JDBC and ODBC connection strings or use a similar method available for Java, .NET, and C++ APIs:
-
-[tabs]
---
-
-tab:Java[]
-[source,java]
-----
-SqlFieldsQuery query = new SqlFieldsQuery("SELECT * FROM Person WHERE id > 10");
-
-// Result set will be loaded lazily.
-query.setLazy(true);
-----
-tab:JDBC[]
-[source,sql]
-----
-jdbc:ignite:thin://192.168.0.15?lazy=true
-----
-tab:C#/.NET[]
-[source,csharp]
-----
-var query = new SqlFieldsQuery("SELECT * FROM Person WHERE id > 10")
-{
-    // Result set will be loaded lazily.
-    Lazy = true
-};
-----
-tab:C++[]
---
-
-////
-*TODO* Add tabs for ODBC and other programming languages - C# and C++
-////
+Ignite always operates in lazy loading mode. Query results are not loaded entirely into memory when possible. Data
+is streamed to the client in pages as the result set is iterated. The page size determines how many rows are fetched
+per network round trip, allowing you to balance memory consumption and performance and eliminating the risk of
+prolonged GC pauses and `OutOfMemoryError` exceptions for large result sets.
 
 == Querying Colocated Data
 

docs/_docs/binary-client-protocol/sql-and-scan-queries.adoc

@@ -267,7 +267,7 @@ UPDATE = 2
 |bool|    Replicated only - Whether query contains only replicated tables or not.
 |bool|    Enforce join order.
 |bool|    Collocated - Whether your data is co-located or not.
-|bool|    Lazy query execution.
+|bool|    [Deprecated] Lazy query execution. This flag is not used anymore on server side.
 |long|    Timeout (milliseconds).
 |bool|    Include field names.
 |===
@@ -355,7 +355,7 @@ out.writeBoolean(false);
 out.writeBoolean(false);
 
 // Lazy
-out.writeBoolean(false);
+out.writeBoolean(true);
 
 // Timeout
 writeLongLittleEndian(5000, out);
@@ -631,4 +631,3 @@ readResponseHeader(in);
 ----
 
 --
-

docs/_docs/perf-and-troubleshooting/sql-tuning.adoc

@@ -78,45 +78,10 @@ with 100+ columns may perform worse than expected.
 
 == Lazy Loading
 
-By default, Ignite will set Lazy Loading enabled, this will minimize memory consumption at the cost of moderate performance degradation.
-
-Otherwise, Ignite attempts to load the whole result set to memory and send it back to the query initiator (which is usually your application). This approach provides optimal performance for queries of small or medium result sets, and minimizes the duration of internal database locks, thus increasing concurrency. 
-
-WARNING, if the result set is too big to fit in the available memory, it can lead to prolonged GC pauses and even `OutOfMemoryError` exceptions. This property is deprecated since Ignite 2.15.0.
-
-To change the default behavior: 
-
-[tabs]
---
-
-tab:Java[]
-[source,java]
-----
-SqlFieldsQuery query = new SqlFieldsQuery("SELECT * FROM Person WHERE id > 10");
-
-// Result set will be loaded eagerly.
-query.setLazy(false);
-----
-tab:JDBC[]
-[source,sql]
-----
-jdbc:ignite:thin://192.168.0.15?lazy=false
-----
-tab:C#/.NET[]
-[source,csharp]
-----
-var query = new SqlFieldsQuery("SELECT * FROM Person WHERE id > 10")
-{
-    // Result set will be loaded eagerly.
-    Lazy = false
-};
-----
-tab:C++[]
---
-
-////
-*TODO* Add tabs for ODBC and other programming languages - C# and C++
-////
+Ignite always operates in lazy loading mode. Query results are not loaded entirely into memory when possible. Data
+is streamed to the client in pages as the result set is iterated. The page size determines how many rows are fetched
+per network round trip, allowing you to balance memory consumption and performance and eliminating the risk of
+prolonged GC pauses and `OutOfMemoryError` exceptions for large result sets.
 
 == Querying Colocated Data
 

docs/_docs/thin-clients/python-thin-client.adoc

@@ -422,7 +422,6 @@ The `sql()` method supports a number of parameters that
 | `replicated_only` |
 | `enforce_join_order` |
 | `collocated` |
-| `lazy` |
 | `include_field_names` |
 | `max_rows` |
 | `timeout` |
@@ -485,4 +484,3 @@ If you still want to use authentication without securing the connection, simply
 ----
 include::{sourceFileDir}/auth.py[tag=no-ssl,indent=0]
 ----
-

modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/QueryRegistryImpl.java

@@ -58,7 +58,7 @@ public QueryRegistryImpl(GridKernalContext ctx) {
             RunningQueryManager qryMgr = kctx.query().runningQueryManager();
 
             long locId = qryMgr.register(rootQry.sql(), GridCacheQueryType.SQL_FIELDS, rootQry.context().schemaName(),
-                false, createCancelToken(qry), rootQry.initiatorId(), false, true, false);
+                false, createCancelToken(qry), rootQry.initiatorId(), false, false);
 
             rootQry.localQueryId(locId);
 

modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/ExecutionServiceImpl.java

@@ -563,7 +563,7 @@ private FieldsQueryCursor<List<?>> executeDdl(RootQuery<Row> qry, DdlPlan plan)
         }
         else {
             QueryCursorImpl<List<?>> resCur = new QueryCursorImpl<>(Collections.singletonList(
-                Collections.singletonList(0L)), null, false, false);
+                Collections.singletonList(0L)), null, false);
 
             IgniteTypeFactory typeFactory = qry.context().typeFactory();
 

modules/clients/src/test/java/org/apache/ignite/common/RunningQueryInfoCheckInitiatorTest.java

@@ -19,6 +19,7 @@
 
 import java.sql.Connection;
 import java.sql.DriverManager;
+import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Statement;
 import java.util.List;
@@ -27,7 +28,6 @@
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Consumer;
 import java.util.regex.Pattern;
-
 import org.apache.ignite.Ignite;
 import org.apache.ignite.Ignition;
 import org.apache.ignite.cache.query.FieldsQueryCursor;
@@ -227,10 +227,16 @@ public void testJdbcV2InitiatorId() throws Exception {
             final UUID grid0NodeId = grid(0).cluster().localNode().id();
 
             GridTestUtils.runAsync(() -> {
-                    try (Connection conn = DriverManager.getConnection(CFG_URL_PREFIX + "lazy=false:nodeId="
+                    try (Connection conn = DriverManager.getConnection(CFG_URL_PREFIX + "nodeId="
                         + grid0NodeId + "@modules/clients/src/test/config/jdbc-security-config.xml")) {
                         try (Statement stmt = conn.createStatement()) {
                             stmt.execute(sql);
+
+                            ResultSet rs = stmt.getResultSet();
+
+                            while (rs != null && rs.next()) {
+                                // No-op.
+                            }
                         }
                     }
                     catch (SQLException e) {

modules/clients/src/test/java/org/apache/ignite/internal/jdbc2/JdbcConnectionSelfTest.java

@@ -31,7 +31,6 @@
 import org.junit.Test;
 
 import static org.apache.ignite.IgniteJdbcDriver.CFG_URL_PREFIX;
-import static org.apache.ignite.cache.query.SqlFieldsQuery.DFLT_LAZY;
 
 /**
  * Connection test.
@@ -270,7 +269,6 @@ public void testSqlHints() throws Exception {
             assertTrue(((JdbcConnection)conn).isEnforceJoinOrder());
             assertFalse(((JdbcConnection)conn).isDistributedJoins());
             assertFalse(((JdbcConnection)conn).isCollocatedQuery());
-            assertEquals(DFLT_LAZY, ((JdbcConnection)conn).isLazy());
             assertFalse(((JdbcConnection)conn).skipReducerOnUpdate());
         }
 
@@ -279,7 +277,6 @@ public void testSqlHints() throws Exception {
             assertFalse(((JdbcConnection)conn).isEnforceJoinOrder());
             assertTrue(((JdbcConnection)conn).isDistributedJoins());
             assertFalse(((JdbcConnection)conn).isCollocatedQuery());
-            assertEquals(DFLT_LAZY, ((JdbcConnection)conn).isLazy());
             assertFalse(((JdbcConnection)conn).skipReducerOnUpdate());
         }
 
@@ -288,23 +285,14 @@ public void testSqlHints() throws Exception {
             assertFalse(((JdbcConnection)conn).isEnforceJoinOrder());
             assertFalse(((JdbcConnection)conn).isDistributedJoins());
             assertTrue(((JdbcConnection)conn).isCollocatedQuery());
-            assertEquals(DFLT_LAZY, ((JdbcConnection)conn).isLazy());
             assertFalse(((JdbcConnection)conn).skipReducerOnUpdate());
         }
 
-        try (final Connection conn = DriverManager.getConnection(CFG_URL_PREFIX + "lazy=" + (!DFLT_LAZY) + "@" + configURL())) {
-            assertFalse(((JdbcConnection)conn).isEnforceJoinOrder());
-            assertFalse(((JdbcConnection)conn).isDistributedJoins());
-            assertFalse(((JdbcConnection)conn).isCollocatedQuery());
-            assertEquals(!DFLT_LAZY, ((JdbcConnection)conn).isLazy());
-            assertFalse(((JdbcConnection)conn).skipReducerOnUpdate());
-        }
         try (final Connection conn = DriverManager.getConnection(CFG_URL_PREFIX + "skipReducerOnUpdate=true@"
             + configURL())) {
             assertFalse(((JdbcConnection)conn).isEnforceJoinOrder());
             assertFalse(((JdbcConnection)conn).isDistributedJoins());
             assertFalse(((JdbcConnection)conn).isCollocatedQuery());
-            assertEquals(DFLT_LAZY, ((JdbcConnection)conn).isLazy());
             assertTrue(((JdbcConnection)conn).skipReducerOnUpdate());
         }
     }