[FLUSS #558] [test] Add Rust integration coverage for RecordBatchLogReader bounded reads.#559
Open
slfan1989 wants to merge 1 commit into
Open
[FLUSS #558] [test] Add Rust integration coverage for RecordBatchLogReader bounded reads.#559slfan1989 wants to merge 1 commit into
slfan1989 wants to merge 1 commit into
Conversation
…chLogReader bounded reads.
Author
|
@fresh-borzoni @leekeiabstraction Could you please help review this PR when you have time? |
Member
There was a problem hiding this comment.
@slfan1989 Ty for the PR, great addition, LGTM overall, couple of minor comments 👍
Let's move this to a separate file for testing RecordBatchLogReader feature and then add some additional scenarios:
*until_offsets_with_empty_range (stop == start -> no batches)
- until_offsets_past_end_of_log (graceful finish past actual end)
- until_offsets_multi_bucket (multiple buckets in the HashMap)
also extract_ids_from_batches overlaps with extract_ids in test_project test, mb we wish to factor this out to utils and reuse.
Member
|
@charlesdong1991 Can you also take a look, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #558
Add Rust-level integration coverage for
RecordBatchLogReaderbounded reads.RecordBatchLogReaderalready has unit coverage for batch filtering and Python binding coverage forto_arrow_batch_readerguard/drop behavior, but it lacks Rust end-to-end integration coverage for:new_until_offsetsstopping semanticsnew_until_latestwith partitioned log tablesThis PR adds those missing integration tests.
Brief change log
Added a Rust integration test for
RecordBatchLogReader::new_until_offsets.Added a Rust integration test for
RecordBatchLogReader::new_until_lateston partitioned tables.USandEUpartitions.Updated the comment in
RecordBatchLogReaderto point to the new Rust integration coverage.Tests
Verified locally.
API and Format
No API or storage format changes.
Documentation
No user-facing documentation changes.