Skip to content

Commit b0de5fa

Browse files
aman-ak-rnickva
authored andcommitted
Fix Credo 1.7.14 ExpensiveEmptyEnumCheck warnings
Replace expensive length/1 checks with Enum.empty?/1 in test files to resolve Credo warnings introduced in version 1.7.14. Changes: - test/elixir/test/replication_test.exs: Replace length(list) > 0 - test/elixir/lib/couch/dbtest.ex: Replace length(list) > 0 - test/elixir/test/partition_size_limit_test.exs: Replace length(list) > 0 - test/elixir/test/basics_test.exs: Replace length(list) >= 1 These changes are semantically equivalent but more performant as Enum.empty?/1 only checks for the first element instead of traversing the entire list. Fixes #5799
1 parent f7938ae commit b0de5fa

4 files changed

Lines changed: 4 additions & 4 deletions

File tree

test/elixir/lib/couch/dbtest.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ defmodule Couch.DBTest do
196196
query: [feed: "longpoll", timeout: 5000, filter: "_design"]
197197
)
198198
results = resp.body["results"]
199-
is_list(results) && length(results) > 0
199+
is_list(results) && not Enum.empty?(results)
200200
end, 500, 60_000)
201201
end
202202

test/elixir/test/basics_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ defmodule BasicsTest do
6464
db_count = length(Couch.get("/_all_dbs").body)
6565
assert db_count > 0
6666
assert Couch.get("/_all_dbs?limit=0").body == []
67-
assert length(Couch.get("/_all_dbs?limit=1").body) >= 1
67+
assert not Enum.empty?(Couch.get("/_all_dbs?limit=1").body)
6868
assert length(Couch.get("/_all_dbs?skip=1").body) == (db_count - 1)
6969
assert [db] == Couch.get("/_all_dbs?start_key=\"#{db}\"&limit=1").body
7070
end

test/elixir/test/partition_size_limit_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ defmodule PartitionSizeLimitTest do
228228
assert resp.status_code in [200, 202]
229229
%{body: body} = resp
230230

231-
assert length(body["rows"]) > 0
231+
assert not Enum.empty?(body["rows"])
232232
end
233233

234234
test "purging docs allows writes", context do

test/elixir/test/replication_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1671,7 +1671,7 @@ defmodule ReplicationTest do
16711671
revs_checked = task["revisions_checked"]
16721672
changes = get_db_changes(src_db_name, %{:since => through_seq})
16731673

1674-
if length(changes["results"]) > 0 or revs_checked < expect_revs_checked do
1674+
if not Enum.empty?(changes["results"]) or revs_checked < expect_revs_checked do
16751675
:timer.sleep(500)
16761676
wait_for_repl(src_db_name, repl_id, expect_revs_checked, wait_left - 500)
16771677
end

0 commit comments

Comments
 (0)