[ErrorProne] Fix FormatStringShouldUsePlaceholders string concat when Preconditions is used (#37745)

Author: stankiewicz

runners/flink/src/main/java/org/apache/beam/runners/flink/adapter/BeamFlinkDataStreamAdapter.java

@@ -228,7 +228,8 @@ FlinkInput.URN, flinkInputTranslator(flinkInputs),
       DataStream<InputT> flinkInput =
           Preconditions.checkStateNotNull(
               (DataStream<InputT>) inputMap.get(inputId),
-              "missing input referenced in proto: " + inputId);
+              "missing input referenced in proto: %s",
+              inputId);
       context.addDataStream(
           Iterables.getOnlyElement(transform.getOutputsMap().values()),
           flinkInput.process(

runners/flink/src/main/java/org/apache/beam/runners/flink/translation/functions/FlinkSideInputReader.java

@@ -74,7 +74,7 @@ public FlinkSideInputReader(
   public <T> @Nullable T get(PCollectionView<T> view, BoundedWindow window) {
     checkNotNull(view, "View passed to sideInput cannot be null");
     TupleTag<?> tag = view.getTagInternal();
-    checkNotNull(sideInputs.get(tag), "Side input for " + view + " not available.");
+    checkNotNull(sideInputs.get(tag), "Side input for %s not available.", view);
 
     Map<BoundedWindow, T> sideInputs =
         runtimeContext.getBroadcastVariableWithInitializer(

runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/state/RangeCoder.java

@@ -54,9 +54,9 @@ public void verifyDeterministic() throws NonDeterministicException {
   @Override
   public void encode(Range<T> value, OutputStream outStream) throws IOException {
     Preconditions.checkState(
-        value.lowerBoundType().equals(BoundType.CLOSED), "unexpected range " + value);
+        value.lowerBoundType().equals(BoundType.CLOSED), "unexpected range %s", value);
     Preconditions.checkState(
-        value.upperBoundType().equals(BoundType.OPEN), "unexpected range " + value);
+        value.upperBoundType().equals(BoundType.OPEN), "unexpected range %s", value);
     boundCoder.encode(value.hasLowerBound() ? value.lowerEndpoint() : null, outStream);
     boundCoder.encode(value.hasUpperBound() ? value.upperEndpoint() : null, outStream);
   }

runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/ReferenceCountingExecutableStageContextFactory.java

@@ -115,7 +115,7 @@ public ExecutableStageContext get(JobInfo jobInfo) {
   private void scheduleRelease(JobInfo jobInfo) {
     WrappedContext wrapper = getCache().get(jobInfo.jobId());
     Preconditions.checkState(
-        wrapper != null, "Releasing context for unknown job: " + jobInfo.jobId());
+        wrapper != null, "Releasing context for unknown job %s", jobInfo.jobId());
 
     PipelineOptions pipelineOptions =
         PipelineOptionsTranslation.fromProto(jobInfo.pipelineOptions());

runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismLocator.java

@@ -242,7 +242,7 @@ private static String userHome() {
   }
 
   private static String mustGetPropertyAsLowerCase(String name) {
-    return checkStateNotNull(System.getProperty(name), "System property: " + name + " not set")
+    return checkStateNotNull(System.getProperty(name), "System property: %s not set", name)
         .toLowerCase();
   }
 

sdks/java/core/src/main/java/org/apache/beam/sdk/coders/BigDecimalCoder.java

@@ -55,7 +55,7 @@ public void encode(BigDecimal value, OutputStream outStream) throws IOException,
   @Override
   public void encode(BigDecimal value, OutputStream outStream, Context context)
       throws IOException, CoderException {
-    checkNotNull(value, String.format("cannot encode a null %s", BigDecimal.class.getSimpleName()));
+    checkNotNull(value);
     VAR_INT_CODER.encode(value.scale(), outStream);
     BIG_INT_CODER.encode(value.unscaledValue(), outStream, context);
   }
@@ -108,7 +108,7 @@ public boolean isRegisterByteSizeObserverCheap(BigDecimal value) {
    */
   @Override
   protected long getEncodedElementByteSize(BigDecimal value) throws Exception {
-    checkNotNull(value, String.format("cannot encode a null %s", BigDecimal.class.getSimpleName()));
+    checkNotNull(value);
     return VAR_INT_CODER.getEncodedElementByteSize(value.scale())
         + BIG_INT_CODER.getEncodedElementByteSize(value.unscaledValue());
   }

sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/AutoValueSchema.java

@@ -79,12 +79,10 @@ private static void validateFieldNumbers(List<FieldValueTypeInformation> types)
       }
       Preconditions.checkState(
           number == i,
-          "Expected field number "
-              + i
-              + " for field + "
-              + type.getName()
-              + " instead got "
-              + number);
+          "Expected field number %s for field %s instead got %s",
+          i,
+          type.getName(),
+          number);
     }
   }
 

sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/JavaBeanSchema.java

@@ -81,12 +81,10 @@ private static void validateFieldNumbers(List<FieldValueTypeInformation> types)
         }
         Preconditions.checkState(
             number == i,
-            "Expected field number "
-                + i
-                + " for field: "
-                + type.getName()
-                + " instead got "
-                + number);
+            "Expected field number %s for field %s instead got %s",
+            i,
+            type.getName(),
+            number);
       }
     }
 

sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/JavaFieldSchema.java

@@ -103,12 +103,10 @@ private static void validateFieldNumbers(List<FieldValueTypeInformation> types)
       }
       Preconditions.checkState(
           number == i,
-          "Expected field number "
-              + i
-              + " for field + "
-              + type.getName()
-              + " instead got "
-              + number);
+          "Expected field number %s for field %s instead got %s",
+          i,
+          type.getName(),
+          number);
     }
   }
 

sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFnOutputReceivers.java

@@ -169,7 +169,8 @@ public <T> OutputReceiver<Row> getRowReceiver(TupleTag<T> tag) {
       checkStateNotNull(outputCoder, "No output tag for %s ", tag);
       checkState(
           outputCoder instanceof SchemaCoder,
-          "Output with tag " + tag + " must have a schema in order to call getRowReceiver");
+          "Output with tag %s must have a schema in order to call getRowReceiver",
+          tag);
       return DoFnOutputReceivers.rowReceiver(
           context, builderSupplier, tag, (SchemaCoder<T>) outputCoder);
     }