Skip to content

Commit b3d2b06

Browse files
authored
[ErrorProne] Fix UnnecessaryMethodReference Check Findings (#37785)
1 parent 2209bd6 commit b3d2b06

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1557,7 +1557,6 @@ class BeamModulePlugin implements Plugin<Project> {
15571557
"TimeUnitConversionChecker",
15581558
"UndefinedEquals",
15591559
"UnescapedEntity",
1560-
"UnnecessaryMethodReference",
15611560
"UnnecessaryParentheses",
15621561
"UnrecognisedJavadocTag",
15631562
// errorprone 3.2.0+ checks

sdks/java/core/src/test/java/org/apache/beam/sdk/io/TextIOWriteTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -319,21 +319,21 @@ public void testDynamicDefaultFilenamePolicy() throws Exception {
319319

320320
Iterable<String> aElements =
321321
elements.stream()
322-
.filter(Predicates.compose(new StartsWith("a"), new ExtractWriteDestination())::apply)
322+
.filter(Predicates.compose(new StartsWith("a"), new ExtractWriteDestination()))
323323
.collect(Collectors.toList())
324324
.stream()
325325
.map(Functions.toStringFunction())
326326
.collect(Collectors.toList());
327327
Iterable<String> bElements =
328328
elements.stream()
329-
.filter(Predicates.compose(new StartsWith("b"), new ExtractWriteDestination())::apply)
329+
.filter(Predicates.compose(new StartsWith("b"), new ExtractWriteDestination()))
330330
.collect(Collectors.toList())
331331
.stream()
332332
.map(Functions.toStringFunction())
333333
.collect(Collectors.toList());
334334
Iterable<String> cElements =
335335
elements.stream()
336-
.filter(Predicates.compose(new StartsWith("c"), new ExtractWriteDestination())::apply)
336+
.filter(Predicates.compose(new StartsWith("c"), new ExtractWriteDestination()))
337337
.collect(Collectors.toList())
338338
.stream()
339339
.map(Functions.toStringFunction())

sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,11 @@ void startBundle() {
123123
}
124124

125125
void processElement(WindowedValue<KV<KeyT, InputT>> elem) throws Exception {
126-
getGroupingTable().put(elem, output::accept);
126+
getGroupingTable().put(elem, output);
127127
}
128128

129129
void finishBundle() throws Exception {
130-
getGroupingTable().flush(output::accept);
130+
getGroupingTable().flush(output);
131131
groupingTable = null;
132132
}
133133
}

0 commit comments

Comments
 (0)