Merge pull request #37792: [ErrorProne] Fix AutoValueBoxedValues warnings across the codebase

Author: stankiewicz

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

@@ -1578,7 +1578,6 @@ class BeamModulePlugin implements Plugin<Project> {
             "UnnecessaryLongToIntConversion",
             "UnusedVariable",
             // intended suppressions emerged in newer protobuf versions
-            "AutoValueBoxedValues",
             // For backward compatibility. Public method checked in before this check impl
             // Possible use in interface subclasses
             "ClassInitializationDeadlock",

examples/java/src/main/java/org/apache/beam/examples/complete/datatokenization/utils/CsvConverters.java

@@ -435,7 +435,7 @@ public static Builder newBuilder() {
     @Nullable
     public abstract String delimiter();
 
-    public abstract Boolean hasHeaders();
+    public abstract boolean hasHeaders();
 
     public abstract String inputFileSpec();
 
@@ -468,7 +468,7 @@ public abstract static class Builder {
 
       public abstract Builder setDelimiter(@Nullable String delimiter);
 
-      public abstract Builder setHasHeaders(Boolean hasHeaders);
+      public abstract Builder setHasHeaders(boolean hasHeaders);
 
       public abstract Builder setInputFileSpec(String inputFileSpec);
 
@@ -486,8 +486,6 @@ public ReadCsv build() {
 
         checkArgument(readCsv.csvFormat() != null, "Csv format must not be null.");
 
-        checkArgument(readCsv.hasHeaders() != null, "Header information must be provided.");
-
         return readCsv;
       }
     }

it/clickhouse/src/main/java/org/apache/beam/it/clickhouse/conditions/ClickHouseRowsCheck.java

@@ -30,7 +30,7 @@ public abstract class ClickHouseRowsCheck extends ConditionCheck {
 
   abstract String table();
 
-  abstract Integer minRows();
+  abstract int minRows();
 
   abstract @Nullable Integer maxRows();
 
@@ -85,7 +85,7 @@ public abstract static class Builder {
 
     public abstract Builder setTable(String table);
 
-    public abstract Builder setMinRows(Integer minRows);
+    public abstract Builder setMinRows(int minRows);
 
     public abstract Builder setMaxRows(Integer maxRows);
 

it/datadog/src/main/java/org/apache/beam/it/datadog/conditions/DatadogLogEntriesCheck.java

@@ -28,7 +28,7 @@ public abstract class DatadogLogEntriesCheck extends ConditionCheck {
 
   abstract DatadogResourceManager resourceManager();
 
-  abstract Integer minEntries();
+  abstract int minEntries();
 
   @Nullable
   abstract Integer maxEntries();
@@ -78,7 +78,7 @@ public abstract static class Builder {
 
     public abstract Builder setResourceManager(DatadogResourceManager resourceManager);
 
-    public abstract Builder setMinEntries(Integer minEvents);
+    public abstract Builder setMinEntries(int minEvents);
 
     public abstract Builder setMaxEntries(Integer maxEvents);
 

it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/bigquery/conditions/BigQueryRowsCheck.java

@@ -31,7 +31,7 @@ public abstract class BigQueryRowsCheck extends ConditionCheck {
 
   abstract TableId tableId();
 
-  abstract Integer minRows();
+  abstract int minRows();
 
   abstract @Nullable Integer maxRows();
 
@@ -87,7 +87,7 @@ public abstract static class Builder {
 
     public abstract Builder setTableId(TableId tableId);
 
-    public abstract Builder setMinRows(Integer minRows);
+    public abstract Builder setMinRows(int minRows);
 
     public abstract Builder setMaxRows(Integer maxRows);
 

it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/pubsub/conditions/PubsubMessagesCheck.java

@@ -36,7 +36,7 @@ public abstract class PubsubMessagesCheck extends ConditionCheck {
 
   abstract SubscriptionName subscription();
 
-  abstract Integer minMessages();
+  abstract int minMessages();
 
   abstract @Nullable Integer maxMessages();
 
@@ -104,7 +104,7 @@ public abstract static class Builder {
 
     public abstract Builder setSubscription(SubscriptionName subscription);
 
-    public abstract Builder setMinMessages(Integer minMessages);
+    public abstract Builder setMinMessages(int minMessages);
 
     public abstract Builder setMaxMessages(Integer maxMessages);
 

it/google-cloud-platform/src/test/java/org/apache/beam/it/gcp/bigquery/BigQueryStreamingLT.java

@@ -160,18 +160,18 @@ public static void cleanup() {
   @AutoValue
   abstract static class TestConfiguration {
     /** Rows will be generated for this many minutes. */
-    abstract Integer getMinutes();
+    abstract int getMinutes();
 
     /** Data shape: The byte-size for each field. */
-    abstract Integer getByteSizePerField();
+    abstract int getByteSizePerField();
 
     /** Data shape: The number of fields per row. */
-    abstract Integer getNumFields();
+    abstract int getNumFields();
 
     /**
      * Rate of generated elements sent to the sink. Will run with a minimum of 1k rows per second.
      */
-    abstract Integer getRowsPerSecond();
+    abstract int getRowsPerSecond();
 
     abstract String getRunner();
 

it/google-cloud-platform/src/test/java/org/apache/beam/it/gcp/bigtable/BigTableIOLT.java

@@ -142,7 +142,7 @@ public void testBigtableWriteAndRead() throws IOException {
             region,
             readInfo.jobId(),
             getBeamMetricsName(PipelineMetricsType.COUNTER, READ_ELEMENT_METRIC_NAME));
-    assertEquals(configuration.getNumRows(), numRecords, 0.5);
+    assertEquals((double) configuration.getNumRows(), numRecords, 0.5);
 
     // export metrics
     MetricsConfiguration metricsConfig =
@@ -214,13 +214,13 @@ private PipelineLauncher.LaunchInfo testRead() throws IOException {
   /** Options for BigtableIO load test. */
   @AutoValue
   abstract static class Configuration {
-    abstract Long getNumRows();
+    abstract long getNumRows();
 
-    abstract Integer getPipelineTimeout();
+    abstract int getPipelineTimeout();
 
     abstract String getRunner();
 
-    abstract Integer getValueSizeBytes();
+    abstract int getValueSizeBytes();
 
     static Configuration of(long numRows, int pipelineTimeout, String runner, int valueSizeBytes) {
       return new AutoValue_BigTableIOLT_Configuration.Builder()

it/kafka/src/test/java/org/apache/beam/it/kafka/KafkaIOLT.java

@@ -145,7 +145,7 @@ public void testWriteAndRead() throws IOException {
               region,
               readInfo.jobId(),
               getBeamMetricsName(PipelineMetricsType.COUNTER, READ_ELEMENT_METRIC_NAME));
-      assertEquals(configuration.getNumRows(), numRecords, 10.0);
+      assertEquals((double) configuration.getNumRows(), numRecords, 10.0);
     } finally {
       // clean up pipelines
       if (pipelineLauncher.getJobStatus(project, region, writeInfo.jobId())
@@ -207,13 +207,13 @@ private PipelineLauncher.LaunchInfo testRead() throws IOException {
   /** Options for Kafka IO load test. */
   @AutoValue
   abstract static class Configuration {
-    abstract Long getNumRows();
+    abstract long getNumRows();
 
-    abstract Integer getPipelineTimeout();
+    abstract int getPipelineTimeout();
 
     abstract String getRunner();
 
-    abstract Integer getRowSize();
+    abstract int getRowSize();
 
     static Configuration of(long numRows, int pipelineTimeout, String runner) {
       return new AutoValue_KafkaIOLT_Configuration.Builder()

it/mongodb/src/main/java/org/apache/beam/it/mongodb/conditions/MongoDBDocumentsCheck.java

@@ -30,7 +30,7 @@ public abstract class MongoDBDocumentsCheck extends ConditionCheck {
 
   abstract String collectionName();
 
-  abstract Integer minDocuments();
+  abstract int minDocuments();
 
   abstract @Nullable Integer maxDocuments();
 
@@ -88,7 +88,7 @@ public abstract static class Builder {
 
     public abstract Builder setCollectionName(String collectionName);
 
-    public abstract Builder setMinDocuments(Integer minDocuments);
+    public abstract Builder setMinDocuments(int minDocuments);
 
     public abstract Builder setMaxDocuments(Integer maxDocuments);