Remove LongDoubleConversion from ErrorProne disabledChecks

Author: stankiewicz

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

@@ -1579,7 +1579,6 @@ class BeamModulePlugin implements Plugin<Project> {
             "DirectInvocationOnMock",
             "Finalize",
             "JUnitIncompatibleType",
-            "LongDoubleConversion",
             "MockNotUsedInProduction",
             "NarrowCalculation",
             "NullableTypeParameter",

sdks/java/core/src/main/java/org/apache/beam/sdk/io/Read.java

@@ -298,7 +298,7 @@ public void splitRestriction(
         desiredChunkSize = 64 << 20; // 64mb
       } else {
         // 1mb --> 1 shard; 1gb --> 32 shards; 1tb --> 1000 shards, 1pb --> 32k shards
-        desiredChunkSize = Math.max(1 << 20, (long) (1000 * Math.sqrt(estimatedSize)));
+        desiredChunkSize = Math.max(1 << 20, (long) (1000 * Math.sqrt((double) estimatedSize)));
       }
       List<BoundedSourceT> splits =
           (List<BoundedSourceT>) restriction.split(desiredChunkSize, pipelineOptions);
@@ -1079,7 +1079,7 @@ private Progress tryGetProgressOrThrow() throws IOException {
           if (size != UnboundedReader.BACKLOG_UNKNOWN) {
             // The UnboundedSource/UnboundedReader API has no way of reporting how much work
             // has been completed so runners can only see the work remaining changing.
-            return Progress.from(0, size);
+            return Progress.from(0, (double) size);
           }
 
           // TODO: Support "global" backlog reporting

sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/ApproximateQuantiles.java

@@ -277,7 +277,7 @@ public ApproximateQuantilesCombineFn<T, ComparatorT> withEpsilon(double epsilon)
      * of {@code maxNumElements}.
      */
     public ApproximateQuantilesCombineFn<T, ComparatorT> withMaxInputSize(long maxNumElements) {
-      return create(numQuantiles, compareFn, maxNumElements, maxNumElements);
+      return create(numQuantiles, compareFn, maxNumElements, (double) maxNumElements);
     }
 
     /**
@@ -484,7 +484,8 @@ private QuantileBuffer<T> collapse(Iterable<QuantileBuffer<T>> buffers) {
         newLevel = Math.max(newLevel, buffer.level + 1);
         newWeight += buffer.weight;
       }
-      List<T> newElements = interpolate(buffers, bufferSize, newWeight, offset(newWeight));
+      List<T> newElements =
+          interpolate(buffers, bufferSize, (double) newWeight, (double) offset(newWeight));
       return new QuantileBuffer<>(newLevel, newWeight, newElements);
     }
 

sdks/java/core/src/main/java/org/apache/beam/sdk/util/FluentBackoff.java

@@ -234,7 +234,7 @@ public long nextBackOffMillis() {
           Math.min(
               backoffConfig.initialBackoff.getMillis()
                   * Math.pow(backoffConfig.exponent, currentRetry),
-              backoffConfig.maxBackoff.getMillis());
+              (double) backoffConfig.maxBackoff.getMillis());
       double randomOffset =
           (Math.random() * 2 - 1) * DEFAULT_RANDOMIZATION_FACTOR * currentIntervalMillis;
       long nextBackoffMillis = Math.round(currentIntervalMillis + randomOffset);

sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTrackerTest.java

@@ -183,7 +183,7 @@ public void testProgressAfterFinished() throws Exception {
     tracker.checkDone();
     simpleEstimator.setEstimateRangeEnd(0L);
     Progress currentProgress = tracker.getProgress();
-    assertEquals(Long.MAX_VALUE - 10L, currentProgress.getWorkCompleted(), 0);
+    assertEquals((double) (Long.MAX_VALUE - 10L), currentProgress.getWorkCompleted(), 0);
     assertEquals(0, currentProgress.getWorkRemaining(), 0.001);
   }
 
@@ -197,23 +197,23 @@ public void testProgress() throws Exception {
 
     simpleEstimator.setEstimateRangeEnd(5L);
     Progress currentProgress = tracker.getProgress();
-    assertEquals(cur - start, currentProgress.getWorkCompleted(), 0.001);
+    assertEquals((double) (cur - start), currentProgress.getWorkCompleted(), 0.001);
     assertEquals(0, currentProgress.getWorkRemaining(), 0.001);
 
     simpleEstimator.setEstimateRangeEnd(35L);
     currentProgress = tracker.getProgress();
-    assertEquals(cur - start, currentProgress.getWorkCompleted(), 0.001);
-    assertEquals(35L - cur, currentProgress.getWorkRemaining(), 0.001);
+    assertEquals((double) (cur - start), currentProgress.getWorkCompleted(), 0.001);
+    assertEquals((double) (35L - cur), currentProgress.getWorkRemaining(), 0.001);
 
     simpleEstimator.setEstimateRangeEnd(25L);
     currentProgress = tracker.getProgress();
-    assertEquals(cur - start, currentProgress.getWorkCompleted(), 0.001);
-    assertEquals(25L - cur, currentProgress.getWorkRemaining(), 0.001);
+    assertEquals((double) (cur - start), currentProgress.getWorkCompleted(), 0.001);
+    assertEquals((double) (25L - cur), currentProgress.getWorkRemaining(), 0.001);
 
     simpleEstimator.setEstimateRangeEnd(Long.MAX_VALUE);
     currentProgress = tracker.getProgress();
-    assertEquals(cur - start, currentProgress.getWorkCompleted(), 0.001);
-    assertEquals(Long.MAX_VALUE - cur, currentProgress.getWorkRemaining(), 0.001);
+    assertEquals((double) (cur - start), currentProgress.getWorkCompleted(), 0.001);
+    assertEquals((double) (Long.MAX_VALUE - cur), currentProgress.getWorkRemaining(), 0.001);
   }
 
   @Test