[ErrorProne] Enable EmptyCatch Error Prone check and document ignored exceptions (#37754)

Author: stankiewicz

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

@@ -1538,7 +1538,6 @@ class BeamModulePlugin implements Plugin<Project> {
             "ComparableType",
             "DoNotMockAutoValue",
             "EmptyBlockTag",
-            "EmptyCatch",
             "EqualsGetClass",
             "EqualsUnsafeCast",
             "EscapedEntity",

examples/java/twitter/src/main/java/org/apache/beam/examples/twitterstreamgenerator/TwitterConnection.java

@@ -73,6 +73,7 @@ public void onStatus(Status status) {
             try {
               queue.offer(status);
             } catch (Exception ignored) {
+              // Ignore exceptions during enqueueing.
             }
           }
 

runners/flink/src/main/java/org/apache/beam/runners/flink/metrics/MetricsAccumulator.java

@@ -56,6 +56,7 @@ public Accumulator<MetricsContainerStepMap, MetricsContainerStepMap> clone() {
     try {
       super.clone();
     } catch (CloneNotSupportedException ignored) {
+      // Ignore CloneNotSupportedException
     }
     MetricsAccumulator metricsAccumulator = new MetricsAccumulator();
     metricsAccumulator.getLocalValue().updateAll(this.getLocalValue());

runners/prism/java/src/main/java/org/apache/beam/runners/prism/PrismExecutor.java

@@ -79,6 +79,7 @@ void stop() {
     try {
       boolean ignored = executorService.awaitTermination(5000L, TimeUnit.MILLISECONDS);
     } catch (InterruptedException ignored) {
+      // Ignore InterruptedException during shutdown.
     }
     if (process == null) {
       return;
@@ -90,6 +91,7 @@ void stop() {
     try {
       process.waitFor();
     } catch (InterruptedException ignored) {
+      // Ignore InterruptedException during shutdown.
     }
   }
 

sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GceMetadataUtil.java

@@ -60,6 +60,7 @@ static String fetchMetadata(String key) {
         }
       }
     } catch (IOException ignored) {
+      LOG.debug("Failed to fetch GCE metadata.", ignored);
     }
 
     // The return value can be an empty string, which may mean it's running on a non DataflowRunner.

sdks/java/io/amazon-web-services2/src/test/java/org/apache/beam/sdk/io/aws2/common/AsyncBatchWriteHandlerTest.java

@@ -253,6 +253,7 @@ private void eventually(int attempts, Runnable fun) {
         fun.run();
         return;
       } catch (AssertionError | InterruptedException t) {
+        // Ignore and try again.
       }
     }
     fun.run();

sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/changestreams/dao/DaoFactory.java

@@ -72,6 +72,7 @@ public void close() {
         BigtableChangeStreamAccessor.getOrCreate(changeStreamConfig).close();
       }
     } catch (Exception ignored) {
+      // Ignore exceptions on close.
     }
   }
 

sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java

@@ -1540,6 +1540,7 @@ private int parseBundleStatus(String status) {
         try {
           statusCode = Integer.parseInt(status.substring(0, 3));
         } catch (IndexOutOfBoundsException | NumberFormatException ignored) {
+          // Ignore parsing exception so we can return the default 404
         }
         return statusCode;
       }

sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsub.java

@@ -340,6 +340,7 @@ public List<PubsubMessage> waitForNMessages(int n, Duration timeoutDuration)
       try {
         Thread.sleep(1000);
       } catch (InterruptedException ignored) {
+        // Ignore interrupt and continue polling.
       }
     }
 

sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/TestPubsubSignal.java

@@ -323,6 +323,7 @@ private String pollForResultForDuration(
       try {
         Thread.sleep(1000);
       } catch (InterruptedException ignored) {
+        // Ignore interrupt and continue polling.
       }
     }