Skip to content

[Vector][ExtensionType] ComplexCopier requires that extension types' holder readers implement getField #1109

@bodduv

Description

@bodduv

Describe the bug, including details regarding any error messages, version, and platform.

#892 made efforts to streamline and simplify extension readers and writers. In this, ComplexCopier.copy relies on FieldReader.getField being defined for extension types.

Usages of ComplexCopier.copy with readers backed by vector, e.g., UuidReaderImpl and VariantReaderImpl that do have getField implementation, should be OK (as there is concrete notion of Field). However, if holder readers, namely, NullableUuidHolderReaderImpl or NullableVariantHolderReaderImpl are used this results in an NPE.

Having said that getField method for holder readers appears to be a misnomer as we do not have a notion of a field for the holders. This can be seen from the absence of getField overrides for primitive types.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: bugSomething isn't working

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions